Other people up for reviews: reosarevok, bitmap, zas, ruaok, yvanzo, monkey, alastairp, lucifer, akshaaatt[m], Freso, CatQuest – anyone else who want to give review, let me know ASAP.
reosarevok: Go!
reosarevok
Hi!
Last week I worked quite a bit on extending the artist page filters for release groups
This week I'll concentrate on getting stuff ready for beta release, but I might look into better sir tests now that lucifer got that working? I'll see how the week goes
CatQuest: what about you?
CatQuest
just a sec
Meow! `😺`
sadface in that unfortunately ✨New Browser™✨ didn't work out, there is still one webextension(?) (old ff) addon that will not work in the new one (and it was one i'm absolutely dependant on for instrument adding work :/)
in better news, other endeavours are going swimmingly!
I also added a lot of books to bb, will try to get all the tickets i've been writing in notes onto jira!
finally i helped reo find a privacy tag issue that he fixed :D MBS-11976
I worked on a lot more on the batch-add-relationships and batch-create-works dialogs in the new relationship editor code. the latter has been modified to support multiple work languages
this is one of the last big pieces remaining though, at least
otherwise I did a bit of code review / merging earlier in the week. fin!
go yvanzo
yvanzo
Hi!
Last week I reviewed a fair amount of MBS PRs for the release scheduled for the 4th of October.
Freso
(Others still up: ruaok, monkey, alastairp, lucifer, akshaaatt[m], Freso – anyone else who wants to give review, let me know ASAP.)
yvanzo
Also implemented and deployed threads limitation for MB dump builders.
Plus worked on smaller issues, restored SIR, support, triage...
I will join monkey and the Barceloners on Wednesday for half-work half-vacations.
CatQuest
" the latter has been modified to support multiple work languages" !!!! AWESOME
yvanzo
I will be less available for about two weeks.
CatQuest
have a good vacatin :)
yvanzo
Also planning for another move shortly after the MeB Summit.
CatQuest
vacation even
yvanzo
Fin. Go monkey!
monkey
Yo !
Last week I worked with ruaok to add a new page to Listenbrainz to see the tracks you liked/hated:
I also fixed our javascript automated tests that were outputting a massive amount of logs and warnings, making the CI logs output basically unusable
And finally had an IRL chat with ruaok and alastairp about the structure of listens metadata
Speak of the devils, go alastairp !
alastairp
hullo
last week I did some LB and CB reviews
I had a good discussion with ruaok about what's needed to finish my PR on renaming users in LB, that just needs one more change
I had a discussion about building a nuclear power station
and then a discussion about what to name fields in a listen json structure
one of them took longer than the other
finally, I spent some more time migrating AB js to typescript, fixing all of the eslint errors
ruaok: next up?
ruaok
k
last week was a lot of work on the MBID mapping/album lookups and the like.
Freso
(Only lucifer, akshaaatt[m], and Freso left on my list – last call for anyone else who want to give review!)
ruaok
monkey and I worked on the new feedback page for LB where you can see the tracks you loved/hated, which means you can now play that page, which is really cool!
CatQuest
:o
that is cool
ruaok
I'm on a bit of a bend right now to go improve music discovery workflow in LB -- we've got some tools ready, but they are not well integrated yet.
so, aiming to fix that over the next few weeks, so we have some working methods for music discovery.
CatQuest
dude cool
ruaok
oh yeah, we also thought up something cool for the team for the summit. :)
ruaok is a tease
fin. akshaaatt[m], go!
akshaaatt[m]
Hi everyone!
This week I progressed my work on the mb interface.
I have so far gone from vanilla js < react basics < react hooks < remastering to components < using typescript < normal bootstrap < trying react bootstrap and react strap < trying other methods < making a global style < giving individual styles to components
Currently, the things seems fine
My work got a bit complicated this week because I was literally adjusting the same things to different formats again and again.
I am giving extra care to things rn because if I don’t follow the best solutions from the beginning, I might have to face the consequences of messing up the format later.
The good news is that the design from my end is final and I am waiting to have it come live before I ask for feedback.
I started making PRs yesterday and hopefully a lot incoming to expect from me this week.
CatQuest
!m akshaaatt[m]
BrainzBot
You're doing good work, akshaaatt[m]!
akshaaatt[m]
fin! go lucifer
lucifer
hi all!
i worked on finishing up and testing the sir PR. it seems to work fine so far. it has been up on test.mb for some days. we do not have a good test suite for sir currently so it works. correctly or not is another question. do test out the search functionality on test and please report any issues you find.
CatQuest
hi luci..fer
alastairp
!m for work on sir!
BrainzBot
You're doing good work, for work on sir!!
ruaok
yes, thank you!
alastairp
lucifer ... workonsir
lucifer
other than that i worked on cleaning up the stats setup in LB backend and started work on adding sitewide stats
:)
Freso: next?
Freso
o/
Seems like I get to wrap this up. :)
Dealt with reports across the various sites, did some admin stuff on forums and the user report mailing list, and was generally around and about.
fin.
Which wraps up reviews!
Thank you everyone who gave reviews for your reviews!
Two more items on tonight’s agenda…
ruaok: invoices
CatQuest
💪
Freso
ruaok: Ping?
ruaok
sorry.
ok, here is what I want to try:
the first team meeting after the 3 day period for people to get their invoices in, I'll add a meeting item, where the offenders get a chance to explain why they failed to submit the invoices.
you can get out of it, by submitting your invoice before the item comes up.
we'll see how that works. :)
fin.
CatQuest
seems liek a good idea to me. also if someoen had a legit reason it's fair too
Freso
SGTM
monkey
👍
Freso
Alright, not sure if there’s going to be any discussion?
ruaok
none invited. :)
Freso
So, uh, let’s just move on to final topic.
reo: dead link collection
CatQuest
reosarevok:
reosarevok
Hi!
So, we got a message from someone who works with wikidata data and was also looking at MB and then at stuff linked *from* MB
With many thousands of URLs linked to artists that seem dead
That does include ended rels (since they didn't know about those) but a large majority are probably legit
I have no idea what to do with that info though (it's a very very large file)
CatQuest
fwiw i fix instrument ones if i see them
reosarevok
Any suggestions? I could just throw it on the forum and see if anyone does anything, but...
ruaok
to be clear, these are links that end in 404?
CatQuest
a report/list/scrap of the instrument ones would be fine
reosarevok
Or 403, or a few other things IIRC
ruaok
if not 200, is there ANY value in keeping them?
CatQuest
(these are links *from* wikidata *to* mb right?)
reosarevok
CatQuest: no, these are links in MB to other sites