that was quite interesting. I bet aerozol will snooze his way right through this for a 100% score.
2022-11-21 32531, 2022
BrainzGit
[listenbrainz-server] 14amCap1712 merged pull request #2259 (03master…fix-filter-artist-credit): Revert "Use artist_credit_id instead of artist mbids for artist credit filtering" https://github.com/metabrainz/listenbrainz-server…
In today's edition of "WTF is my test suite doing‽", not only did I have tests failing in CI while all tests pass locally, and no way to know which test was failing in CI, now it looks like it is running tests that do not exist on the branch being tested…
will need to add an if probably because these works run on pushes to master as well, not just PRs.
2022-11-21 32549, 2022
monkey
Thanks, I'll look into it
2022-11-21 32528, 2022
lucifer
but yeah possible. i have been bitten by this previously as well but i guess it makes sense to see if tests will fail after merge. no strong preference though
2022-11-21 32554, 2022
lucifer
i can update the actions today or tomorrow if it helps. i'll be needing your help on some UI stuff anyway :)
2022-11-21 32516, 2022
lucifer
*ui stuff very soon
2022-11-21 32550, 2022
monkey
I see why it is set up that way. It's either 1) run test against the content of the branch, devs should remember to keep branch up to date (which is sometimes not easy) or 2) risk having failing tests after merging to master.
2022-11-21 32551, 2022
monkey
On possibility would be to require that the branch be up-to-date before merging, but I don't know if there is an automated check for that
2022-11-21 32554, 2022
monkey
One*
2022-11-21 32529, 2022
monkey
Or perhaps we have two separate test suites, one against current branch, one against branch merged with master
Anyone with React/Jest experience, please review a handful of files and let others know which files you reviewed :)
2022-11-21 32556, 2022
monkey goes pack his suitcase
2022-11-21 32536, 2022
alastairp starts preparing to come home...
2022-11-21 32558, 2022
BrainzGit
[musicbrainz-android] 14dependabot[bot] opened pull request #159 (03master…dependabot/gradle/hilt_version-2.44.2): Bump hilt_version from 2.44.1 to 2.44.2 https://github.com/metabrainz/musicbrainz-android…
And a million thank yous for the hint about the merged-branch-tests thing, it was driving me nuts
2022-11-21 32514, 2022
kellnerd joined the channel
2022-11-21 32508, 2022
kellnerd
"Can't Unsee - 7330 - Rank GOLD (top 10%) - Completed in 00:21:44 - You are 200 points away from platinum" - I think I only had three or four designs wrong :)
2022-11-21 32500, 2022
kellnerd
Setting a new bar for aerozol, although kiwiirc won't let me upload a proof screenshot right now.
I have not received any mailed in reviews, so the usual people are up: yvanzo, zas, atj, lucifer, monkey, alastairp, reosarevok, bitmap, akshaaatt, mayhem, yellowhatpro, Pratha-Fish, riksucks, CatQuest, Shubh, Freso – anyone else who wish to give review, please let me know ASAP. :)
2022-11-21 32503, 2022
Freso
yvanzo: Go!
2022-11-21 32542, 2022
yvanzo
Hi!
2022-11-21 32550, 2022
yvanzo
Last week I looked into security alerts, closed 24 SEC tickets, merged 3 related pull requests.
2022-11-21 32551, 2022
aerozol
Ata mārie Freso, I'll go too thanks!
2022-11-21 32516, 2022
yvanzo
99 more SEC tickets have been closed by bitmap, lucifer, mayhem, monkey, and zas.
2022-11-21 32532, 2022
alastairp
Freso: I'm on holiday please take me off!
2022-11-21 32536, 2022
yvanzo
There still are 140 open SEC tickets, all of which are now assigned.
2022-11-21 32511, 2022
aerozol
Wow team, that's a lot of closed tickets
2022-11-21 32517, 2022
yvanzo
So thanks to all, keep it up, half of the way has been made already!
2022-11-21 32548, 2022
yvanzo
Also investigated an incident with 5xx codes on MB website with zas.
2022-11-21 32558, 2022
yvanzo
Plus various support and some MBS PR reviews.
2022-11-21 32528, 2022
yvanzo
aerozol: SEC tickets can be quickly closed, it doesn’t necessarily require a patch, just to be investigated.
2022-11-21 32538, 2022
yvanzo
Fin, go aerozol!
2022-11-21 32558, 2022
aerozol
Hi all! Can't sleep so here I am 😝
2022-11-21 32500, 2022
Freso
(Still up: zas, atj, lucifer, monkey, reosarevok, bitmap, akshaaatt, mayhem, yellowhatpro, Pratha-Fish, riksucks, CatQuest, Shubh, Freso – anyone else who wish to give review, please let me know ASAP.)
2022-11-21 32548, 2022
yvanzo
(because there are false positive some alerts are about the same dependencies)
2022-11-21 32502, 2022
aerozol
Last couple of weeks I've been working a lot on the LB redesign with monkey, it's coming along. Heavily simplifying the menu but making sure all the interesting stuff is still very near by, seems to be the way to go
2022-11-21 32546, 2022
aerozol
I'm tandem, working on a 'target audience' doc with monkey and mayhem that is bringing up some interesting questions
2022-11-21 32530, 2022
akshaaatt likes being targeted as an audience
2022-11-21 32531, 2022
mayhem
working with me always brings up interesting questions
2022-11-21 32533, 2022
aerozol
Made a MB and MeB slide template - if you give presentations please let me know if I can add any others or make changes
2022-11-21 32557, 2022
mayhem
thanks for doing that. I'm looking forward to using those next time I need to give a talk
I look forward to more bug fixes and optimisation stuff , LB-android is gonna be a hit ヾ(＠⌒ー⌒＠)ノ
2022-11-21 32501, 2022
yellowhatpro
That's all from my side. riksucks next ??
2022-11-21 32518, 2022
riksucks
hi guys!
2022-11-21 32551, 2022
riksucks
I worked on the playlist view and am working on including the NamePill element I wrote for recommendation modal
2022-11-21 32559, 2022
riksucks
in the playlist view
2022-11-21 32526, 2022
riksucks
making the UI more unified, I will have a PR by tomorrow, that's it tbqh, fin
2022-11-21 32539, 2022
riksucks
lucifer: do you wanna go next?
2022-11-21 32547, 2022
lucifer
sure. hi!
2022-11-21 32546, 2022
Freso
👀
2022-11-21 32559, 2022
lucifer
last wee, I worked on fixing bugs in the cover art query in the metadata cache, further improved error handling in daily jams, fixed an issue in TS writer. also worked on adding an api so that users can mark artists/albums/recordings that should not be recommeneded to them,
2022-11-21 32531, 2022
monkey
Weee !
2022-11-21 32545, 2022
lucifer
lastly, worked on adding a cron job to look for msids which have been mapped and update that in various places. that's it for me.
2022-11-21 32554, 2022
lucifer
monkey: next/
2022-11-21 32559, 2022
monkey
Hello !
2022-11-21 32506, 2022
Freso
(Still up: zas, atj, reosarevok, bitmap, mayhem, Pratha-Fish, CatQuest, Shubh, Freso – anyone else who wish to give review, please let me know ASAP.)
2022-11-21 32518, 2022
monkey
I spent pretty much all of last week (!) working on updating each front-end test in ListenBrainz as part of the React 18 update PR (LB#2233) Such a PITA that was!
Considering this modifies the entire test suite I would appreciate some help reviewing the changes. If a few people review a handful of files we can make quick work of it. Anyone with some React experience, please help, you're my only hope…
2022-11-21 32506, 2022
monkey
I also helped lucifer improve/fix some of our code to fetch cover art in LB.
2022-11-21 32517, 2022
monkey
Had a great video chat with aerozol and reviewed some aspects of the redesign. I'm looking forward to the new improved UI and UX !
2022-11-21 32532, 2022
monkey
Spent some time reviewing SEC tickets — thanks yvanzo for dispatching! Plus a sprinkle of PR reviews and other repo upkeep.
2022-11-21 32541, 2022
aerozol
Ooh yes great meeting!
2022-11-21 32553, 2022
monkey
I'm flying away to the US tomorrow morning; I'll be on-and-off for the next two weeks, but responding to messages when I can (at west coast work times). That's me done !
