Haven’t looked at your most recent updates bitmap yet, but looking great!!
2023-01-30 03048, 2023
bitmap
thanks aerozol :)
2023-01-30 03053, 2023
yvanzo
Last week I kept up the Documarathon about MB Solr and MB URL mainly.
2023-01-30 03005, 2023
Freso
(Still up: atj, vibhoo_24, jivte, yellowhatpro, jasje, Freso – anyone else who want to give review, let me know ASAP. :))
2023-01-30 03009, 2023
yvanzo
Also completed and sent a review of Weblate ToS after they resolved technical issues.
2023-01-30 03023, 2023
yvanzo
bitmap, reosarevok and I had a video call about getting the MB dev team back together.
2023-01-30 03036, 2023
yvanzo
It was informal, mostly about communication and common expectations.
2023-01-30 03044, 2023
yvanzo
We will have our first development meeting here on Thursday.
2023-01-30 03006, 2023
yvanzo
It will focus on delivering the relationship editor obviously. :)
2023-01-30 03013, 2023
yvanzo
Fin, go atj!
2023-01-30 03020, 2023
atj
hi
2023-01-30 03050, 2023
atj
not much to report, i assisted zas with some issues bootstrapping the new discourse server
2023-01-30 03009, 2023
atj
and wrote a pr which zas had already created :)
2023-01-30 03020, 2023
atj
jasje?
2023-01-30 03031, 2023
jasje
Hi everyone!
2023-01-30 03009, 2023
jasje
Last week i fixed 1 bug
2023-01-30 03016, 2023
jasje
1 Ui fix
2023-01-30 03036, 2023
jasje
and if we count 1 hour before this meeting as last week
2023-01-30 03048, 2023
jasje
2 bugs in total
2023-01-30 03004, 2023
akshaaatt
!m jasje
2023-01-30 03004, 2023
BrainzBot
You're doing good work, jasje!
2023-01-30 03012, 2023
jasje
not much going on since sentry is helping alot
2023-01-30 03018, 2023
jasje
!m sentry
2023-01-30 03018, 2023
BrainzBot
You're doing good work, sentry!
2023-01-30 03040, 2023
CatQuest
lol
2023-01-30 03058, 2023
jasje
and looking forward to implement ui tests (akshaaatt?)
2023-01-30 03014, 2023
akshaaatt
Obviously
2023-01-30 03019, 2023
jasje
thats it for me
2023-01-30 03021, 2023
Freso
(Still up: vibhoo_24, jivte, yellowhatpro, Freso – anyone else who want to give review, let me know ASAP. :))
2023-01-30 03022, 2023
jasje
jivte?
2023-01-30 03052, 2023
Freso
Looks like no jivte is around.
2023-01-30 03000, 2023
Freso
No vibhoo either.
2023-01-30 03002, 2023
Freso
yellowhatpro: Go?
2023-01-30 03015, 2023
Freso
Or not.
2023-01-30 03019, 2023
Freso
Freso: Go!
2023-01-30 03021, 2023
Freso
🙋
2023-01-30 03035, 2023
jasje
xD
2023-01-30 03041, 2023
yvanzo
Stay!
2023-01-30 03002, 2023
Freso
So I dealt a bit with answering questions about BrainzBot as well as writing up some docs for some of the basic administration of it via its admin interface. I sent them to alastairp earlier, so hopefully they will go into syswiki or somewhere? Idk.
2023-01-30 03034, 2023
Freso
Also cleared up some uncertainties about the Discourse upgrade.
2023-01-30 03030, 2023
Freso
Spent some time looking at reports and flags etc. as well as just generally keeping an eye on IRC, forums, e-mail, etc.
2023-01-30 03032, 2023
Freso
Finally, I will hopefully start treatment next month, and I will be taking a longer leave of absence until the end of the year to give me time to try and focus on this, so this will be my last meeting for the foreseeable future.
2023-01-30 03012, 2023
aerozol
Sorry to hear that Freso!! But finally treatment!?
2023-01-30 03013, 2023
CatQuest
:o :hugs: freso
2023-01-30 03014, 2023
Freso
If you have any process or thing that you would like me to document or grant access to, please e-mail me and I’ll do my best to get it dealt with tomorrow.
Hope things go well for you Freso. Just curious, during your absense, who will be looking after the weekely meetings and where should be mailed in reports be addressed?
2023-01-30 03026, 2023
jasje
akshaaatt: ill have a look
2023-01-30 03035, 2023
Freso
rdswift: I will assume community-manager@metabrainz.org gets redirected to someone else, and that should probably be the address used.
2023-01-30 03050, 2023
rdswift
👍
2023-01-30 03043, 2023
rdswift
I assume the same for editor and community abuse reports?
2023-01-30 03045, 2023
mayhem
rdswift: we'll work out all those details tomorrow. but I suspect that reosarevok and I will lead the meetings. unless you have a burning desire to do it. :)
2023-01-30 03026, 2023
rdswift
No burning desire. ;-) ... But I can help if needed.
2023-01-30 03059, 2023
Freso
rdswift: Feel free to e-mail me at freso@ and I’ll look it over tomorrow. :)
2023-01-30 03037, 2023
rdswift
No problem. I was just making sure that any loose ends were tied up before you take off. With all that's going on in your life, I can see how something might easily slip through the cracks.
2023-01-30 03007, 2023
mayhem
heh, I appreciate someone else thinking about these things. :)
2023-01-30 03048, 2023
rdswift
Truth be told, I'm better at asking the questions than providing the answers. ;-)
2023-01-30 03015, 2023
CatQuest
I mean, (and I mean this really) if I can do anything, really, to help please ask!
2023-01-30 03048, 2023
jasje has quit
2023-01-30 03028, 2023
BrainzGit
[bookbrainz-site] 14dependabot[bot] opened pull request #922 (03master…dependabot/npm_and_yarn/faker-js/faker-7.6.0): chore(deps-dev): bump @faker-js/faker from 7.2.0 to 7.6.0 https://github.com/metabrainz/bookbrainz-site/pul…
2023-01-30 03032, 2023
BrainzGit
[bookbrainz-site] 14dependabot[bot] opened pull request #923 (03master…dependabot/npm_and_yarn/jsdom-21.1.0): chore(deps-dev): bump jsdom from 20.0.0 to 21.1.0 https://github.com/metabrainz/bookbrainz-site/pul…
2023-01-30 03006, 2023
BrainzGit
[bookbrainz-site] 14dependabot[bot] opened pull request #924 (03master…dependabot/npm_and_yarn/rewire-6.0.0): chore(deps-dev): bump rewire from 5.0.0 to 6.0.0 https://github.com/metabrainz/bookbrainz-site/pul…
2023-01-30 03038, 2023
BrainzGit
[bookbrainz-site] 14dependabot[bot] opened pull request #925 (03master…dependabot/npm_and_yarn/mini-css-extract-plugin-2.7.2): chore(deps-dev): bump mini-css-extract-plugin from 2.5.3 to 2.7.2 https://github.com/metabrainz/bookbrainz-site/pul…
2023-01-30 03045, 2023
BrainzGit
[bookbrainz-site] 14dependabot[bot] opened pull request #926 (03master…dependabot/npm_and_yarn/redis-4.6.3): chore(deps): bump redis from 3.1.2 to 4.6.3 https://github.com/metabrainz/bookbrainz-site/pul…
2023-01-30 03050, 2023
BrainzGit
[bookbrainz-site] 14dependabot[bot] closed pull request #904 (03master…dependabot/npm_and_yarn/redis-4.5.1): chore(deps): bump redis from 3.1.2 to 4.5.1 https://github.com/metabrainz/bookbrainz-site/pul…
(the pink is some userscript I don't have disabled on test, but I assume that's not connected to the double green box)
2023-01-30 03017, 2023
bitmap
oh you mean how there's two highlighted items?
2023-01-30 03012, 2023
reosarevok
Yeah
2023-01-30 03024, 2023
reosarevok
Sorry, maybe wasn't the clearest gif :)
2023-01-30 03015, 2023
bitmap
one has keyboard focus (so will be selected if you press tab or enter) and the other is just a mouseover effect (I agree this is confusing and we should distinguish them somehow)
2023-01-30 03032, 2023
bitmap
was thinking about how to do that yesterday actually, but nobody had brought it up yet so I left it alone :)
2023-01-30 03038, 2023
reosarevok
Hmm
2023-01-30 03047, 2023
reosarevok
Is it possible to move the keyboard focus with the mouse?
2023-01-30 03000, 2023
reosarevok
So that if I press Enter it'll select whatever the mouse is on?
2023-01-30 03010, 2023
reosarevok
aerozol might have some ideas too, dunno
2023-01-30 03042, 2023
aerozol
I have to run in a sec, but it seems in the current setup it does what you’re saying reo - mouseover and keyboard selection is the same
2023-01-30 03010, 2023
aerozol
Hmm doesn’t currently work with tab, just up and down arrows, is that what’s different?
2023-01-30 03021, 2023
mayhem
wtf?
2023-01-30 03024, 2023
aerozol
Tab confirms selection and moves onto the next field - which might be pretty good behavious. I’m not much of a keyboard editor though so can’t say for sure
aerozol: if you move around with the mouse, it still keeps the top selection green - and if you click with the mouse it selects whatever you're on, but if you press enter or whatever it selects the first selected green box
2023-01-30 03038, 2023
reosarevok
(and you can move the selections separately if you both move the mouse and with the up/down keys)
2023-01-30 03052, 2023
aerozol
reosarevok: yeah I got that from your gif! I was just describing how it works currently on prod
2023-01-30 03057, 2023
reosarevok
Oh, I see
2023-01-30 03000, 2023
aerozol
Should have been clearer
2023-01-30 03043, 2023
reosarevok
And yeah, that's what happens in prod and I like it, sometimes I end up moving my mouse but then deciding that I want the one immediately over and moving with the arrow or something
2023-01-30 03046, 2023
reosarevok
I'm weird, dunno :D
2023-01-30 03059, 2023
reosarevok
But them being one and the same does seem clearer anyway
2023-01-30 03030, 2023
reosarevok
bitmap: are the selenium failures random you think?
2023-01-30 03050, 2023
aerozol
I agree that current prod behaviour seems better (without actually testing both… I gotta run!)
2023-01-30 03055, 2023
bitmap
yeah I could make it move the keyboard focus with the mouse so there's only one focus
2023-01-30 03002, 2023
reosarevok
aerozol: good running! :p
2023-01-30 03008, 2023
reosarevok
bitmap: that'd be sweet if it's simple
2023-01-30 03040, 2023
reosarevok
bitmap: also, did you have any time to look into readding the dates section help?
2023-01-30 03052, 2023
CatQuest
honestly I actually see reo's point, I will use the mouse and it hovers over something and I will use arrowkey to go up or down fro mthat
2023-01-30 03010, 2023
reosarevok
I rarely do it, but it has happened :D
2023-01-30 03014, 2023
CatQuest
hover/select/hover/whatever
2023-01-30 03020, 2023
CatQuest
yes
2023-01-30 03021, 2023
bitmap
it's not hard but I used css for mouseover because it's a lot faster (to do it the other way we need events that run every time the mouse moves which also renders the entire autocomplete again)
2023-01-30 03040, 2023
bitmap
but I'll see if there's a way to optimize it
2023-01-30 03001, 2023
CatQuest
I'm having deja vu of bookbrainz dropdown discussions
2023-01-30 03007, 2023
bitmap
reosarevok: selenium failures might be legit, I'll check. and no I forgot about the dates thing! sorry
2023-01-30 03015, 2023
reosarevok
bitmap: is it like "optimizing" slow or "I can actually see this go slow" slow? :D
2023-01-30 03027, 2023
reosarevok
If the first, I'd implement it now and optimize later
2023-01-30 03045, 2023
reosarevok
And maybe you can look into adding the date stuff before we merge to beta? :)
2023-01-30 03055, 2023
reosarevok
So we don't forget again
2023-01-30 03031, 2023
bitmap
I remember it feeling a bit laggy but not unbearable or anything
2023-01-30 03019, 2023
reosarevok
Ok, not a lot to say about the PR other than these two issues I guess :)
2023-01-30 03027, 2023
reosarevok
Left a few comments anyway
2023-01-30 03030, 2023
reosarevok
But minor ones
2023-01-30 03035, 2023
bitmap
getting selenium tests set up again so I can debug those. dunno how much longer you'll be awake but I can either deploy beta tonight, or I could continue working on the menu highlight stuff and we could release early tomorrow
2023-01-30 03008, 2023
bitmap
(tomorrow is prob better tho)
2023-01-30 03045, 2023
reosarevok
I might be off tomorrow during the day but I can find some time in the morning to test the stuff probably
2023-01-30 03041, 2023
bitmap
np, I'll release the current stuff tonight and open a separate pr for the menu stuff then, I can just do another release tomorrow
