monkey: in the snippet above, all the { var } instances work except for the img tag one. what do I need to do differently there?
monkey
Ahaa, I think you can't name variables like html tags or other reserved words
mayhem
ah, ok.
monkey
So it would be renaming the `img` prop to something else
Otherwise it'll probably get confused by `<img src={img}…`
bitmap
yvanzo: since the artist index component is run from the template renderer (Node) rather than in the browser
monkey
Ah, but I see something else mayhem: your string extrapolation won't work like this; you need to pass a template string (with backticks) in curly brackets, and add a dollar: ``src={`/static/img/explore/${img}`"``
mayhem
monkey: that wasn't it
monkey
Ek.
src={`/static/img/explore/${img}`"
With backticks
yvanzo
bitmap: right, better inject it into root/static/scripts/artist/index.js then
bitmap: so we don't know what's causing ISEs in ws/js?
Have we seen those in beta/prod or is it just the test container?
HitenVidhani[m]
Hello everyone, I am Hiten Vidhani, an undergrad student pursuing Computer Science. I wish to collaborate in the project "Music Recommendation: Implement a new Troi patch for generating music recommendations" as a part of GSoC'23. I have previously worked on Data Science and Machine Learning projects using python, and I feel my experience would be beneficial in pursuing this project. Could anyone please help me get started?
(Reposting it as the message probably got lost😅)
bitmap
I've only seen these in the Selenium tests but maybe they happen in prod too when the search server can't be reached. I haven't figured it out anyway, but we could add more logging
reosarevok
Can it be made to retry a couple times if it gets a 500 or something?
(plus the logging, I mean, that would not hurt)
bitmap
yeah it could probably retry it somehow
though i'm not sure we'll bother checking the logs if the tests pass
reosarevok
heh
Fair too
So component is the React component which failed, and url the URL the user was on when the error happened?
bitmap
yep
or whatever was passed to component_path, or React.embed
reosarevok
Ok
Sounds good to me
Should we rerun the selenium test until it fails? :p
bitmap
that won't give any more information than the previous failure did :)
reosarevok
Fair
So we merge this, and then what, we try to figure out how to trace the 500s better? :/
bitmap
well those 500 errors aren't related to the PR, I was just bringing them up 'cause the tests happened to fail with those again
reosarevok
Yeah, I know
I mean, we should merge this anyway
I'm just wondering if there's literally any next step :)
To figure out those 500
bitmap
I could open another PR with some logging and we could run that until they fail I guess
reosarevok
Maybe?
bitmap
it was basically your idea :D
reosarevok
I mean, if you can think of some good logging that could help
hey reosarevok soo I tried fetching all city names from wikidata and it looks like I could only fetch about 39k city names... For reference, the MB areas section has 118k+ areas
reosarevok
Well, not all of MB areas are cities :)
But also, Wikidata stuff might not be listed as city, but as a separate kind of thing, like the official organisational level for cities in that specific country
bitmap: yay
Pratha-Fish
Oh right. I am definitely doing something wrong here
Maybe we could tweak this query to get the actual data that we might need
reosarevok
That's kinda-sorta the idea
HorusHorrendus joined the channel
Keep in mind for example this only returns cities that have a value for population
And coordinates
yvanzo
!m bitmap
BrainzBot
You're doing good work, bitmap!
aerozol
Mōrena! I’m giving up on catching up on the chat before the meeting I think!
BilleeKhoj
fish
wait. what is fish in hindi
reosarevok
Pratha-Fish: removing those two things gives 82548 results, for example
Siddhart1o1 has quit
Pratha-Fish
reosarevok: yea, and looks like a lot of these cities have a population "0"
That's nice to hear :)
reosarevok
<BANG>
Another week has passed. How? But anyway, here we are
People in my list today are reosarevok, bitmap, zas, mayhem, yvanzo, monkey, lucifer, akshaaatt, atj, aerozol, CatQuest, Pratha-Fish, riksucks, jasje, jivte
yvanzo: how was your week?
Ok, I'll start while yvanzo appears :)
yvanzo
Hi!
BilleeKhoj
uh oh
reosarevok
Ok, fine, yvanzo, go on! :)
yvanzo
Last week I kept working on beta relationship editor mostly.
jivte joined the channel
Investigated release-blocking issues and addressed a few ones.
(Last issue of unknown impact is under active investigation by bitmap mainly.)
Vishwajeet878 has quit
Plus support, small maintenance tasks (GoogleIndexing, Jira, Weblate...)
Fin, go jivte!
jivte
Hey everyone!!
So last week was pretty busy as my college is demanding attendance daily:|
And yeah I and monkey improved the add listen feature and is almost completed
Pratha-Fish relates with the attendance requirements🗿
Moreover had a nice conversation with aerozol about fresh releases UI/UX changes
Hope to talk today with mayhem abt the feature more if mayhem is free today
this is all from my side
go monkey
monkey
Hello !
BilleeKhoj
🐒
monkey
Last week on the LB front I finished maiming our Youtube player to satisfy their terms of services; hopefully we'll get our quota increase now.
Also worked on improving the ListenCard layout and the missing MB data modal
And started working on the ListenBrainz redesign, actual CSS/visual stuff this time !
Also helped ongoing PRs
On the BookBrainz front, Helped on some guidelines and some other repo upkeep tasks
Started reviewing in depth the revision reverting PR (now on test.bookbrainz.org )
And deployed a new version fo the website
And some PR Reviews !
Lots of activity in BookBrainz at the moment, with all kinds of new contributors, both new and old :)
Nice to see !
reosarevok
People in my list today are reosarevok, bitmap, mayhem, lucifer, akshaaatt, atj, aerozol, CatQuest, Pratha-Fish, riksucks, jasje
monkey
That's it for me, reosarevok go !
reosarevok
Hi!
I worked a bit more on reports and whatnot, plus a lot of code review and making sure we're ready for the relationship editor release which should hopefully happen today.
I also worked for a few hours on a kinda-sorta related issue to the relationship editor ones, MBS-12622, and on an issue to help me deal with spammers better, MBS-12902
Next up is zas, who mailed just after the meeting started:
'''
This week, I worked on setting up new backup disks and upgrading to new version of Borg. I ran multiple sanity checks, and copied all data from old disks to new ones. I also modified dashboard and alerts accordingly.
Plus usual supervision, upgrades, user support, PRs reviews and MB edits.
'''
Next can be CatQuest aka BilleeKhoj
BilleeKhoj
Machali!
reosarevok
People left in my list are bitmap, mayhem, lucifer, akshaaatt, atj, aerozol, Pratha-Fish, riksucks, jasje
BilleeKhoj
unfortunately I got ill so I haven't been doing much
I went through some MusicBrainz projects and found the "Automate areas management in MusicBrainz" thing pretty interesting, and last week I went back and forth with reosarevok to try and understand the problem statement
Looking forward to exploring this project for a while :)
fin 🐟
bitmap: would you like to go next?
bitmap
hey
last week I finished working on MBS-12924 though the PR ended up causing some other subtle bugs and test failures I spent a few days fixing
so I think most of my hours last week were spent fixing or adding tests, working on improving the logging/build artifacts in our Selenium tests, and code review