#metabrainz

/

      • akshaaatt
        Hi jasje! Thanks a lot for the post. Looks great to me :)
      • 2023-03-13 07227, 2023

      • akshaaatt
        Just a thing though, yt music addition doesn’t work completely yet because our api key has some problems working with the restrictions
      • 2023-03-13 07207, 2023

      • akshaaatt
        Hi aerozol ! I do agree with the things uiu have said
      • 2023-03-13 07211, 2023

      • akshaaatt
        You*
      • 2023-03-13 07248, 2023

      • aerozol
        Cool! I’m thinking it will make life much easier, if not as interesting
      • 2023-03-13 07249, 2023

      • antlarr has quit
      • 2023-03-13 07223, 2023

      • jivte has quit
      • 2023-03-13 07207, 2023

      • antlarr joined the channel
      • 2023-03-13 07201, 2023

      • jivte joined the channel
      • 2023-03-13 07209, 2023

      • akshaaatt
        Btw aerozol , just fyi that making UI components in mobile apps is easier and quicker, so feel free to add more fancy components for the mobile apps
      • 2023-03-13 07203, 2023

      • aerozol
        akshaaatt: ah man that sounds so fun! For me the current priority is to get everything looking cohesive and nice, after that I’d love to do some nicer animation and cool stuff…
      • 2023-03-13 07231, 2023

      • akshaaatt
        Yus
      • 2023-03-13 07208, 2023

      • aerozol
        “after that” lol
      • 2023-03-13 07240, 2023

      • jivte has quit
      • 2023-03-13 07224, 2023

      • kaine21 has quit
      • 2023-03-13 07244, 2023

      • kaine21 joined the channel
      • 2023-03-13 07205, 2023

      • Sophist-UK has quit
      • 2023-03-13 07214, 2023

      • Sophist-UK joined the channel
      • 2023-03-13 07242, 2023

      • reosarevok
        bitmap: re: MBS-12826 - do you already have any ideas to make that code less slow?
      • 2023-03-13 07243, 2023

      • BrainzBot
        MBS-12826: Anything that would reorder large series causes timeouts https://tickets.metabrainz.org/browse/MBS-12826
      • 2023-03-13 07249, 2023

      • saumon joined the channel
      • 2023-03-13 07206, 2023

      • kellnerd joined the channel
      • 2023-03-13 07231, 2023

      • lucifer
        mayhem_: hi!
      • 2023-03-13 07211, 2023

      • reosarevok
        lucifer: mayhem_ is on a plane, apparently
      • 2023-03-13 07217, 2023

      • reosarevok
        (maybe with internet though, dunno)
      • 2023-03-13 07240, 2023

      • lucifer
        ah right, thanks reosarevok. well nothing urgent.
      • 2023-03-13 07259, 2023

      • reosarevok
        He's supposed to miss the meeting today too, so probably a long day? :
      • 2023-03-13 07217, 2023

      • lucifer
        makes sense
      • 2023-03-13 07219, 2023

      • yvanzo
        O’Moin
      • 2023-03-13 07221, 2023

      • yvanzo
      • 2023-03-13 07225, 2023

      • lucifer
        oh i see. thanks yvanzo!
      • 2023-03-13 07244, 2023

      • BrainzGit
        [musicbrainz-server] 14reosarevok opened pull request #2895 (03master…MBS-12994): MBS-12994: Treat email as case-insensitive for admin email search https://github.com/metabrainz/musicbrainz-server/…
      • 2023-03-13 07202, 2023

      • BrainzGit
        [bookbrainz-site] 14MonkeyDo merged pull request #941 (03master…dependabot/npm_and_yarn/types/lodash-4.14.191): chore(deps-dev): bump @types/lodash from 4.14.177 to 4.14.191 https://github.com/metabrainz/bookbrainz-site/pul…
      • 2023-03-13 07216, 2023

      • BrainzGit
        [musicbrainz-server] 14yvanzo merged pull request #2891 (03master…drop-some-href-overrides): Drop some obsolete URL href overrides https://github.com/metabrainz/musicbrainz-server/…
      • 2023-03-13 07228, 2023

      • reosarevok
        !m yvanzo
      • 2023-03-13 07228, 2023

      • BrainzBot
        You're doing good work, yvanzo!
      • 2023-03-13 07208, 2023

      • yvanzo
        Hopefully your DNB PR reminded me about those!
      • 2023-03-13 07249, 2023

      • alastairp
        morning
      • 2023-03-13 07206, 2023

      • monkey checks watch
      • 2023-03-13 07212, 2023

      • monkey
        not here it ain't !
      • 2023-03-13 07219, 2023

      • monkey
        (Hi 👋)
      • 2023-03-13 07238, 2023

      • alastairp
        hi mayhem_, I saw the reply from Lance about requesting a ticket for the exclusion, I'm not sure what your availability is, so I'll wait on this for now
      • 2023-03-13 07258, 2023

      • alastairp
        zas: hi, do you know how to open a ticket with osuosl to request something on the ftp mirror?
      • 2023-03-13 07206, 2023

      • alastairp
        hi monkey!
      • 2023-03-13 07228, 2023

      • zas
        alastairp: I don't know, but Rob may
      • 2023-03-13 07229, 2023

      • alastairp
        zas: ok, thanks. He and I am on an email thread where this was suggested, so I'll wait until he is available to do so
      • 2023-03-13 07204, 2023

      • yvanzo
        alastairp: might it be related to https://github.com/metabrainz/syswiki/pull/17 ?
      • 2023-03-13 07214, 2023

      • yvanzo
        btw lucifer: alastair’s https://github.com/metabrainz/syswiki/pull/77 is waiting for your review
      • 2023-03-13 07241, 2023

      • yvanzo
        btw bitmap: alastair’s https://github.com/metabrainz/syswiki/pull/78 is waiting for your review
      • 2023-03-13 07223, 2023

      • alastairp
        yvanzo: yes, we should add additional information to this PR (specifically, that there are 2 folders that osuosl does not mirror - AB dump and MLHD+ dump) due to their size. I will add this.
      • 2023-03-13 07245, 2023

      • alastairp
        also, s/wiliams/aretha/ :)
      • 2023-03-13 07242, 2023

      • BrainzGit
        [musicbrainz-server] 14reosarevok merged pull request #2895 (03master…MBS-12994): MBS-12994: Treat email as case-insensitive for admin email search https://github.com/metabrainz/musicbrainz-server/…
      • 2023-03-13 07232, 2023

      • yvanzo
        zas: What is the status of MBH-581 and its pull request? I could test it on Wednesday if available by then.
      • 2023-03-13 07233, 2023

      • BrainzBot
        MBH-581: Change Docker daemon setup to use "systemd" cgroup driver https://tickets.metabrainz.org/browse/MBH-581
      • 2023-03-13 07259, 2023

      • BrainzGit
        [bookbrainz-site] 14MonkeyDo merged pull request #936 (03master…middleasync): BB-673: Rewrite middleware file using async/await syntax https://github.com/metabrainz/bookbrainz-site/pul…
      • 2023-03-13 07254, 2023

      • Leftmost has quit
      • 2023-03-13 07210, 2023

      • Leftmost joined the channel
      • 2023-03-13 07219, 2023

      • reosarevok
        yvanzo: is there anything else you'd want me to review or you'd want to review today? I am expecting we'll want to update beta today or tomorrow to go back to the usual schedule :)
      • 2023-03-13 07239, 2023

      • yvanzo
        reosarevok: I was looking into the Flow types again.
      • 2023-03-13 07246, 2023

      • reosarevok
        Ok :)
      • 2023-03-13 07206, 2023

      • reosarevok
        If you think the changes in that branch look good, we could merge those for now and keep improving it in a second one. I guess there's no PR even yet though?
      • 2023-03-13 07227, 2023

      • yvanzo
        No, I’m looking into it.
      • 2023-03-13 07233, 2023

      • yvanzo
        But beta can be updated asap.
      • 2023-03-13 07244, 2023

      • yvanzo
        Will make a draft PR for it, at leas to gather discussions which are on isolated commits at the moment.
      • 2023-03-13 07211, 2023

      • BrainzGit
        [bookbrainz-site] 14the-good-boy opened pull request #957 (03master…editionTableAuthorNames): BB-709: Add “Author” column in publisher editions listing https://github.com/metabrainz/bookbrainz-site/pul…
      • 2023-03-13 07248, 2023

      • BrainzGit
        [musicbrainz-server] 14yvanzo opened pull request #2896 (03master…refine-most-js-types): MBS-12552 (pre): Refine most Flow.js types https://github.com/metabrainz/musicbrainz-server/…
      • 2023-03-13 07242, 2023

      • bitmap
        reosarevok: yes, I already have an idea for how to improve it
      • 2023-03-13 07244, 2023

      • reosarevok
        Any chance we can implement it soon? :D
      • 2023-03-13 07209, 2023

      • ShivamAwasthi joined the channel
      • 2023-03-13 07218, 2023

      • jasje joined the channel
      • 2023-03-13 07240, 2023

      • jasje
        akshaaatt: huh these console projects are aa real mess. I was also setting up spotify console and made a project, but contrary to console problems, i actually can find my keystore password for debug build to retrieve SHA1 fingerprint :(
      • 2023-03-13 07205, 2023

      • jasje
        actually can't find**
      • 2023-03-13 07226, 2023

      • reosarevok
        yvanzo: oh, I didn't realize that commenting on commits kinda gets hidden in the ether. Thanks for putting that up properly
      • 2023-03-13 07256, 2023

      • reosarevok
        bitmap: do you know if it's possible to add something to sentry that would let us know *what* the cross-frame thing is in stuff like https://sentry.metabrainz.org/organizations/metab… ?
      • 2023-03-13 07215, 2023

      • aadil25 joined the channel
      • 2023-03-13 07216, 2023

      • jasje has quit
      • 2023-03-13 07239, 2023

      • yvanzo
        This is due to the multiple rebasing of this branch.
      • 2023-03-13 07254, 2023

      • aadil2522 joined the channel
      • 2023-03-13 07255, 2023

      • reosarevok
        Oh, that makes sense :)
      • 2023-03-13 07212, 2023

      • aadil2522 has quit
      • 2023-03-13 07217, 2023

      • aadil25 has quit
      • 2023-03-13 07257, 2023

      • akshaaatt
        You don’t need keystore and a debug build to get the sha1 cert jasje
      • 2023-03-13 07221, 2023

      • akshaaatt
        Just generate the signing report
      • 2023-03-13 07219, 2023

      • jasje joined the channel
      • 2023-03-13 07219, 2023

      • jasje
        akshaaatt: huh looks like spotify docs were deceptive
      • 2023-03-13 07206, 2023

      • akshaaatt
        Tbh most of the docs I’ve been reading for the past 3-4 years anywhere have been outdated lmfao
      • 2023-03-13 07233, 2023

      • akshaaatt
        Better to have the habit of getting your hands dirty with things
      • 2023-03-13 07236, 2023

      • jasje
        got it: Don't trust docs
      • 2023-03-13 07221, 2023

      • akshaaatt
        XD
      • 2023-03-13 07232, 2023

      • jasje
        huh build failed while updating main
      • 2023-03-13 07257, 2023

      • jasje
        resValue("string", "youtubeApiKey", localProperties['youtubeApiKey']) causing probs
      • 2023-03-13 07256, 2023

      • jasje
        how do i mock these local properties
      • 2023-03-13 07246, 2023

      • ShivamAwasthi has quit
      • 2023-03-13 07249, 2023

      • BrainzGit
        [musicbrainz-server] 14reosarevok merged pull request #2879 (03master…MBS-12955): MBS-12955: Display beginner flag in vote tally https://github.com/metabrainz/musicbrainz-server/…
      • 2023-03-13 07257, 2023

      • zas
        yvanzo: I did a test on moroder, changing the docker options isn't enough, a parameter needs to be passed to kernel command line (via grub) and the system rebooted. I'm about to test that (still on moroder). Immninent reboot (and let's pray it doesn't break the system).
      • 2023-03-13 07239, 2023

      • yvanzo
        Thanks :)
      • 2023-03-13 07203, 2023

      • ShivamAwasthi joined the channel
      • 2023-03-13 07200, 2023

      • zas
        yvanzo: see my last comment on https://tickets.metabrainz.org/browse/MBH-581
      • 2023-03-13 07201, 2023

      • BrainzBot
        MBH-581: Change Docker daemon setup to use "systemd" cgroup driver
      • 2023-03-13 07213, 2023

      • zas
        atj: we need to add a specific grub config for this (via /etc/default)
      • 2023-03-13 07234, 2023

      • zas
        not sure what is the cleanest way to do that using Ansible
      • 2023-03-13 07215, 2023

      • zas
        since it will require a reboot in all cases, what are the machines we need to target?
      • 2023-03-13 07238, 2023

      • atj
        probably just a standalone task
      • 2023-03-13 07202, 2023

      • atj
        didn't know about grub.d, I've always edited /etc/default/grub
      • 2023-03-13 07218, 2023

      • yvanzo
        I intended to use it with services on trille
      • 2023-03-13 07248, 2023

      • yvanzo
        (for a beginning)
      • 2023-03-13 07217, 2023

      • reosarevok
      • 2023-03-13 07257, 2023

      • zas
        atj: grub.d has already an override by hetzner (see /etc/default/grub.d/hetzner.cfg, files are read in alphanumeric order so I created a metabrainz.cfg)
      • 2023-03-13 07248, 2023

      • atj
        so if I set GRUB_CMDLINE_LINUX in /etc/default/grub.d/99-foo, it overrides every other file?
      • 2023-03-13 07228, 2023

      • zas
        it should, but all files have to follow the same notation... which isn't the case atm
      • 2023-03-13 07237, 2023

      • atj
        you need to run update-grub afterwards right?
      • 2023-03-13 07246, 2023

      • zas
        so I think we should ensure that with ansible, copying contents of hetzner.cfg to 50_hetzner.cfg for example
      • 2023-03-13 07253, 2023

      • BrainzGit
        [listenbrainz-server] 14MonkeyDo opened pull request #2398 (03master…goodbye-simple-modal): Replace SimpleModal with ListenPayloadModal https://github.com/metabrainz/listenbrainz-server…
      • 2023-03-13 07222, 2023

      • zas
        yes, update-grub has to run
      • 2023-03-13 07257, 2023

      • zas
        to test, you can run grub-mkconfig (update-grub is a wrapper running grub-mkconfig -o /boot/grub/grub.cfg)
      • 2023-03-13 07216, 2023

      • zas
        it will output generated text to stdout
      • 2023-03-13 07228, 2023

      • zas
      • 2023-03-13 07240, 2023

      • atj
        ok, so 2 tasks and a handler
      • 2023-03-13 07251, 2023

      • atj
        i can create a pr quickly if you want
      • 2023-03-13 07253, 2023

      • zas
        this is what we have for now on moroder (last file is the one I created)
      • 2023-03-13 07209, 2023

      • zas
        atj: it would be great
      • 2023-03-13 07210, 2023

      • atj
        can this just go in bootstrap?
      • 2023-03-13 07216, 2023

      • jasje
        akshaaatt: i've made some progress, no auth flow error but it says use one of the connect buttons
      • 2023-03-13 07226, 2023

      • zas
        I guess so
      • 2023-03-13 07227, 2023

      • jasje
        added my client id to local props
      • 2023-03-13 07236, 2023

      • jasje
        redirect url copied from code
      • 2023-03-13 07207, 2023

      • jasje
        sha1 entered and package name is org.listenbrainz.android.debug
      • 2023-03-13 07219, 2023

      • jasje
        am i missing something?
      • 2023-03-13 07220, 2023

      • jasje has quit
      • 2023-03-13 07250, 2023

      • atj
        did jasje's head just explode?
      • 2023-03-13 07259, 2023

      • atj
        akshaaatt: what did you do?!
      • 2023-03-13 07222, 2023

      • akshaaatt smirks after creating massive destruction
      • 2023-03-13 07200, 2023

      • akshaaatt
        atj: I let him exist as is
      • 2023-03-13 07230, 2023

      • atj
        akshaaatt: ok, i'm worried now ;)
      • 2023-03-13 07231, 2023

      • reosarevok
        bitmap: also, I guess when generating the dumps, something like
      • 2023-03-13 07239, 2023

      • reosarevok
      • 2023-03-13 07247, 2023

      • reosarevok
        And
      • 2023-03-13 07248, 2023

      • reosarevok
      • 2023-03-13 07252, 2023

      • reosarevok
        Should be enough
      • 2023-03-13 07204, 2023

      • akshaaatt
        Hi jasje, so just head to your local.properties file and append youtubeApiKey=test and spotifyClientId=<your_id>
      • 2023-03-13 07227, 2023

      • akshaaatt
        Then do gradle sync and you should be good to build the project
      • 2023-03-13 07207, 2023

      • santiagofn has quit
      • 2023-03-13 07239, 2023

      • jasje joined the channel
      • 2023-03-13 07248, 2023

      • jasje
        akshaaatt: already did that
      • 2023-03-13 07252, 2023

      • bitmap
        reosarevok: the wiki and the linked code look correct, I think
      • 2023-03-13 07256, 2023

      • jasje
        atj: plain yes
      • 2023-03-13 07203, 2023

      • santiagofn joined the channel
      • 2023-03-13 07211, 2023

      • atj
        :)
      • 2023-03-13 07229, 2023

      • jasje
        looks like i need to devolve to docs
      • 2023-03-13 07238, 2023

      • akshaaatt
        Can you show me/send me the errors you are facing?