#metabrainz

zas: now logged into the server, and sudo it, thanks!

voilà, you have as much info we have now ;)

[musicbrainz-server] 14meziyum opened pull request #2892 (03master…documentation): Update Readme file with MusicBrainz project info https://github.com/metabrainz/musicbrainz-serve...

jasje I have confirmed that that was pretty much it. Also, I have set a limit to the number of listens we request while fetching

hi lucifer, you have a 300gb ~ in wolf, any chance you could clear up a bit?

akshaaatt: noice i just saw what was the problem

prolly use remember for the incoming list too

we can take the list directly from the viewmodel

That shouldn't be a problem

Also jasje, I did a cleanup as well in the PR. You can have a look at how we can break things into small pieces to keep the code clen

clean*

For every UI screen, we should have a preview as well

I didn't find enough resources on how to play well with views that require a viewmodel

akshaaatt: i do agree on both

docs suggest that we should use mockrepos for it

But again, now we have the mocks in the sharedrepo and importing from there was causing some issue

akshaaatt: just add implementation(sharedTest) in dependencies

but that's not allowed

the sharedTest repo itself depends on our app

this isn't inception lol

xD

We might have to bring the mocks back to the app for this

akshaaatt: we'll have to duplicate everything then

for the three of em

or just duplicate roots connected method

alastairp: removed most of it.

<3

Let's see about it jasje after some research on best practices

akshaaatt: alright

[listenbrainz-android] 14akshaaatt merged pull request #77 (03main…fix-app-nav-jasje): Converted activities to Composables https://github.com/metabrainz/listenbrainz-andr...

I am a bit confused with what to do with the PR https://github.com/metabrainz/listenbrainz-andr...

jasje should we omit it? It doesn't seem to help much

alastairp: That's 0.59s per file on avg! :D

he isn't doing any work i poked him alot

!m alastairp

You're doing good work, alastairp!

akshaaatt: ill just convert profile screen myself

Let's avoid logging in from the profile screen

I will handle that in the onboarding now

Pratha-Fish: do you know something else? Given the original 27 _billion_ rows, there are less than 2m unique canonical MBIDs. So I'll show you some more amazing optimisations if we run this again

The user has to be signed in

yvanzo: I think we should deploy mediawiki official docker image (https://hub.docker.com/_/mediawiki) on mingus, I installed automysqlbackup on wiki server, so we have db backups in /var/lib/automysqlbackup/

I think we can probably process the entire thing in half a day

we can follow https://www.mediawiki.org/wiki/Manual:Moving_a_...

alastairp: half a day? 💀

akshaaatt: that could work too

Is the design final from aerozol for the profile page?

only 2 million canonical MBIDs sounds a little sus though don't you think?

Pratha-Fish: 20 years of learning and half a day of computation

akshaaatt: i guess he hasn't taken up the initiative yet

nah, I don't think so

ill have to poke him a bit

Sheeesh

Let's get on his nerves then :)

monkey: mayhem: hi! Lunch next week? I have some things to contar, maybe I'll come and work in the office one day?

(nothing bad! just catching up)

https://github.com/metabrainz/listenbrainz-andr... jasje conflicts :)

akshaaatt: thak gya hu conflicts se

alastairp: BTW when's the final dataset gonna be ready? I could help with some docs / publishing stuff if you need any help

zas: Opened a PR to document as it is for now.

Pratha-Fish: today? maybe?? or early next week

yvanzo: ok, thanks

Noice

akshaaatt: you moved song view pager

XD yus

I'll do a migration attempt next week

akshaaatt: i made alot of changes to that

akshaaatt: can you handle that :P

Just cut and paste it to the new destination then

I only updated the location, not the logic

alastairp: Let me know if there's any help you need with the publishing. I couldn't do much in terms of the final script due to some complications, but I can try and help with some basic stuff done as required ^_^

akshaaatt: okeys

Yes jasje, you can submit your proposal early on the community forum for gsoc :)

akshaaatt: oh yeah i forgor

alrighty, then here goes nothin

akshaaatt: posted

Awesome work jasje! 💯

Let me get back to you on this by next week

akshaaatt: Thanks!!

Pratha-Fish: right, let's see once the archives are created. Regarding the script, in the end we just decided to run what we had (so there is some missing data that we know we can improve). If there's interest from people to have that updated data then maybe we'll do that

Alrightyy

Also, I might get hella busy for the next 2 weeks. Have traumatic deadlines coming up

alastairp: sounds good :)

:((

doesn't matter ill keep pinging you anyways haha

akshaaatt: conflicts resolved

akshaaatt: btw did you see the changes i made?

Which changes jasje?

merge this one and see magic

real changes

you might have noticed the ui changes i guess

Yus yus

look noice me proud

removed the top bars elevation

so it blends

Kewl

bottom nav bar and view pager have same color

bold text here and there

and in the bp fix pr

performance improvements and more (checkout the commits)

[bookbrainz-site] 14MohamedAli00949 closed pull request #952 (03master…bb-718): fix(BB-718): CritiqueBrainz auth endpoint is called server-side https://github.com/metabrainz/bookbrainz-site/p...

not urgent at all

ok, then will need to be in april. I'm finally going traveling again. Its been far too long.

oh, I have an idea.

Adrian, one of the last.fm'ers who is part of our master class series (upcoming) will be in BCN the week of the 20th and some bits later than that.

the 24th he plans to work in the metabrainz office. I think you should meet him. Could we have informal drinks at the office late afternoon on the 24th?

perfect, I'm putting it in my calendar

I'll be a bit jet lagged, but whevs.

cool.

bon viatge!

monkey: Hey!!

moltes gracies.

akshaaatt: should i reply to this: https://github.com/metabrainz/listenbrainz-andr... ?

with this:

Hello! Thanks for taking our app into consideration. Please consider opening an issue at [LB Android Issue Board](https://tickets.metabrainz.org/secure/RapidBoard.jspa?rapidView=10&projectKey=MOBILE). This helps us keep track of all the issues, hence solving problems faced by our users.

monkey: I have some questions on LB#2393

Fix user name search in PersonalRecommendationModal: https://github.com/metabrainz/listenbrainz-serv...

alastairp: Lunch with extreme pleasure ! :) We can do a cantine like the old days of a few months ago :p

alastairp: lucifer : how are integration tests run these days? the "int" option has gone from test.sh.

(and thus our docs are not up to date)

I believe both integration and unit tests happen at the same time with just test.sh (as we significantly sped up the process)

ah.

in which case, docs should be updated to remove that

aerozol: Thanks, mockups for the mobile version of the menus and navs look great ! That gives me all I need to start implementing that bit I think

kellnerd: Thanks for the PR! I made that change locally yesterday too but didn't test thoroughly to PR.

monkey: let me know what days this coming week you will be in the office, then!

Probably most days actually.

I think I did every day this week

Hehe, I needed a test DB for my ORM replacement experiments, so I had the same problem to solve yesterday :)

monkey: Take a look at it when you get time :)

kellnerd: Just pushed to that PR to fix the test suite. I'll wait for tests to pass then merge and respond on the forum

Thanks for th help in confirming the issue and solution :)

jivte: Looks pretty good ! Less heavy without the repeating cover art.I think the track number is a little bit too prominent. They could be a tiny bit smaller font size and grey in color like the buttons to the right. In the codebase you can achieve that with the `<small>` html tag with a class of `text-muted`: https://usercontent.irccloud-cdn.com/file/NN6Bl...

I also think the rounded corners on the album header are a bit too much (too big). I'd recommend copying what we use on other elements (cards, listencard, etc.)

Oh, and it could be useful to try it with a much longer album name, I foresee some potential space issues…

I tried it no issues came to me

Try it with this maybe? :p https://musicbrainz.org/release-group/1aba497f-...

monkey: there were some space issues and i tried to resolve them

[musicbrainz-server] 14reosarevok merged pull request #2889 (03master…MBS-12983): MBS-12983: Update to DateTime::Locale 1.37 https://github.com/metabrainz/musicbrainz-serve...

monkey: Sorry I missed some details this is the updated one