yvanzo, monkey: As I was refreshing my memory why companies prefer using Objection.js (https://github.com/Vincit/objection.js/issues/1069 which also convinced me to select it instead of other TypeScript ORMs or query builders in 2021), I've found out some sad news:
Hmm, I already had a look at those (and others), and they're much heavier ORM frameworks whereas Objection is more like an enhanced query builder with support for lazy loading.
2023-03-16 07523, 2023
iconoclasthero
and since the boot i downloaded said it was an EC boot, i started there. then i looked at the cover and it's actually a BB boot.
2023-03-16 07534, 2023
iconoclasthero
so I went to BB and switched the view to Alll release groups
kellnerd: I see. Yes, that would be ideal, especially in view of our ORM issues
2023-03-16 07559, 2023
kellnerd
Yeah, personally I'm not really a fan of these full blown ORMs and originally intended to go just with Knex (for my personal project) before I discovered Objection back then.
2023-03-16 07509, 2023
BrainzGit
[listenbrainz-server] 14MonkeyDo merged pull request #2396 (03master…dependabot/npm_and_yarn/braintree/sanitize-url-6.0.1): Bump @braintree/sanitize-url from 6.0.0 to 6.0.1 https://github.com/metabrainz/listenbrainz-server…
2023-03-16 07545, 2023
reosarevok
bitmap, yvanzo: so, meeting or no meeting? :D
2023-03-16 07536, 2023
bitmap
what's on the agenda, entity naming?
2023-03-16 07522, 2023
yvanzo
yep
2023-03-16 07549, 2023
bitmap
I suppose I should address the comments in the Flow PR and we can merge that
2023-03-16 07505, 2023
bitmap
then continue looking at other CoreEntityT uses?
2023-03-16 07533, 2023
kellnerd
monkey: But I don't know whether that makes sense for BB. The ideal outcome would be that Objection continues to be maintained, IMO. Maybe there's still hope, according to https://www.npmjs.com/package/objection kibertoad has accepted the NPM invitation at least.
MBS-8186: Extend release group filtering to all sets of RGs, not just official by this artist
2023-03-16 07533, 2023
iconoclasthero
okie dokie
2023-03-16 07538, 2023
iconoclasthero
thanks
2023-03-16 07501, 2023
yvanzo
added you to followers
2023-03-16 07506, 2023
iconoclasthero
thanks
2023-03-16 07553, 2023
bitmap
reosarevok: yvanzo: should we try to resolve the discussion in that PR today? :)
2023-03-16 07526, 2023
yvanzo
yes
2023-03-16 07528, 2023
yvanzo
added a list of new types to the PR's description
2023-03-16 07538, 2023
yvanzo
bitmap: I thought that we would refine types depending on components’ needs (that is specifying need properties, what I tried to do with MergeLink) rather than hard-coding a list of entity types (as in MergeableEntityT/MergeableEntityTypeT).
2023-03-16 07518, 2023
bitmap
in that case I think it made the types a lot more complicated, because we needed the component to accept a type parameter IIRC
2023-03-16 07501, 2023
bitmap
I agree we don't need a list-of-types type in all cases
2023-03-16 07517, 2023
bitmap
the list-of-types is mainly useful if you need to refine the type to a more specific one using the entityType property, so that you can access other entity-specific properties.
2023-03-16 07519, 2023
iconoclasthero
TBH, if there was an option to filter by unofficial release groups, that would make my entries of bootlegs easier
that should be since it's an oakland show around NYE
2023-03-16 07546, 2023
iconoclasthero
though prehaps not the etree 84986 version
2023-03-16 07509, 2023
iconoclasthero
Since until recently etree wasn't an option for label number
2023-03-16 07528, 2023
iconoclasthero
there's also no good place for torrent hashes or names
2023-03-16 07547, 2023
iconoclasthero
i usually put them in the disambiguation
2023-03-16 07550, 2023
bitmap
reosarevok: yvanzo: not sure what to do about the CoreEntityT usage in e.g. EntityHeader. since that uses EntityLink, it will have to be a union type. so, we could use RelatableEntityT, but it's not clear that EntityHeader is only for relatable entities.
2023-03-16 07511, 2023
reosarevok
Well, we should probably use it for whatever we expect to use it
2023-03-16 07523, 2023
reosarevok
So if it's only Relatable right now, use that, if not, make a union type?
2023-03-16 07557, 2023
jasje_ joined the channel
2023-03-16 07504, 2023
jasje_ has quit
2023-03-16 07543, 2023
bitmap
sure. RelatableEntityT works fine, so I may be overthinking it
you will still have to ctrl+f, but if it exists it should be on the first page
2023-03-16 07542, 2023
yvanzo
bitmap: Would it be possible to generate TaggableEntityT type declaration from entities.mjs?
2023-03-16 07524, 2023
iconoclasthero
is there any way that the entry box for annotations could be expanded rightward?
2023-03-16 07541, 2023
yvanzo
We have had issues with mismatch between entities.json and Perl code, we don’t want to have it again in JS code.
2023-03-16 07522, 2023
bitmap
it's technically possible, but no code exists to generate types like that yet
2023-03-16 07536, 2023
yvanzo
iconoclasthero: It is possible in the annotation editing form that can be accessed from “Edit annotation” link below the annotation display.
2023-03-16 07535, 2023
bitmap
but, if you tried to use SidebarTags or TagEditor etc. from an entity page that isn't in TaggableEntityT, it will error. so they shouldn't really silently become out of sync
2023-03-16 07540, 2023
iconoclasthero
yvanzo is that only after the entry's been submitted the first time?
2023-03-16 07555, 2023
yvanzo
iconoclasthero: yes
2023-03-16 07503, 2023
iconoclasthero
I don't know what those Tag things are so moot.
2023-03-16 07534, 2023
yvanzo
It's a different topic as we are having our weekly MB dev meeting atm.
2023-03-16 07546, 2023
iconoclasthero
ok, later
2023-03-16 07549, 2023
iconoclasthero has left the channel
2023-03-16 07534, 2023
yvanzo
It still is code duplication.
2023-03-16 07511, 2023
yvanzo
It might be possible to add a type to Taggable*T that is not in entities.json.
