#metabrainz

:D

IIRC bitmap told you to add privs at some point, but maybe I misremember :)

test is awesome

Pratha-Fish: someone did tell you that before

Yes! you did tell me about the privs :)

monkey: if those are ready to merge, i can do a release

Just not how to add "areas" since it's not in the "editing" drop down menu on the site :)

I just realized there was a URL for this page, and not a direct link on the homepage.. Should've asked :smiling_face_with_tear:

It's working now ^_^ https://usercontent.irccloud-cdn.com/file/1Ca2U...

lucifer: One needs rebasing. I might finish that tonight, but it probably won't be ready to merge/deploy until tomorrow

Pratha-Fish: if you have the privs there's a link in the Admin menu :)

But otherwise, yeah, it's hidden

reosarevok: another little doubt. How do I test out the bot? I haven't been able to figure out how to execute it. Pardon my noob-self, but all the scripts that I have been writing and testing so far have a main executable script that can be run to start some function. But I haven't been able to figure out what it is for the musicbrainzbot

ah cool, monkey.

The actual scripts (such as https://github.com/reosarevok/musicbrainz-bot/b...) that you write are runnable

As I said, I've always run them from IDEs, but I assume you can run them from the CLI as well :)

Alrighty, so it looks like https://github.com/metabrainz/musicbrainz-bot/t... is simply a template for a mechanize class that one has to import in a script to submit data

That's quite a different workflow than what I am used to, but I think I get the gist of it

monkey: FYI the GitHub Bot is not able to assign tickets as it has no user mapping. :)

bitmap: do the changes in https://github.com/metabrainz/musicbrainz-serve... make sense now?

If yes, I'll merge and release beta, I guess? :)

reosarevok: looks good now

Can’t find the ticket, just checking before I make one: has anyone reported external links not loading when creating a new artist? I get it a bit and someone else mentioned it on Discord

(started after the relationship editor update)

At random, not always?

[musicbrainz-server] 14reosarevok merged pull request #2880 (03master…MBS-12959): MBS-12959: Only hide My vote in header for non-voting editors https://github.com/metabrainz/musicbrainz-serve...

did you open developer console and check for error messages?

reosarevok: random

atj: not yet

aerozol: have we taught you nothing?!!

IIRC I got it like once, I assumed it was my connection that broke for a moment

atj: haha that’s what I was thinking! Apparently not!

I haven't gotten it repeatedly enough to suspect something is borked

:D

But if others are getting it, then maybe it is

reosarevok: What time do you clock in/out usually? It's getting a little late here in India, but I might be able to stick around for some time to implement some of what I've learned so far and ask a few more queries if you aren't clocking out yet

yeah I was ignoring it too, probably what everyone else is doing it too (“oh it’s just me”)

I try to be away by now, but I'm releasing a beta server update today

So I might be around for a while more

Wow my dev console is a nightmare. Too many scripts! All having errors (but obviously they still work so whatever…)

great!

I'll stick around a little longer too then. (And I'll try not to bother you between the beta server update :))

bitmap: what's with https://github.com/metabrainz/musicbrainz-serve... and is it ready to merge?

> Too many scripts! All having errors

I hope my scripts don't cause these errors, aerozol. Please raise a GH issue if they do :)

kellnerd: ah man, I was just going to keep ignoring them :D no dev console, no problems

:')

Updating Jira apps in 5 min.

atj: Think I caught the error, this look right?

yeah

Cool, ticket incoming

shame it's not very helpful

bitmap might figure something out from there

hah, for some reason i just imagined bitmap staring at reactr backtraces like neo in the matrix

lool

That’s how I imagine all devs anyway

Done with Jira apps update.

bitmap, apparently you can will look at this like neo: MBS-12996

MBS-12996: 'External Links' fails to load when creating new artist https://tickets.metabrainz.org/browse/MBS-12996

weirdly i haven't experienced that issue

hmm, try refreshing add artist heaps and see if it pops up?

Maybe some userscripts are involved that break the page?

kellnerd: I didn’t even check! Amateur hour over here!

(to be fair I do have to get up very early on Tuesdays, for some dumb reason)

Looks like it might be a script

I would place my money on it being one that has to be adapted to new relationship editor still

akshaaatt: meeting ended with /BANG :)

Seems like my irc client missed a few messages

Dang

aerozol: thx, I will commence staring at the floating characters while pressing every key on the keyboard

bitmap: just going through my scripts now, don’t interrupt your hacking yet

you don’t only use one keyboard do you? pssh

resoarevok: Do you have have the Paste-a-date script installed?

Looks like it might be that bitmap… this was bloody annoying to test since it only triggers intermittently. If it’s not that I’ll throw my keyboard out the window

ooh ok, thanks for checking. from the error message it sounds like something is changing the html so a script seems likely

reosarevok: just updated https://github.com/metabrainz/musicbrainz-serve...

and I'll merge https://github.com/metabrainz/musicbrainz-serve... then

[musicbrainz-server] 14mwiencek merged pull request #2745 (03master…fix-ia-delay-empty-response): Fix empty response when hitting a temporary IA delay https://github.com/metabrainz/musicbrainz-serve...

[musicbrainz-server] 14reosarevok merged pull request #2862 (03master…MBS-12902): MBS-12902: Add pagination to admin email/IP search https://github.com/metabrainz/musicbrainz-serve...

aerozol: I do, yes

I really need to get that in-house replacement merged...

Cool, I’ve been testing without for a little bit now and I think that was it. I think it hasn’t been working anyway? re. pasting dates

It might be broken on the new React bits, I forget

bitmap: whee, tests finally pass for https://github.com/metabrainz/musicbrainz-serve... - guess I figured it out

hi aerozol

Shit, External Links just didn’t load again. No error message this time. I wonder if it has to do with this artist having ‘possible duplicates’

Hi ShivamAwasthi

bitmap, yvanzo: waiting for tests on https://github.com/metabrainz/musicbrainz-serve... and I'll release beta

There's a couple of other PRs that would be nice to merge this week, including one regression, so ideally tomorrow or the day after I can put out another :)

reosarevok: yvanzo: btw, we should be putting a blog post out for the schema change on the 15th. if you're working on any tickets, can you make sure they're assigned and in the 2023 Q2 fix version, with sql changes documented tomorrow?

(also maybe the JSON dumps license thing so that Rob can do the datasets thing - oh, I should send an update to the MeB page about the datasets too)

Oh, yeah, sql changes documented. Good point, I know what's my job for tomorrow morning now :D

should we have a meeting this week?

[bookbrainz-site] 14meziyum closed pull request #950 (03master…refactor-components): BB-725: refactor achievement component https://github.com/metabrainz/bookbrainz-site/p...

hey aerozol! so i was able to get a result that looks like this https://pasteboard.co/k53Q42Z5Y3xs.png (You can read the discussion related to this on #bookbrainz chatlogs), but the crux is that I think something which is a little less eye-catching (as in the original mockup #8) would be better. Perhaps something similar to a rotated version of

this icon here (https://fontawesome.com/icons/corner?s=thin&...)

yvanzo: Probably. Tomorrow at the usual time, review the schema change stuff for the blog post + more entity naming?

I'm also ok with later if that's better, anyway, as long as we can make sure the schema change bit is fine :)

what are your thoughts?

[bookbrainz-site] 14meziyum reopened pull request #950 (03master…refactor-components): BB-725: refactor achievement component https://github.com/metabrainz/bookbrainz-site/p...

[bookbrainz-site] 14dependabot[bot] opened pull request #958 (03master…dependabot/npm_and_yarn/sass-1.59.2): chore(deps-dev): bump sass from 1.49.0 to 1.59.2 https://github.com/metabrainz/bookbrainz-site/p...

ShivamAwasthi: Can definitely try it with that. Could also try it with the arrow + tail but made the same size as in your earlier version

reosarevok: yep, Wed or Thu would work better for me.

Ok, I'm ok with either I think. bitmap?

ShivamAwasthi: As it’s much bigger in the newer version. Could combo that with a lighter grey like #808080

Ok, let's do Thu, but make sure we have the tickets assigned for tomorrow

yvanzo: do you want to take any of the tickets in https://tickets.metabrainz.org/projects/MBS/ver... ?

If not, I can probably manage the unassigned ones

Oh, also, yvanzo: you wanted more specifics on https://tickets.metabrainz.org/browse/MBS-12794

MBS-12794: Don't use spammer tags/ratings when calculating tag counts / rating averages

bitmap: re that one, should we worry about spammers with lots of tags / ratings?

Honestly, I could probably just delete those

If need be :p

But maybe there's a way to avoid it being an issue

[bookbrainz-site] 14dependabot[bot] opened pull request #959 (03master…dependabot/npm_and_yarn/mini-css-extract-plugin-2.7.3): chore(deps-dev): bump mini-css-extract-plugin from 2.5.3 to 2.7.3 https://github.com/metabrainz/bookbrainz-site/p...

[bookbrainz-site] 14dependabot[bot] closed pull request #925 (03master…dependabot/npm_and_yarn/mini-css-extract-plugin-2.7.2): chore(deps-dev): bump mini-css-extract-plugin from 2.5.3 to 2.7.2 https://github.com/metabrainz/bookbrainz-site/p...

I tried it with #737373 which is in the ballpark. I think the thinner it is, the better it will be in terms of not drawing attention. The other thing which I like about the original mockup#8 is that having no arrows makes it look like a branched thing(which it is, in a sense), and having arrow makes it seem like a flow-related thing which draws

attention

lets try without arrows, as well as a thinner arrow, and then see which one looks better

reosarevok: well, it will probably be an issue, just like for account deletion, but only for admins in this case. so in extreme cases we can just delete the tags/ratings, I guess

I guess if it timed out, it would just *not* set the user as a spammer at all or?

[bookbrainz-site] 14dependabot[bot] opened pull request #960 (03master…dependabot/npm_and_yarn/jsdom-21.1.1): chore(deps-dev): bump jsdom from 20.0.0 to 21.1.1 https://github.com/metabrainz/bookbrainz-site/p...

[bookbrainz-site] 14dependabot[bot] closed pull request #923 (03master…dependabot/npm_and_yarn/jsdom-21.1.0): chore(deps-dev): bump jsdom from 20.0.0 to 21.1.0 https://github.com/metabrainz/bookbrainz-site/p...

yeah, the whole transaction would be rolled back if it's cancelled

In that case, it seems fine

Ok, the other two tickets *seem* trivial, so I'm self-assigning and I'll check tomorrow exactly the changes needed

bitmap: unless you want to take https://tickets.metabrainz.org/browse/MBS-12370 since it's your suggestion?

MBS-12370: Rename schema change upgrade script suffixes to clearly indicate which nodes they run on

reosarevok: oh man, maybe the culprit is ‘Image Max URL’?? (still testing this flippin thing)

I don't think I have that one

(it's possible the culprits are several scripts FWIW)

Image Max URL is a good one because I think I can reliably recreate it! But it’s not a MB script...

Since we're probably releasing a second beta, I'm going to let https://github.com/metabrainz/musicbrainz-serve... just run the tests and whatnot and release it next time

reosarevok: sure, I'll take that one if nobody else does

I mean, I can, but I'd be asking you to make sure I follow. As you prefer really

what now...

want me to try running it locally? is that on the beta or master branch?

bitmap: I don’t think I can do better than my notes here, if you want to have a look sometime: MBS-12996

MBS-12996: 'External Links' fails to load when creating new artist https://tickets.metabrainz.org/browse/MBS-12996

bitmap: master

That's tx pull -f failing for some reason