I would prefer us to move to HTTP and be done with it.
2023-04-17 10748, 2023
mayhem
yes, exactly.
2023-04-17 10720, 2023
atj
i'm sure zas can provide some reasons why it's not so straightforward
2023-04-17 10749, 2023
mayhem
oh, there is server work to be done?
2023-04-17 10707, 2023
atj
erm, let me check
2023-04-17 10717, 2023
mayhem
if it is just the musicbrainz-docker side of things it shouldn't be more than just changing the protocol we use.
2023-04-17 10743, 2023
atj
yes you're right, http already works
2023-04-17 10708, 2023
atj
OK, that's the simplest fix then
2023-04-17 10731, 2023
atj
zas, yvanzo, reosarevok: what's preventing us switching the Docker scripts to pull dumps via HTTP and announcing FTP access to ftp. is deprecated and will be removed in ~3 months?
2023-04-17 10729, 2023
mayhem
it would be great if we could get a PR for this fix up today and then merge it in 3 months if we need to the time.
2023-04-17 10731, 2023
yvanzo
atj: If by Docker scripts you mean musicbrainz-docker, I can look into it.
2023-04-17 10738, 2023
mayhem
yvanzo: yes.
2023-04-17 10747, 2023
yvanzo
We need at least to let the schema change go.
2023-04-17 10749, 2023
mayhem
yvanzo: let me forward you the email from atj
2023-04-17 10703, 2023
mayhem
meaning we should do it after?
2023-04-17 10727, 2023
yvanzo
yes, 3 months if 2 months after the schema change, so it's fine.
2023-04-17 10736, 2023
mayhem
ah, got it.
2023-04-17 10754, 2023
mayhem
this should be a pretty simple fix, right?
2023-04-17 10709, 2023
yvanzo
Our Docker Compose project supports FTP only atm, but it should be simple to handle HTTP/S too.
Unless some of our backends need FTP (in which case zas or bitmap would know), I don’t think there is any reason not to drop it.
2023-04-17 10719, 2023
zas
atj: support for HTTP was a quick hack over FTP (which is here for historical reasons). I see no problem in deprecating FTP, though serving via HTTPS might need some improvements (fancier index pages, ensuring everything is properly configured to serve big files, and better/simpler cert management, etc...)
2023-04-17 10743, 2023
atj
Well if the status quo is FTP I see no issue with HTTP. HTTPS could be added later.
2023-04-17 10726, 2023
yvanzo
atj: Is the PASV issue a FTP server configuration issue or client missing flags?
2023-04-17 10744, 2023
yvanzo
(or both)
2023-04-17 10723, 2023
atj
yvanzo: it's a client and a server issue but not something that can be easily resolved
2023-04-17 10719, 2023
atj
The client host is using IPv4 in IPv6 addressing which is something to do with the clients host network configuration
2023-04-17 10745, 2023
yvanzo
Ok, that’s really easier to move to HTTP/S then.
2023-04-17 10757, 2023
atj
you end up in a bizarre situation where wget is making a IPv4 request but think it is making an IPv6 request
2023-04-17 10705, 2023
atj
*thinks
2023-04-17 10736, 2023
atj
and because FTP is so archaic, they had to add additional commands to the FTP protocol to support IPv6
2023-04-17 10758, 2023
yvanzo
atj: Are you working on a patch to musicbrainz-docker already?
2023-04-17 10718, 2023
atj
yvanzo: yes, give me 20 mins
2023-04-17 10735, 2023
yvanzo
Ok, just let me know if you need any help with it.
I love how people think that getting a reply within one day is "quick"
2023-04-17 10709, 2023
atj
shows how poor customer support is in general
2023-04-17 10752, 2023
mayhem
atj: amen to that. but we did have a few exchanges before where our side was fast to respond.
2023-04-17 10719, 2023
atj
I saw your previous response was "lightning" fast :)
2023-04-17 10743, 2023
mayhem
atj: I'm dumping all the tax info to our accountants, and I had to admit to our accountants that I failed to pay you last year. And a boozer at my house is not easy to account for, lol. ;)
2023-04-17 10709, 2023
mayhem
heh, yeah. I guess everything is different when the people are engaged and proud of their worl.
2023-04-17 10712, 2023
mayhem
work,
2023-04-17 10709, 2023
atj
i encounter the same type of response a lot at work, especially when they ring and a real person without a script answers the phone
2023-04-17 10730, 2023
mayhem nods
2023-04-17 10716, 2023
atj
yvanzo: i've updated the PR
2023-04-17 10706, 2023
atj
added a "--base-http-url" argument with a default value, the "--base-ftp-url" argument no longer has a default but if specified has precedence over HTTP
2023-04-17 10714, 2023
yvanzo
OK, looking into it
2023-04-17 10728, 2023
yvanzo
zas: forwarded you a mail about picard
2023-04-17 10733, 2023
atj
hopefully it matches your thinking
2023-04-17 10733, 2023
mayhem
taxes submitted. (I love having accountants do the actual work)
2023-04-17 10709, 2023
yvanzo
atj: It looks neat. Did you test it somehow?
2023-04-17 10711, 2023
atj
yvanzo: yes, let me add a comment to the PR
2023-04-17 10740, 2023
atj
hah, I just did another test and it broke :)
2023-04-17 10755, 2023
atj
forgot to update createdb.sh
2023-04-17 10709, 2023
yvanzo
made a few comments
2023-04-17 10712, 2023
monkey
Looks good for my stats lucifer
2023-04-17 10716, 2023
monkey
Nice work :)
2023-04-17 10705, 2023
monkey
The real proof will be with user ulkigpulkig and their all_time stats with the two beatles white albums
2023-04-17 10725, 2023
atj
yvanzo: thanks, maybe we should just add a new --mirror-url option, which can support whatever wget allows, with no heuristics for automatically adding a protocol, and let base-ftp-url override it for backwards compatibility?
that way we don't tie ourselves into HTTP, and can switch the default to HTTPS later without having to add /another/ argument
2023-04-17 10759, 2023
yvanzo
atj: If adding HTTP option is simpler for now, I’m fine with adding it, releasing it today, and replacing it later on with something more robust.
2023-04-17 10741, 2023
atj
i think adding a general option is actually easier
2023-04-17 10700, 2023
yvanzo
I just added a ticket to track the improvement.
2023-04-17 10744, 2023
yvanzo
👍
2023-04-17 10745, 2023
Zhele has quit
2023-04-17 10718, 2023
BrainzGit
[listenbrainz-server] 14MonkeyDo merged pull request #2436 (03master…faraz16iqbal_feature_save-data-header): LB-1011: Don't load album covers if Save-Data HTTP header is on https://github.com/metabrainz/listenbrainz-server…
2023-04-17 10733, 2023
yvanzo
atj (apparently this message didn’t go through): We can do that too. These heuristics have been added because many people used to copy/paste URL without scheme.
2023-04-17 10749, 2023
yvanzo
But there are better ways to handle such oversight.
2023-04-17 10726, 2023
reosarevok
yvanzo: is the blog ready to review? :)
2023-04-17 10733, 2023
yvanzo
reosarevok: yes :)
2023-04-17 10736, 2023
reosarevok
Ok!
2023-04-17 10704, 2023
reosarevok
(also, fwiw, at least with opera for some reason if you edit a URL to remove or change something, then copy it, it will copy it without scheme)
2023-04-17 10708, 2023
reosarevok
(no idea why)
2023-04-17 10747, 2023
yvanzo
We might have a patch for musicbrainz-docker, so release is pending that too.
2023-04-17 10755, 2023
yvanzo
(release blog post)
2023-04-17 10703, 2023
reosarevok
Ok :)
2023-04-17 10730, 2023
reosarevok
But that won't affect the post text, right? Just the link and whatnot
2023-04-17 10746, 2023
yvanzo
right
2023-04-17 10716, 2023
reosarevok
We usually remove "Other" from "other task" if there's no React tasks, right?
2023-04-17 10709, 2023
reosarevok
Made a couple small changes, but it seems good, thanks
2023-04-17 10755, 2023
reosarevok
Is it fine to merge approved stuff to master already then? :)
2023-04-17 10705, 2023
reosarevok
Or do you want to finish the docker + post process?
2023-04-17 10723, 2023
yvanzo
reosarevok: I updated master with production, it is fine to merge stuff :)
2023-04-17 10709, 2023
reosarevok
Thanks
2023-04-17 10733, 2023
reosarevok
mayhem: I can take today :)
2023-04-17 10735, 2023
BrainzGit
[musicbrainz-server] 14reosarevok merged pull request #2754 (03master…MBS-12712): MBS-12712: Improve wording for new release adding on disc ID lookup https://github.com/metabrainz/musicbrainz-server/…
2023-04-17 10748, 2023
BrainzGit
[musicbrainz-server] 14reosarevok merged pull request #2761 (03master…MBS-12738): MBS-12738 / MBS-12739: Don't assume "single" and "studio" are ETI unless inside parens https://github.com/metabrainz/musicbrainz-server/…
