I would prefer us to move to HTTP and be done with it.
yes, exactly.
atj
i'm sure zas can provide some reasons why it's not so straightforward
mayhem
oh, there is server work to be done?
atj
erm, let me check
mayhem
if it is just the musicbrainz-docker side of things it shouldn't be more than just changing the protocol we use.
atj
yes you're right, http already works
OK, that's the simplest fix then
zas, yvanzo, reosarevok: what's preventing us switching the Docker scripts to pull dumps via HTTP and announcing FTP access to ftp. is deprecated and will be removed in ~3 months?
mayhem
it would be great if we could get a PR for this fix up today and then merge it in 3 months if we need to the time.
yvanzo
atj: If by Docker scripts you mean musicbrainz-docker, I can look into it.
mayhem
yvanzo: yes.
yvanzo
We need at least to let the schema change go.
mayhem
yvanzo: let me forward you the email from atj
meaning we should do it after?
yvanzo
yes, 3 months if 2 months after the schema change, so it's fine.
mayhem
ah, got it.
this should be a pretty simple fix, right?
yvanzo
Our Docker Compose project supports FTP only atm, but it should be simple to handle HTTP/S too.
Unless some of our backends need FTP (in which case zas or bitmap would know), I don’t think there is any reason not to drop it.
zas
atj: support for HTTP was a quick hack over FTP (which is here for historical reasons). I see no problem in deprecating FTP, though serving via HTTPS might need some improvements (fancier index pages, ensuring everything is properly configured to serve big files, and better/simpler cert management, etc...)
atj
Well if the status quo is FTP I see no issue with HTTP. HTTPS could be added later.
yvanzo
atj: Is the PASV issue a FTP server configuration issue or client missing flags?
(or both)
atj
yvanzo: it's a client and a server issue but not something that can be easily resolved
The client host is using IPv4 in IPv6 addressing which is something to do with the clients host network configuration
yvanzo
Ok, that’s really easier to move to HTTP/S then.
atj
you end up in a bizarre situation where wget is making a IPv4 request but think it is making an IPv6 request
*thinks
and because FTP is so archaic, they had to add additional commands to the FTP protocol to support IPv6
yvanzo
atj: Are you working on a patch to musicbrainz-docker already?
atj
yvanzo: yes, give me 20 mins
yvanzo
Ok, just let me know if you need any help with it.
I love how people think that getting a reply within one day is "quick"
shows how poor customer support is in general
mayhem
atj: amen to that. but we did have a few exchanges before where our side was fast to respond.
atj
I saw your previous response was "lightning" fast :)
mayhem
atj: I'm dumping all the tax info to our accountants, and I had to admit to our accountants that I failed to pay you last year. And a boozer at my house is not easy to account for, lol. ;)
heh, yeah. I guess everything is different when the people are engaged and proud of their worl.
work,
atj
i encounter the same type of response a lot at work, especially when they ring and a real person without a script answers the phone
mayhem nods
yvanzo: i've updated the PR
added a "--base-http-url" argument with a default value, the "--base-ftp-url" argument no longer has a default but if specified has precedence over HTTP
yvanzo
OK, looking into it
zas: forwarded you a mail about picard
atj
hopefully it matches your thinking
mayhem
taxes submitted. (I love having accountants do the actual work)
yvanzo
atj: It looks neat. Did you test it somehow?
atj
yvanzo: yes, let me add a comment to the PR
hah, I just did another test and it broke :)
forgot to update createdb.sh
yvanzo
made a few comments
monkey
Looks good for my stats lucifer
Nice work :)
The real proof will be with user ulkigpulkig and their all_time stats with the two beatles white albums
atj
yvanzo: thanks, maybe we should just add a new --mirror-url option, which can support whatever wget allows, with no heuristics for automatically adding a protocol, and let base-ftp-url override it for backwards compatibility?
that way we don't tie ourselves into HTTP, and can switch the default to HTTPS later without having to add /another/ argument
yvanzo
atj: If adding HTTP option is simpler for now, I’m fine with adding it, releasing it today, and replacing it later on with something more robust.
atj
i think adding a general option is actually easier
yvanzo
I just added a ticket to track the improvement.
👍
Zhele has quit
BrainzGit
[listenbrainz-server] 14MonkeyDo merged pull request #2436 (03master…faraz16iqbal_feature_save-data-header): LB-1011: Don't load album covers if Save-Data HTTP header is on https://github.com/metabrainz/listenbrainz-serv...
yvanzo
atj (apparently this message didn’t go through): We can do that too. These heuristics have been added because many people used to copy/paste URL without scheme.
But there are better ways to handle such oversight.
reosarevok
yvanzo: is the blog ready to review? :)
yvanzo
reosarevok: yes :)
reosarevok
Ok!
(also, fwiw, at least with opera for some reason if you edit a URL to remove or change something, then copy it, it will copy it without scheme)
(no idea why)
yvanzo
We might have a patch for musicbrainz-docker, so release is pending that too.
(release blog post)
reosarevok
Ok :)
But that won't affect the post text, right? Just the link and whatnot
yvanzo
right
reosarevok
We usually remove "Other" from "other task" if there's no React tasks, right?
Made a couple small changes, but it seems good, thanks
Is it fine to merge approved stuff to master already then? :)
Or do you want to finish the docker + post process?
yvanzo
reosarevok: I updated master with production, it is fine to merge stuff :)
reosarevok
Thanks
mayhem: I can take today :)
BrainzGit
[musicbrainz-server] 14reosarevok merged pull request #2754 (03master…MBS-12712): MBS-12712: Improve wording for new release adding on disc ID lookup https://github.com/metabrainz/musicbrainz-serve...
[musicbrainz-server] 14reosarevok merged pull request #2761 (03master…MBS-12738): MBS-12738 / MBS-12739: Don't assume "single" and "studio" are ETI unless inside parens https://github.com/metabrainz/musicbrainz-serve...