(possibly because it’s not needed on these nodes either?)
zas
borg-backup is deprecated, superseded by ansible borgmatic
yvanzo
👍
bitmap
yvanzo: I guess we'll need to decide how to encode those comments in the source files. easiest way would be adding another argument to l, ln, lp
zas
I need to go through servers to remove those dirs
btw, borg backups were triggered by a timer that should not be active anymore
reosarevok
bitmap: we didn't have any optional arguments right now, right? So having a final one that can be ommitted would be safe?
bitmap
I think so, I haven't played with xgettext in a while
for JS it won't be an issue since we have a custom extraction script
jasje
akshaaatt: can you check that tests are run? Because i keep noticing that broken tests that result in failure sometimes get away with it
take for example the bp tests
those were broken for a long time
the lint and build tests run fine
reosarevok
yvanzo: if we extract it like bitmap proposed, hopefully sending it to weblate would be trivial? :)
yvanzo
Yes, we just have to build the POT file correctly.
bitmap
yeah iiuc they'd just be added as # comments in the pot file
yvanzo
Comments should not make the current translations obsolete either, only changing context does.
(context as in msgctxt)
Another thing that came across the discussion recently as well about l ln lp: We should probably avoid localizing the admin UI. Maybe adding an l_admin to avoid that from happening?
akshaaatt
jasje can you please link me to the tests that were/are broken?
i made changes to testUsername (Jasjeet) and yim_data.json (jasjeet) was outdated and resulted in failure but it didn't get fixed
bitmap
yvanzo: oh, to signal that it shouldn't be translated? I'm fine with it
jasje
akshaaatt: the DaoTest one is old but i remember fixing it
the yim test one is the latest example
reosarevok
I'm not sure why we want to actively not translate admin stuff - I think it'd be lovely if admins could also eventually use the site in their own language :)
But I don't mind if you really prefer that
yvanzo
zas: when I run remote commands on herb & kiki, this warning shows up: "mesg: ttyname failed: Inappropriate ioctl for device"
akshaaatt
We messed up the gradle file for tests jasje
jasje
*****i made changes to testUsername (Jasjeet) and yim_data.json (jasjeet) was outdated and resulted in failure but the test didn't fail on pr run
akshaaatt: ?
where
bitmap
are most admin pages translated already?
yvanzo
bitmap: To not even propagate it to any POT file, a like we have l_statistics for statistics.pot.
reosarevok
Probably mostly just to Italian :)
yvanzo
Translations status is not brilliant atm. It doesn’t seem reasonable to ask translating messages that will be used by nobody because admins are English speakers anyway.
For example, there is no Italian-speaker among admins.
reosarevok
At the very least, I'd be happy to have l_admin
yvanzo
It would also probably prevent further issues such as MBS-10553.
The user report reason should be translated anyway, it's not for admins, it's user-facing :)
(just the admins can get it in English, I guess)
bitmap
having a separate domain for them might be an option if we can signal that the strings are of low priority on weblate
reosarevok
Transifex had that, at least
yvanzo
reosarevok: It "is sent to admins" but that is just a related issue, not the same.
reosarevok
Sure :)
yvanzo
reosarevok: Are you translating/using Spanish or Estonian UI?
reosarevok
I've translated Spanish a long time ago
Not really using it though (I am not used to use online stuff in Spanish, it's always felt weird to me :D )
yvanzo
Not asking for useless translations is also respecting translators work.
reosarevok
I get it
It'll be kinda weird when we have a page that both admins and non-admins can use with some different strings, but I can live with that
akshaaatt
jasje: I just checked again. At first I thought it had something to do with the path for the tests
But we do run the unit tests through github actions during CI
yvanzo
Anyway, the admin UI messages are here for now, it is not something that is required for migrating to Weblate, but just something that was related to what we discussed this week.
akshaaatt
There’s no way to run instrumentation tests during CI
And I don’t think we should even aim for that
reosarevok
Sure :)
bitmap
the only niche scenario I can think of is a user wanting to use the test server in their own language and needing the admin UIs to reproduce something
yvanzo
reosarevok: Good point, probably just on admin-only pages then?
reosarevok
yvanzo: works for me
yvanzo
Ok, will open a ticket.
jasje
akshaaatt: whaattt
i mean UI tests are actually the real tests
reosarevok
yvanzo: is there anything else we need to decide for weblate? What are the next MBS steps?
zas
yvanzo: how do you run those remote commands? btw, kiki & herb are meant to be retired very soon