(possibly because it’s not needed on these nodes either?)
2023-06-01 15230, 2023
zas
borg-backup is deprecated, superseded by ansible borgmatic
2023-06-01 15236, 2023
yvanzo
👍
2023-06-01 15251, 2023
bitmap
yvanzo: I guess we'll need to decide how to encode those comments in the source files. easiest way would be adding another argument to l, ln, lp
2023-06-01 15252, 2023
zas
I need to go through servers to remove those dirs
2023-06-01 15201, 2023
zas
btw, borg backups were triggered by a timer that should not be active anymore
2023-06-01 15231, 2023
reosarevok
bitmap: we didn't have any optional arguments right now, right? So having a final one that can be ommitted would be safe?
2023-06-01 15234, 2023
bitmap
I think so, I haven't played with xgettext in a while
2023-06-01 15248, 2023
bitmap
for JS it won't be an issue since we have a custom extraction script
2023-06-01 15232, 2023
jasje
akshaaatt: can you check that tests are run? Because i keep noticing that broken tests that result in failure sometimes get away with it
2023-06-01 15255, 2023
jasje
take for example the bp tests
2023-06-01 15203, 2023
jasje
those were broken for a long time
2023-06-01 15253, 2023
jasje
the lint and build tests run fine
2023-06-01 15214, 2023
reosarevok
yvanzo: if we extract it like bitmap proposed, hopefully sending it to weblate would be trivial? :)
2023-06-01 15239, 2023
yvanzo
Yes, we just have to build the POT file correctly.
2023-06-01 15259, 2023
bitmap
yeah iiuc they'd just be added as # comments in the pot file
2023-06-01 15221, 2023
yvanzo
Comments should not make the current translations obsolete either, only changing context does.
2023-06-01 15247, 2023
yvanzo
(context as in msgctxt)
2023-06-01 15211, 2023
yvanzo
Another thing that came across the discussion recently as well about l ln lp: We should probably avoid localizing the admin UI. Maybe adding an l_admin to avoid that from happening?
2023-06-01 15255, 2023
akshaaatt
jasje can you please link me to the tests that were/are broken?
i made changes to testUsername (Jasjeet) and yim_data.json (jasjeet) was outdated and resulted in failure but it didn't get fixed
2023-06-01 15213, 2023
bitmap
yvanzo: oh, to signal that it shouldn't be translated? I'm fine with it
2023-06-01 15222, 2023
jasje
akshaaatt: the DaoTest one is old but i remember fixing it
2023-06-01 15235, 2023
jasje
the yim test one is the latest example
2023-06-01 15204, 2023
reosarevok
I'm not sure why we want to actively not translate admin stuff - I think it'd be lovely if admins could also eventually use the site in their own language :)
2023-06-01 15213, 2023
reosarevok
But I don't mind if you really prefer that
2023-06-01 15221, 2023
yvanzo
zas: when I run remote commands on herb & kiki, this warning shows up: "mesg: ttyname failed: Inappropriate ioctl for device"
2023-06-01 15223, 2023
akshaaatt
We messed up the gradle file for tests jasje
2023-06-01 15238, 2023
jasje
*****i made changes to testUsername (Jasjeet) and yim_data.json (jasjeet) was outdated and resulted in failure but the test didn't fail on pr run
2023-06-01 15249, 2023
jasje
akshaaatt: ?
2023-06-01 15254, 2023
jasje
where
2023-06-01 15257, 2023
bitmap
are most admin pages translated already?
2023-06-01 15226, 2023
yvanzo
bitmap: To not even propagate it to any POT file, a like we have l_statistics for statistics.pot.
2023-06-01 15230, 2023
reosarevok
Probably mostly just to Italian :)
2023-06-01 15215, 2023
yvanzo
Translations status is not brilliant atm. It doesn’t seem reasonable to ask translating messages that will be used by nobody because admins are English speakers anyway.
2023-06-01 15200, 2023
yvanzo
For example, there is no Italian-speaker among admins.
2023-06-01 15240, 2023
reosarevok
At the very least, I'd be happy to have l_admin
2023-06-01 15247, 2023
yvanzo
It would also probably prevent further issues such as MBS-10553.
The user report reason should be translated anyway, it's not for admins, it's user-facing :)
2023-06-01 15224, 2023
reosarevok
(just the admins can get it in English, I guess)
2023-06-01 15208, 2023
bitmap
having a separate domain for them might be an option if we can signal that the strings are of low priority on weblate
2023-06-01 15238, 2023
reosarevok
Transifex had that, at least
2023-06-01 15240, 2023
yvanzo
reosarevok: It "is sent to admins" but that is just a related issue, not the same.
2023-06-01 15200, 2023
reosarevok
Sure :)
2023-06-01 15202, 2023
yvanzo
reosarevok: Are you translating/using Spanish or Estonian UI?
2023-06-01 15215, 2023
reosarevok
I've translated Spanish a long time ago
2023-06-01 15235, 2023
reosarevok
Not really using it though (I am not used to use online stuff in Spanish, it's always felt weird to me :D )
2023-06-01 15247, 2023
yvanzo
Not asking for useless translations is also respecting translators work.
2023-06-01 15205, 2023
reosarevok
I get it
2023-06-01 15226, 2023
reosarevok
It'll be kinda weird when we have a page that both admins and non-admins can use with some different strings, but I can live with that
2023-06-01 15256, 2023
akshaaatt
jasje: I just checked again. At first I thought it had something to do with the path for the tests
2023-06-01 15214, 2023
akshaaatt
But we do run the unit tests through github actions during CI
2023-06-01 15231, 2023
yvanzo
Anyway, the admin UI messages are here for now, it is not something that is required for migrating to Weblate, but just something that was related to what we discussed this week.
2023-06-01 15234, 2023
akshaaatt
There’s no way to run instrumentation tests during CI
2023-06-01 15244, 2023
akshaaatt
And I don’t think we should even aim for that
2023-06-01 15246, 2023
reosarevok
Sure :)
2023-06-01 15247, 2023
bitmap
the only niche scenario I can think of is a user wanting to use the test server in their own language and needing the admin UIs to reproduce something
2023-06-01 15250, 2023
yvanzo
reosarevok: Good point, probably just on admin-only pages then?
2023-06-01 15259, 2023
reosarevok
yvanzo: works for me
2023-06-01 15232, 2023
yvanzo
Ok, will open a ticket.
2023-06-01 15245, 2023
jasje
akshaaatt: whaattt
2023-06-01 15205, 2023
jasje
i mean UI tests are actually the real tests
2023-06-01 15234, 2023
reosarevok
yvanzo: is there anything else we need to decide for weblate? What are the next MBS steps?
2023-06-01 15217, 2023
zas
yvanzo: how do you run those remote commands? btw, kiki & herb are meant to be retired very soon