Random find, Fediverse instance that has built-in Listenbrainz support for ’now playing’ etc: https://joinsharkey.org/
2024-01-15 01512, 2024
pranavkonidena_ joined the channel
2024-01-15 01520, 2024
aerozol
outsidecontext: do you remember at the summit we talked about doing a Picard wizard, and I suggested some ‘light’ graphics to go with it? I (finally) found an illustrator who could do something simple for us
Let me know your thoughts. Then I’m happy to do mockups with the images included so there’s no rush with code, but everything’s ready from the graphics side
2024-01-15 01518, 2024
minimal has quit
2024-01-15 01548, 2024
gcrkrause has quit
2024-01-15 01537, 2024
ssam5 joined the channel
2024-01-15 01506, 2024
ssam has quit
2024-01-15 01506, 2024
ssam5 is now known as ssam
2024-01-15 01534, 2024
lucifer
aerozol: link to unmapped listens?
2024-01-15 01505, 2024
lucifer
bitmap: yeah those warnings happen for me too, I think it's the recordings loading too much data at once but let's do a full reindex on wolf/test first and then look into it. The warning only points to a possibility of performance degradation.
2024-01-15 01549, 2024
aabbi15_ joined the channel
2024-01-15 01522, 2024
aerozol
lucifer: yeah, you said you're re running everything right?
2024-01-15 01534, 2024
lucifer
aerozol: for YIM, yes
2024-01-15 01521, 2024
lucifer
But I was asking about the unmapped listens submitted by webscrobbler.
2024-01-15 01533, 2024
aerozol
Oh sorry, I thought you were talking about the YIM post! Give me a sec
2024-01-15 01506, 2024
aerozol
lucifer: it seems to be fine now. I guess it’s good that lately every time I go to properly report something it works again 🤔 😑
2024-01-15 01519, 2024
aerozol
Good, but makes me look like a butt
2024-01-15 01522, 2024
aabbi15_ has quit
2024-01-15 01539, 2024
lucifer
Hehe lol
2024-01-15 01505, 2024
bitmap
lucifer: sure, I can trigger a another reindex with a new sir image. but there are test failures in the sir PR, too -- did you want to look into those first?
2024-01-15 01529, 2024
lucifer
bitmap: i looked at those, it seems the sample data in the musicbrainz test database image has changed. There is now an instrument in the database, earlier the entity tables used to be empty.
2024-01-15 01550, 2024
lucifer
Is that entry expected?
2024-01-15 01534, 2024
lusciouslover has quit
2024-01-15 01559, 2024
bitmap
I think we recently added an instrument to t/sql/initial.sql, if that's what it uses. normally we only have type data in there, but the instrument table is technically supposed to be synced with link_attribute_type, so it was needed for a test
2024-01-15 01535, 2024
lucifer
makes sense, i'll update sir tests to accommodate that then. but it should be fine to trigger reindex now because its only an issue with the test data.
2024-01-15 01522, 2024
bitmap
it fails on Klavier, so yeah, that was the one we added
The users of the app have been requesting listen submission to be opt-in multiple times as Pano-scrobbler does.
2024-01-15 01544, 2024
aabbi15 joined the channel
2024-01-15 01503, 2024
jasje
The pr solves that but I do realise that we need proper onboarding for that.
2024-01-15 01507, 2024
akshaaatt
Hi jasje !
2024-01-15 01515, 2024
akshaaatt
You know I appreciate all your work but don’t just pick up tickets that people make. I think it’s wrong for tickets to propose solutions to problems. We are the devs. We will find the solution after discussing with our teams
2024-01-15 01518, 2024
akshaaatt
I think we have left pano scrobbler far behind jasje in our approach. LB app is a full blown app and pano is only solving for a particular usecase. What works for them doesn’t have to work for us
2024-01-15 01528, 2024
akshaaatt
I was having this discussion with lucifer that we should try to solve the listening apps problem by giving only a set of apps that would be scrobbled from. If we rely on the notifications service then that detects the Phone app, etc also as apps submitting listens
2024-01-15 01553, 2024
akshaaatt
It rather makes more sense for us to figure out a list of apps to support and then allow the users to select from it
2024-01-15 01540, 2024
akshaaatt
I am still unsure if we should have opt in even in that or allow all by default. Because people don’t have the time to go on correcting apps
2024-01-15 01507, 2024
outsidecontext
That'll a be a very long list of apps and it will constantly change, though
2024-01-15 01524, 2024
akshaaatt
If we maintain the apps list (while allowing explicit deselection), we make sure that the apps are correct atleast
2024-01-15 01530, 2024
rain0r has quit
2024-01-15 01538, 2024
rain0r joined the channel
2024-01-15 01554, 2024
akshaaatt
Agreed outsidecontext , hence I suggested we make that list public and users can submit new apps and peer review it like MB
2024-01-15 01508, 2024
jasje
opt-in make sures a new user doesn't accidentally scrobble videos from players that may register as media players.
2024-01-15 01524, 2024
jasje
chaban has brought this up quite a few times now
2024-01-15 01538, 2024
jasje
kellnerd also agreed in another convo
2024-01-15 01548, 2024
akshaaatt
Agreed but who does all that? I recently onboarded 4 friends to the LB app and they are happy that it magically scrobbles all the data
2024-01-15 01512, 2024
akshaaatt
Even I personally wouldn’t be interested in going and selecting all apps manually
2024-01-15 01533, 2024
akshaaatt
mayhem had also mentioned that user should care very less about the list
2024-01-15 01500, 2024
jasje
but if the app doesn't, I as a user, would go to settings and find out if something changes that
2024-01-15 01509, 2024
akshaaatt
I’m not saying opt in is not a solution to look for. But I think there are more can of worms to this because it only solves the problem for a particular set of people
2024-01-15 01501, 2024
outsidecontext
it could ask about this in the setup. also using the LB app for only the informational part without enabling listen submission should be a valid use case I think
2024-01-15 01527, 2024
lucifer
allowing users to only choose from a given list of apps sounds like a bad idea to me.
2024-01-15 01546, 2024
lucifer
at most, make it instructive or enabled by default.
2024-01-15 01502, 2024
lucifer
but a user should be able to enable any app they have installed.
2024-01-15 01504, 2024
akshaaatt
The setup idea sounds good to me outsidecontext but the way we detect apps is dynamic currently. We do not notice all the apps at once from the notifications service
2024-01-15 01507, 2024
akshaaatt
lucifer do you think it would be good for the user to have an option in the listening apps section to enter the package name/select the app they want from a list fetched by android and then start submitting listens from it?
2024-01-15 01513, 2024
outsidecontext
I mean enabling the listen submission at all. also it could show a notiication the first time a new app is detected so users can decide to disable it.
2024-01-15 01552, 2024
jasje
we can enable some well known apps by default
2024-01-15 01510, 2024
akshaaatt
outsidecontext: that sounds like the ideal case but I rarely open all my notifications. I could easily miss the notification to disable
2024-01-15 01517, 2024
lucifer
akshaaatt: yes, enable the known media players by default and give an option to enable/disable any app in settings.
2024-01-15 01537, 2024
akshaaatt
I think we are on the same page now lucifer
2024-01-15 01542, 2024
akshaaatt
That is what I want
2024-01-15 01518, 2024
akshaaatt
outsidecontext: i think that setting ask in the onboarding is a fair ask. We should do that
2024-01-15 01505, 2024
outsidecontext
that sounds good. if it whitelists well known apps but still allows the user to enable other automatically detected apps it could satisfy all the requirements
2024-01-15 01546, 2024
akshaaatt
Great. I am happy with that. I would also like some comments from mayhem and aerozol on this UX and then we can work on it.
2024-01-15 01550, 2024
akshaaatt
jasje sounds good?
2024-01-15 01503, 2024
jasje
sounds good
2024-01-15 01510, 2024
outsidecontext
akshaaatt: I need to check that again, but last time I logged in to the LB app it started submitting listens without me being able to disable that. only way I found was resetting the app data and be logged out again.
2024-01-15 01532, 2024
akshaaatt
lucifer: for the well known apps, should we have an api or hardcode the apps?
2024-01-15 01501, 2024
akshaaatt
Right outsidecontext , we should fix that
2024-01-15 01506, 2024
lucifer
akshaaatt: hardcode for now, can add an api later.
2024-01-15 01511, 2024
akshaaatt
Cool
2024-01-15 01558, 2024
outsidecontext
it's the reason why I currently don't use the app at all. currently I would love to use the app for browsing, but roll my own solution for submission
2024-01-15 01533, 2024
akshaaatt
Hmmmm
2024-01-15 01536, 2024
lucifer
yvanzo, reosarevok: hi! are there any stats available on how often search is queried for xml vs json response?
2024-01-15 01527, 2024
jasje
outsidecontext: so you mean the apps were being scrobbled even if the scrobbling was off?
2024-01-15 01553, 2024
outsidecontext
yes. but maybe that has already been fixed?
2024-01-15 01555, 2024
jasje
for those specific apps
2024-01-15 01558, 2024
jasje
huh
2024-01-15 01528, 2024
jasje
did you go back to the settings and check if the option was still disabled?
2024-01-15 01542, 2024
jasje
outsidecontext^
2024-01-15 01528, 2024
outsidecontext
I need to check again. that was end of last year where I was pretty busy ^^ but as far as I remember the option to disable submission was stuck and could not be changed (or changing it was not saved)
2024-01-15 01550, 2024
outsidecontext
I can test and open a ticket if this is still an issue
2024-01-15 01500, 2024
jasje
enabling and disabling is reactive now
2024-01-15 01532, 2024
jasje
the moment you disable, it'll max to max send the next song
Akshaaatt: jasje: I'm considering turning off the app atm, because of that issue, as well. My LB has started submitting listens from our neighbors Chromecast, who are on the wifi...
2024-01-15 01558, 2024
aerozol
It's late so I don't have time to look through the problem in detail right now, but feel free to ping me or point to any tickets with discussion and I'll have a look. This is definitely a priority for the app imo
2024-01-15 01559, 2024
jasje
outsidecontext: so the steps to reproduce are:
2024-01-15 01522, 2024
jasje
1) Have submission enabled and have some listening apps
2024-01-15 01532, 2024
jasje
2) Try to change the setting
2024-01-15 01550, 2024
jasje
3) Try scrobbling from disabled apps.
2024-01-15 01507, 2024
jasje
4) Go back if settings are same or not
2024-01-15 01524, 2024
outsidecontext
I think disabling apps works, disabling the full "Send listens" does not
2024-01-15 01554, 2024
outsidecontext
start the app, login to LB. "Send listens" is enabled by default. Go to settings and try to disable it
2024-01-15 01501, 2024
jasje
wait who put that there
2024-01-15 01556, 2024
jasje
outsidecontext: i think i see the issue
2024-01-15 01503, 2024
jasje
miscommunication
2024-01-15 01525, 2024
jasje
ill fix that thanks for reporting
2024-01-15 01532, 2024
outsidecontext
thanks
2024-01-15 01526, 2024
jasje
aerozol: i know, i just need to find this ticket that pointed this out
2024-01-15 01534, 2024
jasje
probably do in the next pr
2024-01-15 01539, 2024
jasje
and push to beta
2024-01-15 01515, 2024
aerozol
jasje: it's not just that submission - agree with you that it shouldn't be submitting anything I don't want it to
2024-01-15 01537, 2024
aerozol
On the positive side, users bugging us about this stuff means the app is starting to see some use 👍
2024-01-15 01516, 2024
aabbi15_ has quit
2024-01-15 01552, 2024
mayhem
moin everyone!
2024-01-15 01519, 2024
mayhem
ready for docsprint week? docspring week starts with a round of contracts for everyone, joy!
2024-01-15 01547, 2024
jasje
aerozol: we can add a settings for chromecast stuff
2024-01-15 01554, 2024
jasje
setting*
2024-01-15 01509, 2024
jasje
idk about the true extent of the edge cases here
2024-01-15 01515, 2024
jasje
but i do have a good idea
2024-01-15 01522, 2024
jasje
Call management has to go
2024-01-15 01532, 2024
jasje
that bugga has been there too long
2024-01-15 01546, 2024
akshaaatt
jasje: can you look into this today?
2024-01-15 01524, 2024
kellnerd
<akshaaatt> [...] the way we detect apps is dynamic currently. We do not notice all the apps at once from the notifications service
2024-01-15 01524, 2024
kellnerd
That is part of the problem. I specifically took care that only the apps were enabled from where I want to submit listens during the initial setup, but later the LB app discovered random apps and started to submit listens without asking me first.
2024-01-15 01546, 2024
aerozol
jasje: it's not about that - if there's *anything* being played that I haven't explicitly enabled then it shouldn't get sent
2024-01-15 01557, 2024
aerozol
(what kellnerd said)
2024-01-15 01509, 2024
jasje
aerozol: my current pr would fix that
2024-01-15 01545, 2024
aerozol
Like I said, I agree with you 🙂 but yeah the UX will have to be looked at as well
2024-01-15 01530, 2024
jasje
aerozol: what are thing for the UX
2024-01-15 01539, 2024
jasje
what are you thinking***
2024-01-15 01556, 2024
jasje
What changes should be made
2024-01-15 01538, 2024
akshaaatt
aerozol: could you please read through the conversations to the point where me and lucifer got to the same page and comment from there about your thoughts?
2024-01-15 01503, 2024
jasje
akshaaatt: maybe a button that says "Automatically scrobble new players" in settings and have it enabled by default?
