#metabrainz

Random find, Fediverse instance that has built-in Listenbrainz support for ’now playing’ etc: https://joinsharkey.org/

outsidecontext: do you remember at the summit we talked about doing a Picard wizard, and I suggested some ‘light’ graphics to go with it? I (finally) found an illustrator who could do something simple for us

She can do this style very quickly/reasonably https://usercontent.irccloud-cdn.com/file/lamFZ...

Or something more complex

Let me know your thoughts. Then I’m happy to do mockups with the images included so there’s no rush with code, but everything’s ready from the graphics side

aerozol: link to unmapped listens?

bitmap: yeah those warnings happen for me too, I think it's the recordings loading too much data at once but let's do a full reindex on wolf/test first and then look into it. The warning only points to a possibility of performance degradation.

lucifer: yeah, you said you're re running everything right?

aerozol: for YIM, yes

But I was asking about the unmapped listens submitted by webscrobbler.

Oh sorry, I thought you were talking about the YIM post! Give me a sec

lucifer: it seems to be fine now. I guess it’s good that lately every time I go to properly report something it works again 🤔 😑

Good, but makes me look like a butt

Hehe lol

lucifer: sure, I can trigger a another reindex with a new sir image. but there are test failures in the sir PR, too -- did you want to look into those first?

bitmap: i looked at those, it seems the sample data in the musicbrainz test database image has changed. There is now an instrument in the database, earlier the entity tables used to be empty.

Is that entry expected?

I think we recently added an instrument to t/sql/initial.sql, if that's what it uses. normally we only have type data in there, but the instrument table is technically supposed to be synced with link_attribute_type, so it was needed for a test

makes sense, i'll update sir tests to accommodate that then. but it should be fine to trigger reindex now because its only an issue with the test data.

it fails on Klavier, so yeah, that was the one we added

ok, I'll build a new image then

great, thanks!

running now :)

the previous one took about 19 hours, I think

good morning

[listenbrainz-server] 14amCap1712 merged pull request #2709 (03master…dependabot/pip/jinja2-3.1.3): Bump jinja2 from 2.11.3 to 3.1.3 https://github.com/metabrainz/listenbrainz-serv...

akshaaatt: lets talk about pr #336

The users of the app have been requesting listen submission to be opt-in multiple times as Pano-scrobbler does.

The pr solves that but I do realise that we need proper onboarding for that.

Hi jasje !

I think we have left pano scrobbler far behind jasje in our approach. LB app is a full blown app and pano is only solving for a particular usecase. What works for them doesn’t have to work for us

I was having this discussion with lucifer that we should try to solve the listening apps problem by giving only a set of apps that would be scrobbled from. If we rely on the notifications service then that detects the Phone app, etc also as apps submitting listens

It rather makes more sense for us to figure out a list of apps to support and then allow the users to select from it

I am still unsure if we should have opt in even in that or allow all by default. Because people don’t have the time to go on correcting apps

That'll a be a very long list of apps and it will constantly change, though

If we maintain the apps list (while allowing explicit deselection), we make sure that the apps are correct atleast

Agreed outsidecontext , hence I suggested we make that list public and users can submit new apps and peer review it like MB

opt-in make sures a new user doesn't accidentally scrobble videos from players that may register as media players.

chaban has brought this up quite a few times now

kellnerd also agreed in another convo

Agreed but who does all that? I recently onboarded 4 friends to the LB app and they are happy that it magically scrobbles all the data

Even I personally wouldn’t be interested in going and selecting all apps manually

mayhem had also mentioned that user should care very less about the list

but if the app doesn't, I as a user, would go to settings and find out if something changes that

I’m not saying opt in is not a solution to look for. But I think there are more can of worms to this because it only solves the problem for a particular set of people

it could ask about this in the setup. also using the LB app for only the informational part without enabling listen submission should be a valid use case I think

allowing users to only choose from a given list of apps sounds like a bad idea to me.

at most, make it instructive or enabled by default.

but a user should be able to enable any app they have installed.

The setup idea sounds good to me outsidecontext but the way we detect apps is dynamic currently. We do not notice all the apps at once from the notifications service

lucifer do you think it would be good for the user to have an option in the listening apps section to enter the package name/select the app they want from a list fetched by android and then start submitting listens from it?

I mean enabling the listen submission at all. also it could show a notiication the first time a new app is detected so users can decide to disable it.

we can enable some well known apps by default

outsidecontext: that sounds like the ideal case but I rarely open all my notifications. I could easily miss the notification to disable

akshaaatt: yes, enable the known media players by default and give an option to enable/disable any app in settings.

I think we are on the same page now lucifer

That is what I want

outsidecontext: i think that setting ask in the onboarding is a fair ask. We should do that

that sounds good. if it whitelists well known apps but still allows the user to enable other automatically detected apps it could satisfy all the requirements

Great. I am happy with that. I would also like some comments from mayhem and aerozol on this UX and then we can work on it.

jasje sounds good?

sounds good

akshaaatt: I need to check that again, but last time I logged in to the LB app it started submitting listens without me being able to disable that. only way I found was resetting the app data and be logged out again.

lucifer: for the well known apps, should we have an api or hardcode the apps?

Right outsidecontext , we should fix that

akshaaatt: hardcode for now, can add an api later.

Cool

it's the reason why I currently don't use the app at all. currently I would love to use the app for browsing, but roll my own solution for submission

Hmmmm

yvanzo, reosarevok: hi! are there any stats available on how often search is queried for xml vs json response?

outsidecontext: so you mean the apps were being scrobbled even if the scrobbling was off?

yes. but maybe that has already been fixed?

for those specific apps

huh

did you go back to the settings and check if the option was still disabled?

outsidecontext^

I need to check again. that was end of last year where I was pretty busy ^^ but as far as I remember the option to disable submission was stuck and could not be changed (or changing it was not saved)

I can test and open a ticket if this is still an issue

enabling and disabling is reactive now

the moment you disable, it'll max to max send the next song

currently playing song*

outsidecontext: that would be very nice

jasje: still an issue: https://tickets.metabrainz.org/browse/MOBILE-148

MOBILE-148: Listen Submission not working on Fiio M11

combined with the fact that submission for all apps is enabled by default, including the phone app(!), makes the current version unusable to me :(

sorry, linked wrong ticket: https://tickets.metabrainz.org/browse/MOBILE-184

MOBILE-184: Listen submission can not be disabled

Akshaaatt: jasje: I'm considering turning off the app atm, because of that issue, as well. My LB has started submitting listens from our neighbors Chromecast, who are on the wifi...

It's late so I don't have time to look through the problem in detail right now, but feel free to ping me or point to any tickets with discussion and I'll have a look. This is definitely a priority for the app imo

outsidecontext: so the steps to reproduce are:

1) Have submission enabled and have some listening apps

2) Try to change the setting

3) Try scrobbling from disabled apps.

4) Go back if settings are same or not

I think disabling apps works, disabling the full "Send listens" does not

start the app, login to LB. "Send listens" is enabled by default. Go to settings and try to disable it

wait who put that there

outsidecontext: i think i see the issue

miscommunication

ill fix that thanks for reporting

thanks

aerozol: i know, i just need to find this ticket that pointed this out

probably do in the next pr

and push to beta

jasje: it's not just that submission - agree with you that it shouldn't be submitting anything I don't want it to

On the positive side, users bugging us about this stuff means the app is starting to see some use 👍

moin everyone!

ready for docsprint week? docspring week starts with a round of contracts for everyone, joy!

aerozol: we can add a settings for chromecast stuff

setting*

idk about the true extent of the edge cases here

but i do have a good idea

Call management has to go

that bugga has been there too long

jasje: can you look into this today?

<akshaaatt> [...] the way we detect apps is dynamic currently. We do not notice all the apps at once from the notifications service

That is part of the problem. I specifically took care that only the apps were enabled from where I want to submit listens during the initial setup, but later the LB app discovered random apps and started to submit listens without asking me first.

jasje: it's not about that - if there's *anything* being played that I haven't explicitly enabled then it shouldn't get sent

(what kellnerd said)

aerozol: my current pr would fix that

Like I said, I agree with you 🙂 but yeah the UX will have to be looked at as well

aerozol: what are thing for the UX

what are you thinking***

What changes should be made

aerozol: could you please read through the conversations to the point where me and lucifer got to the same page and comment from there about your thoughts?

akshaaatt: maybe a button that says "Automatically scrobble new players" in settings and have it enabled by default?