aerozol: those looks great! Slight preference for version A but they all work. Nice looks!
relaxoMob has quit
relaxoMob joined the channel
yvanzo
bitmap, reosarevok: still on my way back home at the moment
reosarevok
Ok, no worries :)
mayhem
moooin!
lucifer: where are these reports?
aerozol: those looks great! <3
yvanzo
bitmap, reosarevok: Looking at the recordings with the longest names, it seems that 1024 characters can be a more than reasonable hard limit. it wouldn’t require any change to the database schema either.
relaxoMob has quit
relaxoMob joined the channel
Most of these are intentionally crafted by database trolls, and I’m totally fine with not wasting MB resources at supporting these in the `name` field. Their full “title” can be added in annotation if editors think that it is worth their time.
reosarevok
Hmm
How come it doesn't require schema changes? Wouldn't we need to alter the column to have a lower char limit?
When I first looked at the related MBS-13536, the longest legitimate correct title had less than 500 characters and was a classical track, that was probably listing all the works instead of just the title.
reosarevok: Just through edit validation in Perl indeed. I agree that having an additional constraint in PG can be safer too, but it isn’t strictly at first, and it is much simpler than modifying indexes anyway.
reosarevok
O
*Ok :)
I think that sound effect thing might actually be correct, but it's not super important in any case
It might also be a Discogs’ editor choice, who knows, but the track titles in MB make no sense, it looks like a bad copy-paste.
reosarevok
Yeah, I was wondering because these sound effect albums sometimes have very weird track titles :)
But you're probably right, it looks extra weird
yvanzo
We can also have some guidelines saying that too long titles should be considered as liner notes and be put in annotations.
zas
yvanzo: I just restarted sir-prod, it was errorring
atj
1024 characters is enough for anyone
yvanzo
Even for a few tens of potentially legitimate recordings in 30M+ of recordings, it isn’t worth requiring all the tools accessing the MB DB to support more than 1024 chars.
zas: Thanks!
atj
yvanzo: FYI we're probably going to end up running the new Solr cluster on arm64 servers
yvanzo
atj: Amazing!
atj
they're about 30% cheaper and we get 2x the cores
yvanzo
I won’t be around most of the day but I will spend the time I have at patching edit validation.
atj
i've got a mixed 7 node cluster handling 450req/s without too much problem
that was with 6 x86 and 1 arm64 node
yvanzo: you, zas and i should probably have a chat next week as I think we're approaching a production ready setup
zas
yup
we still need to round some corners, but we're getting there
reosarevok
yvanzo: I think that sounds sensible really
yvanzo: huh, not sure what went wrong (but I did not have a fully cleared setup, so maybe that's part of it):
(while running sudo docker-compose run --rm musicbrainz createdb.sh -fetch)
yvanzo
atj, zas: Yes, the plan is to reset solrcloud data from the production database, to set up a 2nd sir instance to live feed it, and to make beta.mb.o use it for search.
atj
yvanzo: i disabled the documentcache entirely for testing because of the lack of updates from test.mb.o
so it wasn't ever getting flushed
to be honest i'm not sure it's even worth it with a 10 second soft commit time
reosarevok: is there a proposed date for the next mbs release?
reosarevok
Well, we don't have a lot to release rn I think, ideally we'd put the eaa in beta for a little bit, let people test it, then put that out
But if there's something you want out in prod, we could do a smaller release too, that's fine
yvanzo
reosarevok: is that test setup? this error can occur when `carton exec` is run but `cpanfile` is not found. you can check that this file exists and that `carton` is run from the right directory. Or maybe some environment variable should be set (you can try to pick it from mb-server repo)
reosarevok
I just dropped the containers, checked out your branch and started following the readme :)
yvanzo
The current beta requires perl 5.38, it can’t be released in prod before the schema change.
For patching edit validation, we have to target the production branch directly.
reosarevok
atj: ok, in that case the proposed date is May 13 :)
atj
reosarevok: so May 13th for schema change release?
reosarevok
Yeah
atj
which includes the upgrade to Solr 9?
yvanzo
bitmap: The MB mirror on wolf is up-to-date, did you fix replication packets already or is it just not affecting MB Docker mirrors?
atj: yes
atj
3 weeks then 😬
yvanzo
bitmap: Or is it just affecting the latest dumps? (let me dream)
yvanzo is offline again for a few hours
yellowhatpro has quit
KassOtsimine
I tried the lb playlist generator with country:(india) (or japan or anything) and all I get is
idk. i tried with and witotuh coutes, i tried replacing with tag isntead idk
it doesnt seem towork?
it'd be good if it actually had copy-paste seartch urls too!
monkey[m] joined the channel
monkey[m]
KassOtsimine (IRC): The country stuff is new and I think it was only deployed to beta for a little bit, but has been replaced since
KassOtsimine
hmm alright, but tag:;(something) brings the same error
-;
monkey[m]
Brings a different error for me, but a known one
ansh
monkey[m]: I looked into migrating the class components to functional components. You can only use wrapper with PlayerPage, not the other components as they have the listens saved in states which are updated based on user interactions. I'll push that change directly in the brainzplayer-spa branch.
KassOtsimine
for simply tag:(trip hop)
IK get
LB Radio generation failed: Cannot fetch recordings for tags. {"code":400,"error":"pop_begin param is missing"}
monkey[m]
ansh (IRC): OK, that's one less component to deal with :)
KassOtsimine
🤷♂️
monkey[m]
yep KassOtsimine (IRC) that's ruight. Known issue, I reported it yesterday too
KassOtsimine
oh! if it's known
monkey[m]
Well, I guess it's in a known broken state
The artist prompts work
KassOtsimine
just clarifying: I'm ona modern browser now
monkey[m]
Yep, this time it ain't you ;D
Enjoying the modern web?
aerozol[m] joined the channel
aerozol[m]
Woww KassOtsimine! Hopefully it's not too annoying!
KassOtsimine
what are you all going on about? thisis theothe computer. i already toldyou the new computer isn't owkring :/