14:10 PM
ansh
That test has passed now 😌
14:12 PM
BrainzGit
14:12 PM
monkey[m]
🎉
14:12 PM
monkey[m] deploys to beta
14:13 PM
mayhem
monkey[m]: the test is broken, but that should't affect underlying functionality.
14:13 PM
because, I am running out of time for today.
14:14 PM
bitmap
lucifer: hi, the oauth meeting next monday works for me
14:14 PM
monkey[m]
Right. It's been broken for a few months and poreventing us from using CI correctly, please consider putting it at the top of the list for Monday
14:14 PM
What am I saying
14:14 PM
mayhem
this test has been broken for months? really?
14:14 PM
monkey[m]
I meant a few weeks, and it's not this test that's been broken, my bad.
14:15 PM
mayhem
but yes, I plan to address it first thing monday.
14:15 PM
monkey[m]
I just want CI to work again 😢
14:15 PM
Thanks
14:15 PM
mayhem
understood.
14:18 PM
monkey[m]
Updating beta
14:25 PM
derat joined the channel
14:34 PM
derat has quit
14:39 PM
aerozol[m] has quit
14:43 PM
relaxoMob has quit
14:43 PM
relaxoMob joined the channel
14:52 PM
zerodogg joined the channel
14:58 PM
derat joined the channel
15:03 PM
relaxoMob has quit
15:06 PM
lucifer
bitmap: awesome
15:06 PM
15:08 PM
of the 8 failing tests, the 3 mandatory ones are issues with authlib and i opened PRs upstream to get those fixed. but looks like we are ready to go otherwise.
15:09 PM
bitmap
A+? ez
15:09 PM
lucifer
yup :)
15:10 PM
there are a few more security measures that we could take but i intentionally didn't add, like disabling implicit grant or mandating pkce.
15:11 PM
would make migrating from MB to MeB harder.
15:11 PM
Tarun_0x0 joined the channel
15:12 PM
can discuss it in detail in the meeting i guess.
15:16 PM
derat
15:17 PM
bitmap
lucifer: sounds good
15:17 PM
derat: not that I can recall, but I'll test it once more
15:34 PM
reosarevok
Oh, I forgot to check this, but if aerozol and bitmap are happy I'm sure I'm too
15:35 PM
"Primary alias in [locale]" seems good to me but if you prefer just "Primary alias" that works too
15:38 PM
derat has quit
15:44 PM
derat joined the channel
15:56 PM
the4oo4 has quit
15:57 PM
the4oo4 joined the channel
15:59 PM
lucifer
16:02 PM
Satyaraj[m] has quit
16:03 PM
bitmap
thanks lucifer
16:09 PM
zerodogg has quit
16:12 PM
Tarun_0x0 has quit
16:28 PM
derat: left one more comment
16:41 PM
derat
bitmap: thanks, working on it now!
16:54 PM
zerodogg joined the channel
17:04 PM
bitmap: TIL that if you screw up an import path in a file defining react components, you can get a very unhelpful "Use of uninitialized value $length in numeric lt (<) at lib/MusicBrainz/Server/Renderer.pm line 41." error :-)
17:04 PM
(eslint prints the actual problem, but i made the mistake of not running it again after trying to fix a missing import)
17:05 PM
bitmap
😅
17:06 PM
Flow should tell you too, but that error could definitely be improved
17:11 PM
derat
okay, i just pushed the change to switch to commaOnlyList. (is there a preference for squashing and force-pushing PR revisions, or should i always be pushing separate changes that'll be squashed when merging like i've been doing here?)
17:15 PM
bitmap
we haven't discussed it before AFAIK, but I know yvanzo also normally pushes incremental changes for squashing before merge. (I tend to force-push because I'm lazy.)
17:18 PM
derat
commit --amend and push --force is my preference too, but it seems like it makes a mess of github conversations
17:18 PM
monkey[m] has quit
17:22 PM
bitmap
yeah, it does sometimes :\
17:43 PM
huhridge joined the channel
17:52 PM
BrainzGit
17:56 PM
huhridge has quit
17:56 PM
derat
ah, didn't mean for all of those "SQUASH" messages to make it into the commit message. oh well, guess it doesn't hurt :-P
17:59 PM
bitmap
I thought about removing them, but figured more info about the changes isn't a bad thing
17:59 PM
derat
👍
18:11 PM
bitmap
reosarevok: yvanzo: I have some questions about updating translations, if either of you are around
18:11 PM
reosarevok
bitmap: kinda, ask
18:12 PM
bitmap
18:12 PM
reosarevok
Yes
18:12 PM
bitmap
I clicked push and it didn't appear to do anything
18:12 PM
reosarevok
Check the repo
18:12 PM
bitmap
also, is the upstream for my local translations branch supposed to be github, or weblate?
18:12 PM
reosarevok
IIRC it's confusing
18:13 PM
Github metabrainz branch translations
18:13 PM
bitmap
last updated 6 hours ago
18:13 PM
reosarevok
Hmm
18:15 PM
I clicked push and got "All repositories were pushed"
18:15 PM
But it does say 6 h ago
18:15 PM
bitmap
ok, not sure what "39 outgoing commits" means then
18:15 PM
reosarevok
Maybe it was actually up to date
18:15 PM
As I said, it's confusing
18:16 PM
bitmap
I was going to deploy derat's patch to beta. should I just skip translations then?
18:16 PM
besides updating pot files
18:19 PM
reosarevok
Do it anyway, 6 hours ago is still new :)
18:34 PM
derat has quit
18:38 PM
Lotheric__ joined the channel
18:41 PM
Lotheric_ has quit
18:52 PM
bitmap
ok, updating beta
19:02 PM
done
19:59 PM
BrainzGit
20:12 PM
Attila46 has quit
21:00 PM
Kladky has quit
21:23 PM
lusciouslover has quit
21:24 PM
lusciouslover joined the channel
21:48 PM
yvanzo
bitmap: I’m around now.
21:53 PM
lucifer: what would be the expected goal of this meeting?
21:54 PM
atj: no because the entities that have been removed in the meantime would still be present in search indexes.
21:57 PM
zerodogg has quit
22:07 PM
zas
22:07 PM
BrainzBot
MBS-13559: Bandcamp URL not recognized as Bandcamp URL
22:41 PM
zerodogg joined the channel