I guess there's no reason that *must* happen at schema change time anyway?
yvanzo
it's happening all the time
bitmap
yes, we can add running RebuildIndexesUsingCollations.pl to the upgrade notes anyway
reosarevok
Ok, dropped for now
Can always re-add if you find time for it
yvanzo
reosarevok: "happen" I was thinking of the bug though.
reosarevok
yeah I guessed :)
Did you have any luck with figuring out why?
yvanzo
No I mean the bug related to collation.
reosarevok
Aaaaah
I guessed wrong :D
But we can still add it ASAP after the schema change and it should be fine, right?
I'm preparing the schema change blog post but after that I could test things as needed
For whatever is useful to you two :)
yvanzo
No that would be another schema change, what bitmap suggested is to keep adding a manual step to upgrade notes instead if he doesn't find the time for it.
We don't seem to have the equivalent to "The main steps you need to follow in this case are running the 20200518-pg12-before-upgrade.sql and 20200518-pg12-after-upgrade.sql scripts in that order" ?
yvanzo
that's almost the same situation, plus the solr data has to be rebuilt from scratch
correct, we don't have any additional scripts this time
reosarevok
So just install packages and pg_upgradecluster ?
yvanzo
do you mean one-off scripts?
bitmap
yeah, the *before-upgrade.sql and *after-upgrade.sql scripts from the v12 one
we needed those because the pg_upgrade wouldn't work unless we dropped some things first
Tarun_0x0 has quit
yvanzo
bitmap: The Docker issue seems to be that `carton` is run from another directory than `musicbrainz-server`. Did you encounter this before? `PERL_CARTON_PATH` seems to be for installed modules, not for `cpanfile`.
bitmap
yvanzo: I'm not sure I ever attempted to run it outside of the musicbrainz-server dir, tbh
bitmap: Ok, so we just need to give the full path of dump files instead of running from their directory, right?
bitmap
yvanzo: yeah, I'm not sure there's a way to override that
reosarevok
bitmap: at what part of the schema upgrade sequence should we upgrade psql? At the start? I guess it does matter since some new code uses psql16 stuff
So maybe between
Turn off cron jobs if you’re automatically updating the database via cron jobs.
and
Switch to the new code with git fetch origin followed by git checkout v-2024-05-13-schema-change.
?
bitmap
sounds right
reosarevok
bitmap: apt-get update && apt-get install postgresql-16 postgresql-server-dev-16 should still work like for 12 last time or has anything changed? I see the PGDG repo seems to still work and have 16
bitmap
yvanzo: apparently a path to the cpanfile can be specified with PERL_CARTON_CPANFILE
reosarevok
(similarly, do we still need pg_dropcluster --stop 16 main)
bitmap
the (newer) version of carton we use isn't on metacpan for some reason
yvanzo
Thanks, I already modified the script to use full path for dump files though.
I couldn’t file any documentation mentioning this variable either.
bitmap
yeah, it's only in the changelog for v0.9.63
reosarevok: I haven't checked but have no reason to think it still wouldn't automatically create a default cluster