[musicbrainz-android] 14dependabot[bot] opened pull request #214 (03master…dependabot/gradle/androidx.lifecycle-lifecycle-runtime-ktx-2.6.0): Bump androidx.lifecycle:lifecycle-runtime-ktx from 2.5.1 to 2.6.0 https://github.com/metabrainz/musicbrainz-andro...
akshaaatt
Noice
BrainzGit
[musicbrainz-android] 14dependabot[bot] closed pull request #208 (03master…dependabot/gradle/androidx.compose.material3-material3-1.1.0-alpha07): Bump androidx.compose.material3:material3 from 1.1.0-alpha03 to 1.1.0-alpha07 https://github.com/metabrainz/musicbrainz-andro...
[musicbrainz-android] 14dependabot[bot] opened pull request #215 (03master…dependabot/gradle/androidx.navigation-navigation-compose-2.6.0-alpha07): Bump androidx.navigation:navigation-compose from 2.6.0-alpha04 to 2.6.0-alpha07 https://github.com/metabrainz/musicbrainz-andro...
[musicbrainz-android] 14dependabot[bot] closed pull request #211 (03master…dependabot/gradle/androidx.navigation-navigation-compose-2.6.0-alpha06): Bump androidx.navigation:navigation-compose from 2.6.0-alpha04 to 2.6.0-alpha06 https://github.com/metabrainz/musicbrainz-andro...
[musicbrainz-android] 14dependabot[bot] opened pull request #217 (03master…dependabot/gradle/androidx.lifecycle-lifecycle-viewmodel-ktx-2.6.0): Bump androidx.lifecycle:lifecycle-viewmodel-ktx from 2.5.1 to 2.6.0 https://github.com/metabrainz/musicbrainz-andro...
[musicbrainz-android] 14dependabot[bot] opened pull request #213 (03master…dependabot/gradle/androidx.compose.material3-material3-1.1.0-alpha08): Bump androidx.compose.material3:material3 from 1.1.0-alpha03 to 1.1.0-alpha08 https://github.com/metabrainz/musicbrainz-andro...
[musicbrainz-android] 14dependabot[bot] opened pull request #218 (03master…dependabot/gradle/androidx.compose.material3-material3-window-size-class-1.1.0-alpha08): Bump androidx.compose.material3:material3-window-size-class from 1.1.0-alpha03 to 1.1.0-alpha08 https://github.com/metabrainz/musicbrainz-andro...
reosarevok
bitmap: ok, thanks. I guess we could add some sort of test for this to t/script/DumpJSON.t
BrainzGit
[musicbrainz-android] 14dependabot[bot] closed pull request #205 (03master…dependabot/gradle/androidx.compose.material3-material3-window-size-class-1.1.0-alpha07): Bump androidx.compose.material3:material3-window-size-class from 1.1.0-alpha03 to 1.1.0-alpha07 https://github.com/metabrainz/musicbrainz-andro...
[musicbrainz-android] 14dependabot[bot] opened pull request #216 (03master…dependabot/gradle/androidx.recyclerview-recyclerview-1.3.0): Bump androidx.recyclerview:recyclerview from 1.2.1 to 1.3.0 https://github.com/metabrainz/musicbrainz-andro...
santiagofn has left the channel
[musicbrainz-android] 14dependabot[bot] opened pull request #219 (03master…dependabot/gradle/androidx.lifecycle-lifecycle-viewmodel-compose-2.6.0): Bump androidx.lifecycle:lifecycle-viewmodel-compose from 2.5.1 to 2.6.0 https://github.com/metabrainz/musicbrainz-andro...
[musicbrainz-android] 14dependabot[bot] opened pull request #220 (03master…dependabot/gradle/androidx.lifecycle-lifecycle-livedata-ktx-2.6.0): Bump androidx.lifecycle:lifecycle-livedata-ktx from 2.5.1 to 2.6.0 https://github.com/metabrainz/musicbrainz-andro...
akshaaatt
Guess it’s time to disable dependabot from MB android repo…
jasje
xD
feels like when i paste image paths
akshaaatt
Horrifying
jasje
alright then i better get on with toms exam :)
jasje has quit
akshaaatt
All the best jasje!
genpaku has quit
genpaku joined the channel
ShivamAwasthi has quit
reosarevok
bitmap: I'm guessing adding this to DumpJSON.t would work?
(I have never touched this file-checking kind of code...)
And is there a trivial way to just making sure files COPYING-PublicDomain and COPYING-CCShareAlike exist without actually having to read them? Or maybe I should read them and check if they contain the heading at least...
pbryan: i mean that's not great, but the report contains very little detail. i'm sure lots of people have their github account mistakenly suspended every day.
reosarevok
Yeah, I'd wait and see what comes of this
atj
and to be frank, GitHub provides a huge amount of features such as actions and free CI, and maintaining a self-hosted solution for a reasonably large project like MeB would take a lot of work.
[listenbrainz-android] 14dependabot[bot] opened pull request #90 (03main…dependabot/gradle/androidx.compose.material3-material3-window-size-class-1.1.0-alpha08): Bump androidx.compose.material3:material3-window-size-class from 1.1.0-alpha03 to 1.1.0-alpha08 https://github.com/metabrainz/listenbrainz-andr...
[listenbrainz-android] 14dependabot[bot] closed pull request #73 (03main…dependabot/gradle/androidx.compose.material3-material3-window-size-class-1.1.0-alpha07): Bump androidx.compose.material3:material3-window-size-class from 1.1.0-alpha03 to 1.1.0-alpha07 https://github.com/metabrainz/listenbrainz-andr...
[listenbrainz-android] 14dependabot[bot] opened pull request #92 (03main…dependabot/gradle/androidx.compose.material3-material3-1.1.0-alpha08): Bump androidx.compose.material3:material3 from 1.1.0-alpha03 to 1.1.0-alpha08 https://github.com/metabrainz/listenbrainz-andr...
[listenbrainz-android] 14dependabot[bot] opened pull request #93 (03main…dependabot/github_actions/actions/github-script-6): Bump actions/github-script from 4 to 6 https://github.com/metabrainz/listenbrainz-andr...
[listenbrainz-android] 14dependabot[bot] closed pull request #68 (03main…dependabot/gradle/androidx.compose.material3-material3-1.1.0-alpha07): Bump androidx.compose.material3:material3 from 1.1.0-alpha03 to 1.1.0-alpha07 https://github.com/metabrainz/listenbrainz-andr...
atj
whilst I have no say in the matter, I think GH would need to do something much more heinous to prompt a move to a self-hosted solution.
BrainzGit
[listenbrainz-android] 14dependabot[bot] opened pull request #94 (03main…dependabot/github_actions/actions/upload-artifact-3): Bump actions/upload-artifact from 2 to 3 https://github.com/metabrainz/listenbrainz-andr...
pbryan
I agree about the GH value proposition. I continue to be concerned about their apparent lack of transparency.
bitmap: do I get it correctly that your suggestion is to have nothing on root/static/scripts/common/utility/privileges.js (only in root/utility/edit.js)
But keeping "may_vote" under lib/MusicBrainz/Server/Entity/Editor.pm in Perl, just renamed?
bitmap
reosarevok: iirc yes, though I wasn't concerned with what names are used that much, just that the js and perl use the same names for the same things
if you prefer to keep the function in privileges.js and have it check the email that's fine with me
akshaaatt
jasje add `org.gradle.unsafe.configuration-cache=true` to your gradle.properties and then build the project :)
bitmap
but I'd remove editorMayVote entirely in that case
only reason I suggested otherwise is because that file only checks the privileges property rn, as you said, so might be weird?
reosarevok
Yeah
akshaaatt
jasje you can just keep it `org.gradle.configuration-cache=true`
BrainzGit
[listenbrainz-android] 14akshaaatt merged pull request #94 (03main…dependabot/github_actions/actions/upload-artifact-3): Bump actions/upload-artifact from 2 to 3 https://github.com/metabrainz/listenbrainz-andr...
[listenbrainz-android] 14akshaaatt merged pull request #93 (03main…dependabot/github_actions/actions/github-script-6): Bump actions/github-script from 4 to 6 https://github.com/metabrainz/listenbrainz-andr...
akshaaatt: but not so sure about it because android studio itself shows this feature experimental
so people using different android studio version might face probs idk i saw an issue back then
akshaaatt
Yeah, not gonna push it to the repo
Devs can use it locally though if they like
jasje
no no do it :devil-face:
build very fast
me very likey
akshaaatt
I could add it to the repo and explicitly remove it via the workflows when making a release
jasje
github magic is something thats on my todo list
someday phew
reosarevok
<BANG>
It's Monday again
So, welcome to another of our "What's everyone up to" parties!
mayhem_, who is traveling right now, said:
Last week I worked on the troi artist radio feature and the datasets page. Once Alastair finishes the mlhd+ set, we can release those pages.
Also discussions of UX revamp with monkey as well as various gsoc tasks and then the MeB background nonsense kept me busy.
I will be traveling until the 24th, but it is a working vacation, so I'll still be online a lot.
No other mailed reviews :)
My list for today is reosarevok, bitmap, zas, yvanzo, monkey, lucifer, akshaaatt, atj, aerozol, CatQuest, Pratha-Fish, riksucks, jasje, jivte, kellnerd
akshaaatt: wanna start?
akshaaatt
Hi Everyone!
I added Youtube music support to the LB android app and attempted to work with amazon music and apple music as well
Both amazon and apple are doable but will require some extra efforts
I’m planning to drop it because spotify+youtube might actually be it for us when it comes to streaming our listens on the app
Other than, lots of PR reviews and fiddling around with github stuff
Fin. Go bitmap!
aerozol
Interesting! Extra effort in terms of code, or getting them to let us use their stuff?
akshaaatt
Code
aerozol
Gotcha
reosarevok
If bitmap needs a bit of time, maybe aerozol can go?
aerozol
Mōrena!
This week I tidied up the Fresh Release mockups, bringing everything up to date and adding some stuff (mouse over/drag interactions, what happens when there’s no releases, etc): https://www.figma.com/file/YRbCOtFHBez8XmMdCKbG...
Worked on the mobile navigation and subnavigation with monkey, getting there!
Got sucked into some more MB styleguide stuff, cool to see stuff happening there (even if it takes ages)
That’s it for bigger stuff, go atj!
atj
thanks aerozol
bitmap
(I'm also here, sorry for the delay earlier)
reosarevok
Left on my list are reosarevok, bitmap, zas, yvanzo, monkey, lucifer, CatQuest, Pratha-Fish, riksucks, jasje, jivte, kellnerd
atj
I carried on working on the ansible roles for borg and borgmatic this week. This mainly involved reading up on how the applications worked and also thinking about how best to orchestrate initialistion/configuration of remote backup repositories in a secure and usable way.
*initialisation
that's it, bitmap?
bitmap
hello
last week I finished the Flow upgrade in musicbrainz-server to 0.201.0, had a meeting about entity type naming and contributed to https://github.com/metabrainz/musicbrainz-serve..., and started working on MBS-12976