That's why we need to indicate the difference in a clearer way (and having the icon allows for a link to the edits, which is useful)
CatQuest
oh!
reosarevok
So adding an icon is probably happening, just not sure which :)
CatQuest
how about an orange exlamation mark instead
like "oh! notice, this entity already has open edits on it"
somewhat like if you're doing something that clashs with osmething it wil give an red exlamation to wanr you, an orange will be like "oh btu already we have dits"
MBS-12942: Consider indicating pending edits for an entity in the relationship editor
CatQuest
we already did this aages ago in.. pre ngs iirc, howwe did it then?
aerozol
My pick atm is the clock, which was suggested by atj, but happy for more people to comment on the ticket
CatQuest
orange yellow for "is being edited/has pending" is established mb colour cannon imho fwiw
the pencil is deff a no-go
but i don't hate it for the edit icon :D
i'd liek "edit" as a flat button *better* but
TOPIC: [MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | BookBrainz: #bookbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda: Reviews, static.meb/LE (zas), Passkeys on @meb accounts (reosarevok)
wargreen has quit
wargreen joined the channel
mayhem
reosarevok: I've added a agenda item to let the team know that I've enabled passkeys for all metabrainz google accounts. I clearly won't be there for the topic, but all that needs to be communicated is that this is an option for the team. people can read more here: https://support.google.com/accounts/answer/1354...
so, if you could please handle that topic for me, great!
reosarevok
Sure
mayhem
thx
lucifer
monkey: i pushed the fix. and fixed a couple of other small bugs i had noticed.
bugs in the created for and the playlist card selection.
aerozol
Night all! I check back on all pings btw, if you have thoughts on anything discussed in the last couple of hours
Hi, I'm having problems downloading my listens from listenbrainz, it keeps killing the download at 10MB and the json is corrupt. I tried emailing and posting on matrix, hoping I have a more fruitful time here
mayhem
hi codified!
codified
Hi Mayhem :)
mayhem
sorry for not getting back to you -- its been a busy week and things kept interrupting.
codified
no worries perfectly understand
mayhem
my listens didn't export correctly either when I tried, but I hadn't gotten further to look at the problem yet.
let me take care of one more pressing thing, then I will look in more detail.
codified
For me it exits the generation at roughly 20%, it might be a memory issue
Appreciate your time
mayhem
it it probably a gateway timeout issue. the request takes longer than our gateways are willing to keep the connection open for.
codified
Could be that yes, my previous pulls were getting over 60MB
mayhem
codified: actually, you might try that. do a couple more exports and see how long they take to fail.
codified
Let me see
mayhem
shit, now there are two pressing things, lol
codified
Started: 15:42:31, End: 15:42:44, so roughly over 10 seconds, 10.33MB pulled
I'm not in a rush, I just wanted someone other than me to be aware of it :)
mayhem
the server logs are not showing anything abnormal.
codified
oh dear
Maybe it's in the generator then?
mayhem
atj: zas: is there a gateway timeout that might interrupt long loading pages?
the LB download your listens page take a while to generate its output, and I fear the gateways are closing the connection before the page is fully done.
codified
Especially with listens my size
couple of years worth
atj
mayhem: currently 150s
mayhem
thanks. then that is not it.
my listens (and more than just a couple of years worth) download fine and are consistent. (same md5sum)
codified
I thought it could be specific to mine, maybe an unhandled character, it ends at the same point each time if I don't listen to more in the meantime
mayhem
it may very well be that.
but I would expect to see an error in the logs in that case.
and if that was the case, it would always error in the same place.
codified
I agree but if it's unhandled, no telling
mayhem
lucifer: any ideas?
mayhem has to do a final review on a unicorn
let me take care of the critical tasks and I'll get back to you codified
codified
THanks for your time Mayhem!!
codified has quit
lucifer
atj: as long as some data is sent over http, the connection won't be close right? like downloading a large file which can take longer than 150s.
mayhem: i don't have much idea. it does fail for me as well but that didn't use to be the case. we should probably revamp it to a background process either way.
mayhem
I had one export fail as well, so its flaky, for sure.
but the background task is real bear to deal with.
lucifer
yup well :/
atj
lucifer: these timeouts are at the TCP level as opposed to HTTP, so my assumption is that if data is flowing the timeout will not be triggered
lucifer
atj: makes sense
atj
if you want to debug this further my suggestion would be to use developer tools and look at how old the connection is when it fails. if it's consistent close to a round number then that suggests a timeout somewhere in the stack
mayhem
dev tools gave me no useful information, atj
atj
did you see the request timeout?
mayhem
no, each time I tried it, it worked fine.
which makes sense I guess.
mayhem has quit
mayhem joined the channel
ijc has left the channel
bitmap
CatQuest: sorry I meant to look into that sooner, I'll check it out today
v6lur joined the channel
mayhem
reosarevok: let me go first, plz
CatQuest
bitmap: no prob
monkey
Thanks for the bug fixes lucifer !
reosarevok
<BANG>
CatQuest
:D
reosarevok
It is Monday. That means you get to put up with me again
mayhem
joy!!
reosarevok
We have two mailed in reviews today:
yvanzo says:
'''
Last week I helped with zas-driven maintenance operations around Consul & RabbitMQ.
Reviewed some MBS PRs and worked on docker server configs.
Progressed in Weblate with outsidecontext, rdswift and reosarevok but ended up investigating CAA issues.
I won’t have anything to report on the 19th.
'''
(yvanzo is on holiday this week and hopefully he's enjoying it!)
aerozol says:
'''
CatQuest
happy holiday yvanzo !
reosarevok
Winter’s setting in and I’ve slowed to a crawl around our poorly insulated house. Drinking lots of hot chocolates to try prepare for hibernation.
I did some comms stuff, tackled a bunch of smaller tickets, none of which are exciting enough to link to imo.
Back to you Reo
Thanks aerozol. I don’t say this enough, but you really are the backbone of MeB. And probably our entire civilization, now that I think about it.
!m aerozol
BrainzBot
You're doing good work, aerozol!
reosarevok
'''
Sophist_UK joined the channel
I saw what he did there, but it's ok, someone needs to say good things to him while he sleeps so he's happy in the morning, it might as well be fake me
monkey
:D
CatQuest
:D
reosarevok
So
Sophist-UK has quit
On with actual humans who are actually present, and mayhem asked to go first
mayhem
oy!
reosarevok
(yvanzo, aerozol: did not mean to imply you're not actual humans)
go mayhem :)
mayhem
last week I reviewed some contracts and did the usual background emails.
and we have a new unicorn supporter, but not all details are ironed out yet, I'll announce the company tomorrow.
I also worked with our accountant go once again conclude that quickbooks sucks.
monkey
🎉 🦄
mayhem
and her fix made me shudder. if we engineered like that, the internet wouldn't work. at all.
srsly.
I also worked on troi to generated recs for all users only to realize that it must be done in spark.
so lucifer replace the periodic-jams patch with 12 lines of SQL.
humbled!
over the weekend I worked on the lb-radio (was artist-radio) which was a fun change, but things are so busy right now, that I can only work on it in my spare time.
Sophist_UK has quit
there were lots more things last week, but Imma shut up now.
monkey: go!
reosarevok
Other people on my list today: reosarevok, bitmap, zas, lucifer, akshaaatt, atj, CatQuest, riksucks, jivte, kellnerd, Pratha-Fish, shivam_, vscode, pixelpenguin, arsh, jasje
Also pushed some PRs along an did some ticket triage
On the BookBrainz side I've been working on some old PRs that I really want to see merged
So lots of reviewing and working on finishing them up
And a little bit of GSoC discussions. That's me !
akshaaatt: go !
Oh, also helped beta testing the LB android app :)
akshaaatt
Hi everyone!
I reviewed lots of PRs, completed the realtime listening now on the android app and other misc stuff
We should be doing a final beta soon for next prod release
That’s pretty much it for now. Great stuff upcoming!
Go lucifer!
lucifer
hey all
vardan joined the channel
last week, i worked on adding the bulk-generation of playlists on spark, some more work on meb-oauth and some additions to the android app (login workaround and websockets for now playing).
