like moving data over from MB db to MeB db, and choosing which db the current application is from and validating against the correct db.
mayhem
I guess the main point there is that we actually finish the transition after we kick it off. :)
lucifer
people will probably want existing users to not need to reauth after migrating stuff.
mayhem
ideal, but if we can't do it without a huge hassle, then be it.
lucifer
but i think we might just want to do that. because otherwise we will have to also consider the security implications which can be subtle and easy to miss.
yeah
mayhem
if you think its more secure to re-auth, then lets do that.
akshaaatt (IRC): so I’ll start work on artist and album pages in brainzplayer along with cleanup and play button bugs?
monkey[m]
Honestly I quite like it huhridge (IRC) . I think if you import it from "@fortawesome/free-regular-svg-icons" rather than "free-solid-..." it will look even better, not as dark
huhridge
monkey: looks good to me as well, solid looks better to me tho
huhridge (IRC): I have a follow-up PR if you don't mind :D I forgot to test the component while not logged in.
If I'm not logged in it shouldn't show the component or run the similarity + similar artists fetching. Try the page in incognito mode, currently it compares to the global stats
MBS-13549: Track numbers of certain recording-recording relationships are wrongly displayed on release pages when both sides of the relationship are on the same release.
huhridge
monkey: what is the currentUser when a user is not logged in? it's not empty it seems
cause we added the !currentUser check
monkey[m]
Right, I think you have to check for the presence of currentUser.name , forgot about that
!currentUser?.name
huhridge
oh isNil and isEmpty from loadsh are being used somewhere, they should work right?
monkey[m]
yes
huhridge
cool, adding those rn! i'll have to open a new pr right>
monkey[m]
Yep
Maybe pull the recent changes to your master branch and start a new branch
huhridge
will do that
bitmap
yvanzo: regarding https://github.com/metabrainz/musicbrainz-serve... it's true that carton requires those, but I thought the previous changes would mount the files before carton is invoked. can you help me understand why it didn't work?
yvanzo
bitmap: it seems that carton needs it at runtime too.
bitmap
ah, I don't think I knew that!
zas
bitmap, yvanzo: there's a huge slowdown on mb website right now
bitmap: I also had to specify installing the `git` package to run `po/Makefile`, it was probably installed for something else and not cleaned up beforehand: https://github.com/metabrainz/musicbrainz-serve...
huhridge has quit
bitmap
ah yeah, I think it's also needed to generate the GIT_* DBDefs values
<05rustynova> Just a quick question. Does brainz player look at a recording's link to play the correct video?
adhawkins joined the channel
monkey[m]
rustynova: on the LB website you mean? It does not currently
BrainzGit
[musicbrainz-docker] 14yvanzo opened pull request #276 (03schema-change-2024-q2…perl5dot38): MBS-13358 (III): Upgrade Perl version to 5.38.2 for mirrors https://github.com/metabrainz/musicbrainz-docke...
yvanzo
bitmap: Fortunately, only the website container is using GIT_* DBDefs values (and script/git_info).
We should probably define those as env variables for all containers rather than installing git.
Actually, those are already defined as env vars in Docker images. 😌
bitmap
right, I was trying to remember how that was handled. yes, apparently they're set in the Makefile (via the git_info script) and passed to the Dockerfile that way
pranav[m] has quit
lucifer: forgot to ping you but I deployed your patch to test.mb earlier