16:51 PM
lucifer
`git checkout -b <new branch name> master` this will create a new branch from master
16:52 PM
then `git checkout master`, `git reset origin/master --hard`
16:52 PM
akshaaatt[m]
<lucifer "then `git checkout master`, `git"> This I understand
16:52 PM
<lucifer "`git checkout -b <new branch nam"> With this, how do I make a PR of that branch now?
16:53 PM
Since the branch just exists that way. The commits won't be highlighted?
16:53 PM
lucifer
just push to you github fork and open a repo.
16:53 PM
*open a PR
16:53 PM
i didn't understand your query.
16:55 PM
akshaaatt[m]
Oh! I always commit first and then push so I was confused of what to do next. As you told, I can directly push now hah!
16:57 PM
outsidecontext: Amazing work you did all these years back!
16:59 PM
I will now just extract the Client to the MB App and make the necessary changes. Other than this a PR to your app has also been made.
17:01 PM
Tbh your app was straightforward as is. No boilerplate code. Everything is useful for us straightaway
17:07 PM
outsidecontext: Should we add a callback feature to the app from Picard?
17:08 PM
diru1100 has quit
17:09 PM
outsidecontext
akshaaatt[m]: how exactly do you mean?
17:10 PM
akshaaatt[m]
Like after the file is properly tagged there, the app displays it?
17:10 PM
But we are doing this on the tagger already
17:10 PM
So yeah we can do it from the app's client already
17:12 PM
outsidecontext
Ah, I wouldn't do such callbacks in this direction for now
17:12 PM
akshaaatt[m]
<outsidecontext "lucifer, akshaaatt: btw, I'd lik"> Okay if it's just the sending part, I'll add it asap
17:13 PM
outsidecontext
Cool
17:15 PM
jasondk
monkey: Hi! I'm working on the pin recording popup modal for LB, could i run it by you and get your suggestions on how to improve the UI?
17:16 PM
monkey
Sure, shoot !
17:17 PM
jasondk
17:18 PM
(Its very similar to the new report user modal)
17:18 PM
In my mockup I had the listenbrainz logo and the "Pin This Recording to Your Profile" heading centered at the top, what do you think?
17:19 PM
monkey
Looks pretty good ! I would suggest a couple of changes with the wording (maybe in a PR review?), but nothing major.
17:20 PM
jasondk
Okie great. Thanks!
17:20 PM
monkey
I think we should standardize on one look for the modals. I think this looks fine for now; perhaps you'll be interested in making a reusable modal component with the logo and and modified header
17:20 PM
But I don't see that as a priority
17:21 PM
jasondk
Yeah, makes sense
17:21 PM
monkey
One small thing: I think we use green buttons for this type of user actions
17:21 PM
(for the Pin button)
17:21 PM
akshaaatt[m]
outsidecontext: what does the url "http://%s:%d/openalbum?id=%s" signify?
17:22 PM
jasondk
I'll change it to green :)
17:24 PM
outsidecontext
Picard is listening there. So you'll need local ip of the desktop. Port usually is 8000, but is displayed in Picard window. id is a release MBID
17:25 PM
akshaaatt[m]
Right!
17:25 PM
So in the app even we'll have to add a setting where the user can add their IP and the port
17:26 PM
outsidecontext
17:26 PM
With an actual MBID of course
17:26 PM
Yes, exactly, this needs to be configurable
17:26 PM
akshaaatt[m]
Understood
17:27 PM
Coool!
17:28 PM
outsidecontext
You can also make a request to just / to check if Picard is listening
17:29 PM
The answers changed a bit in Picard 2.6, though. Earlier versions always answered to all requests with the same text "Nothing to see here"
17:29 PM
BrainzGit joined the channel
17:29 PM
Newer return JSON results
17:30 PM
akshaaatt[m]
Niceee!
17:45 PM
samthursfield has quit
17:46 PM
samthursfield joined the channel
17:54 PM
legoktm is now known as l5m
17:55 PM
l5m is now known as legoktm
18:05 PM
lucifer
ruaok: gaga seems to be overloaded
18:06 PM
ruaok
Oh oh. That doesn't seems good.
18:06 PM
I'm not near a computer. Can you try and log in and stop the mbid writer?
18:06 PM
lucifer
đź‘Ť
18:06 PM
this one right listenbrainz-mbid-mapping-writer-prod
18:08 PM
bad question, it had mbid writer in its name :p
18:08 PM
18:09 PM
i stopped mbid writer but doesn't look its going down.
18:10 PM
typesense seems to be the culprit, should i restart or stop it?
18:15 PM
yeah this is bad typesense consuming 99% cpu and still not going down after stopping mbid writer.
18:18 PM
ruaok
Then kill typesense.
18:18 PM
I just upgraded to a new version, maybe that was bad.
18:19 PM
lucifer
but its been some time since the upgrade?
18:20 PM
i have stopped typesense, load is coming down.
18:20 PM
took a look at the logs, weren't much helpful.
18:22 PM
also the mbid writer started doing 2019 again? it was in 2018 yesterday.
18:23 PM
ruaok: uh oh! lb went down.
18:24 PM
lb depends on typesense, consul stopped it.
18:26 PM
ruaok
Oh crap.
18:26 PM
lucifer
brought back up typesense. monitoring it.
18:27 PM
meanwhile opening a PR in LB to remove typesense temporarily from consul config.
18:27 PM
ruaok
If the writer is off, typesense should not freak out.
18:27 PM
lucifer
only labs uses it methinks. hopefully can live without it for a day?
18:27 PM
yeah writer is off.
18:27 PM
ruaok
If it does, then labs is being hit by someone.
18:27 PM
I need to add rate limiting to labs.
18:28 PM
lucifer
currently typesense usage is at 12% (avg of all cpus)
18:28 PM
ruaok
If typesense is offline, no one can add tracks to playlists. Which is not a serious problem.
18:29 PM
lucifer
in some hours, timescale will try to refresh aggregates at which hell can break loose if typesense is acting up as well.
18:29 PM
ruaok
If typesense keeps misbehaving, please change the lb config to not depend on it anymore and shut it down. I'll look at it tomorrow.
18:29 PM
lucifer
yeah, i am opening that pr anyways in case we need it urgently.
18:30 PM
ruaok
Yeah typesense acting up is not acceptable at all.
18:30 PM
lucifer
i'll also build and push an image so we can respond swiftly.
18:30 PM
ruaok
Thanks!
18:30 PM
lucifer
np :D
18:34 PM
its time to priortise LB-878
18:34 PM
BrainzBot
18:51 PM
BrainzGit
18:52 PM
akshaaatt[m]
outsidecontext: All done :) You are really gonna like this
19:13 PM
lucifer
19:14 PM
tl,dr; stop all lb containers then bring back up with no-typesense image.
19:14 PM
in case i am not around and typesense needs to be stopped.
19:17 PM
>Concurrency improvements: utilize all CPU cores and scale to hundreds of thousands of collections
19:17 PM
đź‘€
19:22 PM
akshaaatt[m]
lucifer: still up?
19:22 PM
lucifer
akshaaatt[m]: yes
19:23 PM
akshaaatt[m]
So I just had a doubt about saving in the sharedprefs using the method we use
19:24 PM
I have added 2 preference categories in the settings xml
19:24 PM
preferences xml*
19:24 PM
They are editable. Just the same way we save the Listen Token
19:24 PM
But I don't think I am able to save them
19:25 PM
After hitting okay
19:25 PM
Where do I add the code for saving the edit text received to the sharedpref?
19:27 PM
I think I am hitting the same problem we had even with the Listen token
19:27 PM
lucifer
i don't think you need to add anything. the preferences fragment handles that
19:27 PM
anything in logs?
19:29 PM
akshaaatt[m]
Hmm it does seem to work
19:29 PM
But not when I need it
19:29 PM
lucifer
lol
19:29 PM
what's the issue you are facing, lb token is saved but your properties aren't?
19:30 PM
akshaaatt[m]
And that's a wrap!
19:31 PM
Something on the terms of saving string instead of int worked lol
19:31 PM
What outsidecontext proposed for has been added and it looks really cool.
19:31 PM
lucifer
ah strange
19:32 PM
akshaaatt[m]
Reminded me of the days spent doing IoT projects
19:32 PM
lucifer
19:32 PM
nice, looking forward to it :D
19:33 PM
akshaaatt[m]
I can't believe the things we are doing with the MB app. It can be such a solid representation of all our massive products
19:35 PM
lucifer
19:35 PM
that one is getting too big to review :)
19:35 PM
akshaaatt[m]
🤓
19:36 PM
lucifer
just checkout a new branch from this one and open a new PR for now. it will contain changes from both but will settle out later once we merge the first PR.
19:36 PM
akshaaatt[m]
Okaay!
19:37 PM
lucifer
once that's done, you can remove the latest commit from the old PR.
19:39 PM
BrainzGit
19:40 PM
lucifer
thanks! :D
19:45 PM
yvanzo
lucifer: MOBILE-61 has been reported three times this time already.
19:45 PM
BrainzBot
19:47 PM
lucifer
yvanzo: oh! i didn't see those tickets. thanks! i had already pushed the fix, i'll comment on the ticket as well.
19:48 PM
yvanzo
s/this time/this week/
19:49 PM
Thank you and good night! :)
19:49 PM
lucifer
good night :D
19:55 PM
akashgp09 has quit