#metabrainz

O’Moin

If anyone has any cravings for Indian food, please let me know for the summit

zas: good morning. would you have time to look into https://tickets.metabrainz.org/browse/PICARD-2700 this week? I'll try to go after the crashes reported on Windows on exit.

PICARD-2700: Content of series variables gets duplicated on each refresh

outsidecontext: yes, I guess we should write tests for that

that's great. I actually wonder whether refresh should always use a fresh "original" metadata copy or why this does not seem to happen already

hi

Hi!

Devarsh: hi!

did you find any ticket you'd like to work on?

not exactly, I went through few of them but dont know where to exactly begin, could you suggest anyone of them which u think i can resolve

which sort of tasks would you prefer to start with, frontend (react/typescript) or backend (flask/python)?

I'm okay with both honestly but since its my first time working in any open source proj, ig id prefer to start with frontend stuff

Devarsh: LB-1315 seems like a simple one.

LB-1315: Attempting to follow a user while not logged in gives error https://tickets.metabrainz.org/browse/LB-1315

open https://listenbrainz.org/user/troi-bot/ while you are logged out from LB or in incognito i guess

the button on the top left in this image is the follow button. if you press, there will be an error.

ok yea understood, will work on it(y)

you can setup the project locally using these instructions: https://listenbrainz.readthedocs.io/en/latest/d...

I think you'll need to fix it here: https://github.com/metabrainz/listenbrainz-serv...

(not sure but probably there)

if you have any other doubts regarding setup or the code or anything else, feel free to ask here

also, you can assign the ticket to yourself in JIRA so that someone else doesn't start working on it

yea done that, I'll setup and start with it asap, thanks for being so supportive:)

[musicbrainz-server] 14yvanzo opened pull request #3019 (03master…update-ui-languages): Update UI languages https://github.com/metabrainz/musicbrainz-serve...

[musicbrainz-docker] 14yvanzo opened pull request #253 (03master…update-ui-languages): Update UI languages https://github.com/metabrainz/musicbrainz-docke...

lucifer: Yeah, there's a weird issue with the test suite (again…) and indeed all tests pass but the process exits with an error. Will look into it.

monkey: i ran it locally and over 20 failed. so something weird indeed

On another note, mind if I deploy LB#2518 to test.lb or are you still testing the apple PR?

LB-1309: Implement stats art generator: https://github.com/metabrainz/listenbrainz-serv...

fine to deploy

👍

[musicbrainz-server] 14yvanzo opened pull request #3020 (03master…mauritania-flag): MBS-13240: Update Mauritania flag (changed in 2017) https://github.com/metabrainz/musicbrainz-serve...

outsidecontext: https://github.com/metabrainz/picard/pull/2287

[musicbrainz-server] 14yvanzo merged pull request #3019 (03master…update-ui-languages): Update UI languages https://github.com/metabrainz/musicbrainz-serve...

I'm not really happy about the patch, but can you check if it matches expectations regarding behavior? I added 2 test cases: one simulating the refresh (double loading), one loading new metadata with one series removed

[musicbrainz-server] 14yvanzo merged pull request #3020 (03master…mauritania-flag): MBS-13240: Update Mauritania flag (changed in 2017) https://github.com/metabrainz/musicbrainz-serve...

[musicbrainz-docker] 14yvanzo merged pull request #253 (03master…update-ui-languages): Update UI languages https://github.com/metabrainz/musicbrainz-docke...

[musicbrainz-server] 14derat opened pull request #3021 (03master…rec_align): MBS-13241: Prevent recording bubble from shifting. https://github.com/metabrainz/musicbrainz-serve...

zas: I think it matches expectations

But I still don't get why this is necessary at all. Wouldn't a refresh be expected to get the same result as a load and hence work on orig_metadata rather then metadata?

I haven't looked into the details of refresh loading yet, but this seems suspicious. Same issue might happen with other data as well

refresh doesn't actually reset the data, it is passed as key argument to force refreshing the json, but metadata isn't actually resetted it seems

for most tags it isn't an issue since they are replaced, but yes, that's weird

[musicbrainz-server] 14yvanzo merged pull request #3021 (03master…rec_align): MBS-13241: Prevent recording bubble from shifting. https://github.com/metabrainz/musicbrainz-serve...

zas: the conservative approach is of course to just make the series be reset before written as you attempted. maybe this is really the best for now. Resetting the entire object probably has some side effect we don't think about

[musicbrainz-server] 14derat opened pull request #3022 (03master…rec_padding): Add top padding to track/recording position and buttons. https://github.com/metabrainz/musicbrainz-serve...

[musicbrainz-server] 14yvanzo merged pull request #3022 (03master…rec_padding): MBS-13241 (hotfix): Add top padding to track/recording position and buttons. https://github.com/metabrainz/musicbrainz-serve...

yvanzo: ApeKattQuest asked if he can go early today

ops

Hi everyone!

Happy World Senior Citizen's Day!

Welcome to this weekly MetaBrainz meeting in the middle of the summer.

received two reviews sent by email. The first one comes from aerozol:

"""

Just the usual last week.

I’ve been keeping an eye on the socials for a while now and am comfortable - it would now take a negligible amount of my time to cross-post to and keep an eye on one or many alternatives to twitter (note: *not* channels like Tik-Tok or Instagram, which do better with unique content). Something for you all to ponder, I may raise it as a future meeting topic soon.

"""

He would certainly have added “reosarevok: Would you mind to continue?” to introduce the second and last mailed-in review:

"""

Hi! I'm currently in Spain, either waiting to board or on a plane, since my brother decided to get married. Thanks yvanzo for covering for me!

Last week I worked on more URL tickets (including autoselects for our new ticketing page relationship), I had meetings with Pratha-Fish and the MBS team, and I spent a lot of time dealing with vandals and spammers.

I'll be in Spain for the whole week, although I'll still keep an eye on emails and possibly also work on code a bit. I'll also have to miss the next meeting, so I'll see you all in two weeks.

"""

More email might have been sent to the wrong person this week, so check the meeting notes tomorrow if you are missing them: https://community.metabrainz.org/tag/metabrainz...

People up for reviews: ApeKattQuest, monkey, pixelpenguin, mayhem, kellnerd, bitmap, atj, Pratha-Fish, akshaaatt, ShivamAwasthi, lucifer, arsh, zas, jasje, yvanzo. If other people want to share their own reviews, please let me know directly ASAP.

ApeKattQuest: It seems that you are starting with our real-time reviews ^ :)

Arararara~! hi!

thanks yvanzo!

we did a lot of instrument images, working on updating the instruments and adding descriptions♌

fin, go Pratha-Fish 🐟

Hi all!

Yesterday was my birthday :))

happy belated birthday Pratha-Fish !!

🎉congrats!🎊

Happy birthday Pratha-Fish !

Happy birthday!

Congratulations ✨

Happy birthday fish!

happy belated birthday Pratha-Fish!

Happy birthday 🐟

Over the week, I spent some time fixing PR #4 on the musicbrainz-bot, and currently I am working on the ujpcoming PRs, as well as looking forward to wrapping up some with with the musicbraiz bot and moving ahead with the project!

🐟 🎂

Thankyou all for your warm wishes! ^_^ ❤️

Well, that's all for me for tday!

Fin 🐟

ApeKattQuest: would you like to go next? :)

Oh wait you've already gone havent you?

*loop detected*

arsh: would you like to do the honors?

Sure, thanks

Hi everyone

Last week I was finally able to integrate my project in the LB codebase

Had to do a few changes based on the reviews but everything is working fine now

I am just left with the MusicBrainz integration for my project and will be finishing it up by tomorrow

That's all from my side

People still up for reviews: monkey, pixelpenguin, mayhem, kellnerd, bitmap, atj, akshaaatt, ShivamAwasthi, lucifer, zas, jasje, yvanzo. If other people want to share their own reviews, please let me know directly ASAP.

go lucifer:

hi all!

last week, i mostly worked on PR reviews, GSoC discussions and testing.

that's it for me. monkey next?

Hello

Last week I finally had enough of our flaky deprecated testing framework (Enzyme) and decided to take the bull by the horns and start migrating to one that actually supports React 16+ (React Testing Library).


It went quite well at first, installing and converting one test file went pretty smoothly. I'm looking forward to using the better testing style it provides

However I'm hitting some more random failures and issues with Enzyme, having had to update our test runner Jest as well. Will figure out this week how to move forward on that front, but it might just require converting some more test files now rather than in follow-up PRs.

Apart from that, I worked on reviewing GSoC projects, as some of them are drawing to a close.

I also putzed around on some small LB design tickets and as usual reviewed some PRs

And that's me! zas your turn

Hey

People still up for reviews: vscode_, pixelpenguin, mayhem, kellnerd, bitmap, atj, akshaaatt, ShivamAwasthi, jasje, yvanzo. If other people want to share their own reviews, please let me know directly ASAP.