Pratha-Fish: Maybe Kingdom of the Netherlands has a different Wikidata ID in your dataset?
Pratha-Fish
kellnerd: thats what I thought first as well. But apparently they both have the same wikidata IDs!
kellnerd
š
But focus on your blog post before debugging this :)
Pratha-Fish
exactly
Considering time is of essence I think I'll quickly go ahead and submit the link on the GSoC portal to make sure I don't get owned by a š at the last moment šæ
kellnerd: since you're writing a draft at the same time, can you please check to make sure we don't share the same temporary permalink?
kellnerd
Nope, mine has a different number :)
Pratha-Fish sighs with relief
bitmap
the draft number is stable, just don't make any sudden movements
ApeKattQuest
GUESS WHAT BITCHS?!
my name is now legally "Akira"!
š\o/š
outsidecontext
ApeKattQuest: congratulations, Akira!
ApeKattQuest
:D
\o/
DjSlash has quit
DjSlash joined the channel
Pratha-Fish
ApeKattQuest: congratulations! That's a beautiful name for real š«¶
reosarevok: Never mind, it seems to require more work than I thought after I quickly tested it.
Pratha-Fish
thanks for sharing š
reosarevok
yvanzo: I see derat is actually looking into it, might be an easy fix, let's see :)
yvanzo
Yes, Iām positive that it will be ready for beta early enough this week. :)
Pratha-Fish
reosarevok bitmap: I have submitted the blog draft link, and I am currently working on finding some interesting insights from our data to be added in the blog :)
bitmap
i've only seen seven samurai but it was very good
Pratha-Fish
I was thinking of adding some interesting findings, charts, etc in the blog to drive the whole project home
bitmap
congrats ApeKattQuest!
ApeKattQuest
:D
bitmap
reosarevok: if we are merging derat's we might as well include the barcode one too?
Pratha-Fish
e.g. Countries with the most metadata available on MusicBrainz, countries with the most available data, countries that need more data, etc. Any ideas?
yvanzo
reosarevok: Donāt pay attention to Selenium random failures on #3076, itās unrelated.
reosarevok
I thought it was, thought I'd re-run just in case, but yeah, probably not worth it
bitmap: yeah, I was planning to, just not sure if some more stuff :)
yeah, the `var $voteOptions = ` assignment at the top seems to be where it clones and injects the overall-vote one. maybe you can try running that in the JS console and see why it's not finding anything...
relaxoMob has quit
derat
bitmap: thanks for the pointer! looking at root/edit/components/Vote.js, i suspect that editorMayVoteOnEdit() is returning false since these are all my own edits. when i comment that check out i get the radio buttons, which should be enough for me to look at the layout issue
relaxoMob joined the channel
bitmap
ah yes that must be it
kellnerd
Pratha-Fish: So much about "[Your work URL] can not be updated after you submit this form." on Google's site... I can still edit it after having finally pressed "Save & Submit". (So far I've only cautiosly pressed "Save draft".)
bitmap
I was connecting to our standby server when listing votes, so none were my own
listing edits*
relaxoMob has quit
Pratha-Fish
kellnerd: damn, didn't notice that one. I've saved and submitted š
iirc, even last year they gave option to edit submissions. Where does it say it's not allowed?
kellnerd
it's no problem, that's what I wanted to say.
relaxoMob joined the channel
It says it would not work, but in fact it does.
Pratha-Fish
Strange
kellnerd
> This will be shown in the archive and will be what you will use to point future employers, etc to the work you did. Be sure the URL is something not likely to change for at least 5-10 years. It can not be updated after you submit this form.
Pratha-Fish
They should make the GSoC website open source and let students work on it lol
kellnerd
Hehe
Pratha-Fish
Oh about that one. It's only valid AFTER the submission deadline is passed.
You can update and edit as many times as you like before the deadline :)
kellnerd
I thought hat, but wanted to be on the safe side by only savindg as draft :)
Especially surprised by Iran and Estonia to be ranking so high given their size.
Pratha-Fish side eyes reosarevok
kellnerd
Besides France and Estonia that looks plausible
derat
hah, this is happening because the overall-vote div is using the same "float: right" hack that my change was originally using to appear to the right of the paginator. any preferencesĀ re me updating overall-vote to use the align-right class vs. setting "clear: both" on the top button?
kellnerd
^ (Compared to the size of the country and the languages Wikipedia community that is)
yvanzo
reosarevok, bitmap: I guess "align-right" since it's already being used at the bottom?
kellnerd
Oh wait, these are in MB already Pratha-Fish?
Pratha-Fish
kellnerd: not yet :D
bitmap
that sounds reasonable if the bottom one is already making use of it
kellnerd
Ah, then my argument about the size of the Wikipedia community makes sense
to double-check/clarify, the bottom submit button is using align-right, and the top button that i'm adding is too. overall-vote is using "float: right". i could switch overall-vote to use align-right as well instead of float, but that'd take up some more space. if keeping overall-vote right of the paginator is desired, then i should probably just
set "clear: both" on the top button
yvanzo
derat: No problem with using it if it seems to be the best option :) try to keep it in CSS/LESS classes though.
bitmap
derat: clear: both looks good indeed
derat
great, thanks! just pushed the update
monkey
Good old `clear: both;`
derat
yep, brings back memories :-P
yvanzo
(No worry, the edits list layout will eventually be reworked anyway.)
appended this to the commit message: "It's currently set for edit searches involving a condition on the type of the relationship being edited (i.e., the \"Relationship Type\" predicate mentioned above)."
yvanzo
bitmap: Thank you for the extra explanations, it requires less neurons to understand which edit searches are affected by the patch :)
Welcome to another MetaBrainz night! The day length is barely 8 hours, send help.
ApeKattQuest
:D
yvanzo
help
reosarevok
I have one mailed in review, by aerozol:
mayhem
aw come on, programmers love the night.
reosarevok
'''
The usual comms, moderation, socials.
Design-wise it was mainly pulling together designs for YIM 2023 - it's not too late to feedback in the next day or so. But planning to finalize everything this week.