#metabrainz

kellnerd: thats strangeee. I wonder if it was added recently or something

Last updated on 2018-11-19 17:11 UTC - doesn't seem like it 🗿

bitmap: generated this one https://blog.metabrainz.org/?p=11035. Can you please check if it works on your end?

well, it doesn't work yet as it's not published

F

Pratha-Fish: Maybe Kingdom of the Netherlands has a different Wikidata ID in your dataset?

kellnerd: thats what I thought first as well. But apparently they both have the same wikidata IDs!

🐛

But focus on your blog post before debugging this :)

exactly

Considering time is of essence I think I'll quickly go ahead and submit the link on the GSoC portal to make sure I don't get owned by a 🐛 at the last moment 🗿

kellnerd: since you're writing a draft at the same time, can you please check to make sure we don't share the same temporary permalink?

Nope, mine has a different number :)

the draft number is stable, just don't make any sudden movements

GUESS WHAT BITCHS?!

my name is now legally "Akira"!

🎉\o/🎊

ApeKattQuest: congratulations, Akira!

:D

\o/

ApeKattQuest: congratulations! That's a beautiful name for real 🫶

reminds me of one of my favorite characters from my favorite Manga https://tokyoghoul.fandom.com/wiki/Akira_Mado

ApeKattQuest: congrats!

yvanzo, bitmap: anything else you want to merge before freeze? We can release one more beta or we can leave it as-is :)

reosarevok: derat's one

Ok, I haven't checked that one yet but I can take a quick look :)

Pratha-Fish: nngg. ok but it's from https://en.wikipedia.org/wiki/Akira_Kurosawa :)

reosarevok: :D

movis are up on internet archive: https://archive.org/details/sanshiro-sugata

https://archive.org/details/seven-samurai <-

yojimbo is cool https://archive.org/details/yojimbo_202012

reosarevok: Never mind, it seems to require more work than I thought after I quickly tested it.

thanks for sharing 😁

yvanzo: I see derat is actually looking into it, might be an easy fix, let's see :)

Yes, I’m positive that it will be ready for beta early enough this week. :)

reosarevok bitmap: I have submitted the blog draft link, and I am currently working on finding some interesting insights from our data to be added in the blog :)

i've only seen seven samurai but it was very good

I was thinking of adding some interesting findings, charts, etc in the blog to drive the whole project home

congrats ApeKattQuest!

:D

reosarevok: if we are merging derat's we might as well include the barcode one too?

e.g. Countries with the most metadata available on MusicBrainz, countries with the most available data, countries that need more data, etc. Any ideas?

reosarevok: Don’t pay attention to Selenium random failures on #3076, it’s unrelated.

I thought it was, thought I'd re-run just in case, but yeah, probably not worth it

bitmap: yeah, I was planning to, just not sure if some more stuff :)

Congratz ApeKattQuest that's big news!

[musicbrainz-server] 14reosarevok merged pull request #3076 (03master…MBS-13350): MBS-13350: Return all barcode matches in release editor https://github.com/metabrainz/musicbrainz-serve...

There's a couple more small newly reported things I could probably trivially fix, maybe I'll look into that while derat checks stuff

If you want to check more PRs too, I won't complain either :D

I’m going through PRs indeed :)

howdy. i'm looking at #3072, but having some trouble figuring out how to get the vote-on-all-edits radio buttons to actually show up

same

bitmap ^ did you disable your userscripts while testing?

I don't think I had any enabled for my dev server

derat: is there any class="voteopts" div in the source?

Here is the source code loading these buttons: https://github.com/metabrainz/musicbrainz-serve...

s/buttons/options/

yeah, the `var $voteOptions = ` assignment at the top seems to be where it clones and injects the overall-vote one. maybe you can try running that in the JS console and see why it's not finding anything...

bitmap: thanks for the pointer! looking at root/edit/components/Vote.js, i suspect that editorMayVoteOnEdit() is returning false since these are all my own edits. when i comment that check out i get the radio buttons, which should be enough for me to look at the layout issue

ah yes that must be it

Pratha-Fish: So much about "[Your work URL] can not be updated after you submit this form." on Google's site... I can still edit it after having finally pressed "Save & Submit". (So far I've only cautiosly pressed "Save draft".)

I was connecting to our standby server when listing votes, so none were my own

listing edits*

kellnerd: damn, didn't notice that one. I've saved and submitted 💀

iirc, even last year they gave option to edit submissions. Where does it say it's not allowed?

it's no problem, that's what I wanted to say.

It says it would not work, but in fact it does.

Strange

> This will be shown in the archive and will be what you will use to point future employers, etc to the work you did. Be sure the URL is something not likely to change for at least 5-10 years. It can not be updated after you submit this form.

They should make the GSoC website open source and let students work on it lol

Hehe

Oh about that one. It's only valid AFTER the submission deadline is passed.

You can update and edit as many times as you like before the deadline :)

I thought hat, but wanted to be on the safe side by only savindg as draft :)

Good choice :)

kinda surprising TBH https://usercontent.irccloud-cdn.com/file/rbm22...

Especially surprised by Iran and Estonia to be ranking so high given their size.

Besides France and Estonia that looks plausible

hah, this is happening because the overall-vote div is using the same "float: right" hack that my change was originally using to appear to the right of the paginator. any preferences re me updating overall-vote to use the align-right class vs. setting "clear: both" on the top button?

^ (Compared to the size of the country and the languages Wikipedia community that is)

reosarevok, bitmap: I guess "align-right" since it's already being used at the bottom?

Oh wait, these are in MB already Pratha-Fish?

kellnerd: not yet :D

that sounds reasonable if the bottom one is already making use of it

Ah, then my argument about the size of the Wikipedia community makes sense

Spain ranking so high on wikidata is even more surprising (for it's size) https://usercontent.irccloud-cdn.com/file/IydHx...

to double-check/clarify, the bottom submit button is using align-right, and the top button that i'm adding is too. overall-vote is using "float: right". i could switch overall-vote to use align-right as well instead of float, but that'd take up some more space. if keeping overall-vote right of the paginator is desired, then i should probably just

set "clear: both" on the top button

derat: No problem with using it if it seems to be the best option :) try to keep it in CSS/LESS classes though.

derat: clear: both looks good indeed

great, thanks! just pushed the update

Good old `clear: both;`

yep, brings back memories :-P

(No worry, the edits list layout will eventually be reworked anyway.)

it's one of the css rules of all time for sure

the new commit looks good locally 👍

[musicbrainz-server] 14yvanzo merged pull request #3072 (03master…edits_button_top): MBS-5987: Add "Submit votes & edit notes" to top https://github.com/metabrainz/musicbrainz-serve...

thanks!

Thanks to you derat!

most of my commits are fairly self-serving as an editor, tbh :-)

That's how I started :)

[musicbrainz-server] 14reosarevok opened pull request #3077 (03master…MBS-13349): MBS-13349: Support LibraryThing disambiguation URLs https://github.com/metabrainz/musicbrainz-serve...

yvanzo: one more? :) ^

bitmap: https://github.com/metabrainz/musicbrainz-serve... seems fine once you deal with what yvanzo requested :)

appended this to the commit message: "It's currently set for edit searches involving a condition on the type of the relationship being edited (i.e., the \"Relationship Type\" predicate mentioned above)."

bitmap: Thank you for the extra explanations, it requires less neurons to understand which edit searches are affected by the patch :)

bitmap: left some comments on https://github.com/metabrainz/musicbrainz-serve... - maybe you like them?

np, I'm all for improving the clarity of commit messages :)

whoops, I thought I had added descriptions there, but it must've been a different branch. thanks for the suggestions

[musicbrainz-server] 14mwiencek merged pull request #3074 (03master…mbs-13347): MBS-13347: Relationship Type edit search times out https://github.com/metabrainz/musicbrainz-serve...

IIRC there was a button to apply all suggestions in one go, but I didn't see it

👍

[musicbrainz-server] 14reosarevok merged pull request #3077 (03master…MBS-13349): MBS-13349: Support LibraryThing disambiguation URLs https://github.com/metabrainz/musicbrainz-serve...

[musicbrainz-server] 14mwiencek merged pull request #3073 (03master…mbs-13348): MBS-13348: Fix edit_data_idx_link_type https://github.com/metabrainz/musicbrainz-serve...

Welcome to another MetaBrainz night! The day length is barely 8 hours, send help.

:D

help

I have one mailed in review, by aerozol:

aw come on, programmers love the night.

'''

The usual comms, moderation, socials.

Design-wise it was mainly pulling together designs for YIM 2023 - it's not too late to feedback in the next day or so. But planning to finalize everything this week.

See the current mockups and figma link here: https://tickets.metabrainz.org/browse/LB-1178?f...

LB-1178: Year in Music 2023

Thanks! The person who ran the test suite on the LB prod server can go next 😛

'''

(I see what he did there)

Any takers? :D

Hi!

well, could've been me, so...

Go

heh.

Other people in my list: reosarevok, bitmap, zas, yvanzo, monkey, lucifer, akshaaatt, atj, ansh, ApeKattQuest, kellnerd, Pratha-Fish, arsh, jasje