#musicbrainz-devel

/

      • murdos joined the channel
      • jherm joined the channel
      • pronik` joined the channel
      • MightyJay joined the channel
      • ijabz joined the channel
      • ijabz joined the channel
      • NXisGOD joined the channel
      • ijabz_ joined the channel
      • luks joined the channel
      • djce joined the channel
      • ijabz joined the channel
      • NXisGOD joined the channel
      • NXisGOD
        luks, can i ask u something? the little helper plugins? is it ok if they get included in script.py? :)
      • luks
        NXisGOD: which ones?
      • I think I'd prefer to not include any plugins by default
      • or if we include them, not make them enabled by default
      • NXisGOD
        alphachar and initials are 2 plugins that add 2 the functions in script.py
      • ive made my installer changes bundle plugins into installation itself, but it's disabled by default. it's useful for people who have no idea where to place plugins. plus my changes to the plugins page open the plugins folder, and open the web page to download plugins.
      • ijabz
        luks, hi
      • luks
        ijabz: hi
      • NXisGOD: I'm not sure what is alphachar, but initials just add a script function
      • ijabz
        In Search I'd like to replace UnaccentFilter with http://lucene.apache.org/java/2_9_0/api/all/org... it converts more characters and would be easier to manage , what do you think ?
      • luks
        that can be added directly to picard
      • ijabz: what characters for example?
      • ijabz
        \u1D0A
      • a type of J
      • luks
        well, I personally don't mind using anything
      • but if you want to replace it, be sure to go though old bug reports see if it can handle the characters
      • ijabz
        Ok, Ill take a look (i passes the existing tests anyway)
      • nikki
        heh, I'd be impressed if anyone actually tries to use that particular character
      • would you be able to take a list of characters and output what it converts them to?
      • I mean... I can easily generate lists of characters, but I don't know easy it would be to get that to output what it converts it to
      • ijabz
        Its easily readable in the source code of ASCIIFoldingFilter
      • nikki wonders where the source is
      • luks
        anyway, if you switch to ASCIIFoldingFilter I'll update the code to build the unaccent tables, so that we have identical functionality in the internal search
      • ruaok joined the channel
      • ijabz
        nikki svn checkout http://svn.apache.org/repos/asf/lucene/java/trunk lucene/java/trunk
      • nikki
        thanks
      • luks
      • I definitely don't know much about the JVM
      • but it's cool if it can optimize a huge switch like that
      • nikki
        I wonder if normalisation stuff is slow...
      • 'cause my first instinct would be to use one of the D forms and then just remove all the combining accents, rather than having so many thingies in the switch
      • luks
        that's what libunac does
      • ijabz
        I'll run some tests on index building to get a comparison of the two approaches
      • luks
        libunac (and UnaccentFilter) first tries to remove combining accents, then it does some text based replacements, and then has a hard-coded list of a few characters
      • it should be easy to run a report over the whole unicode, and list codepoints which are handled differently
      • ijabz
        Could do, I was thinking simple performance test first
      • luks
        I think correctness is more important then performance :)
      • both ways just replace characters based on a lookup table
      • you can rewrite them to be equally efficient
      • ijabz
        Performance was the issue a minute ago ... , could work out differences but doubt Id understand the results ;)
      • luks
        no, I didn't mean it's a problem
      • I was just wondering if JVM can really optimize stuff like that
      • ijabz
        I don't know thats why I was just going to run a test.
      • nikki
        ijabz: that's why you'd show us the results :P I'm sure one of us would understand them
      • aCiD2 joined the channel
      • ruaok joined the channel
      • outsidecontext joined the channel
      • ijabz joined the channel
      • MightyJay joined the channel
      • ijabz joined the channel
      • ruaok
        outsidecontext: ping
      • outsidecontext
        ruaok: hey
      • ruaok
        hi
      • I just caught up on this ticket: http://bugs.musicbrainz.org/ticket/5289
      • outsidecontext
        ok
      • ruaok
        the argument is that by fixing this bug picard could do better matching, which seems to be a number #1 request on uservoice.
      • do you agree with that?
      • outsidecontext
        mmh
      • ruaok
        I thought the biggest problem was users attaching puids to non-album tracks.
      • which then causes those tracks to be preferred.
      • outsidecontext
        we could then maybe do a combined PUID / existing metadata search
      • ruaok
        that makes sense.
      • I'm trying to figure out if this should happen before NGS.
      • unless this fix goes into 0.12 it doesn't really make sense.
      • but I think 0.12 is too far along to get this fix in, no?
      • outsidecontext
        it could improve those cases were a PUID is found on the wrong release (e.g. a compilation or different version). but we compare the metadata anyway on the results of the PUID query
      • i'm not that sure it would improve much
      • ruaok nods
      • i think we should get a 0.12 soon because 0.11 still has some annoying bugs
      • ruaok
        I think the logic in picard should ALWAYS prefer album releases UNLESS the metadata matches perfectly for a non-album release.
      • outsidecontext
        then we should be prepared to make an update together with the NGS release if something breaks in the webservice
      • yes, i agree on that
      • ruaok
        I think that makes tons of sense.
      • ok, lets make a deal.
      • you take care of my suggestion for improved matching in picard.
      • I take care of the PUID filtering for NGS.
      • sound ok?
      • outsidecontext
        ok, deal
      • ruaok
        :-)
      • outsidecontext
        ruaok: will you be at the gsoc summit again this year?
      • ruaok
        yes
      • outsidecontext
        it's soon, right? end of this month?
      • ruaok
        1.5 weeks.
      • outsidecontext
        you should bring some chocolate for leslie and her team :)
      • ruaok
        I'm bringing Leslie a burrito as usual and I'll certainly pick up chocolate for the rest of the team.
      • Too bad its so $$$ to ship over. Otherwise it would be nice to have some better choco...
      • outsidecontext
        yes. but wou can get some at the summit in november
      • ruaok
        thats certainly the plan!
      • outsidecontext
        i can bring you some more frey supreme if you want
      • ruaok
        yes please!
      • just a random collection this time please.
      • outsidecontext
        ok. got enough of the vanilla?
      • ruaok
        yes.
      • another friend who also visited .ch brought a bunch over. I still have 6 or so...
      • outsidecontext
        :)
      • ok, i need some sleep. work is stealing all my time this week :(
      • ruaok
        ok, gute nacht!
      • outsidecontext
        cu