-
voiceinsideyou joined the channel
-
Leftmost joined the channel
-
kepstin joined the channel
-
kepstin
-
kepstin is still working on it, but it's coming along :)
-
-
kepstin fixes up paths :)
-
kepstin-laptop joined the channel
-
olaf_ joined the channel
-
ijabz joined the channel
-
djce joined the channel
-
ijabz joined the channel
-
ijabz joined the channel
-
reosarevok joined the channel
-
ocharles
URGH
-
Sometimes I really hate Perl and Template Toolkit
-
and the more I use Haskell, the more frequently this hatred comes up
-
warp
:)
-
ocharles
not entirely perl's fault though. object model is too lax, and template toolkit is too... well templatey
-
warp: got a moment?
-
warp
yes
-
ocharles
yay
-
-
The problem is ReleaseTracklist.fixTrackCount is trying to add/remove tracks because it thinks there is a TOC
-
However, the TOC is in the form of $toc.val(), not MB.medium_cdtocs[x] being non-null
-
warp
oh, hm, I thought that was fixed.
-
ocharles
But fixTrackCount assumes that if hasToc() is true, then MB.medium_cdtocs[x] is also true
-
hmm, not in my master
-
warp
ok
-
anyway, your description sounds right.
-
ocharles
I don't know what the right solution is though
-
should seeding with a TOC fill in that medium_cdtocs thing?
-
that seems like it's probably the right way to do it
-
warp
that sounds fine.
-
all of it is just hacks to get information from server to client and back :)
-
(there's no nice architecture there, no clearly defined responsibilities, anything goes)
-
ocharles
NEEDS LESS STATEZ
-
meh, too difficult. I'm going to move MB.medium_cdtocs[x] into a function that returns a track count, and will just hackily parse the TOC
-
warp
lol
-
warp does some testing of his MBS-3152 fix.
-
ocharles
heh, I'm looking at 3858 at the moment
-
navap_ joined the channel
-
voiceinsideyou joined the channel
-
reosarevok_ joined the channel
-
ijabz joined the channel
-
navap joined the channel
-
the_metalgamer joined the channel
-
interesting. tracklist->find_or_insert hasn't been correct since June 7th
-
Good work me
-
reosarevok
What does that mean?
-
ocharles
it means it's been creating split tracklists when it shouldn't
-
which doesn't really mean anything, except the /tracklist page is less useful
-
reosarevok
Oh, ok
-
So that's a known issue
-
reosarevok thought it was a different, more serious thing
-
Fixing it should just mean running a script once it stops doing it, right?
-
ocharles
well, known issue but i didn't realise it was broken because of this :)
-
yep, we already have that script too
-
reosarevok
Cool! :)
-
ocharles
So. Some names/comments aren't trimmed correctly, and the tracklist sharing code is broke
-
:P
-
275 duplicate tracklists though, state of affairs isn't too bad
-
warp: I think this will affect you
-
(and the work you're doing atm)
-
warp
haha
-
ocharles
it's in the mbs-3858 branch
-
warp
I finished the real work on MBS-3152 yesterday, I'm just yak shaving some edge cases (adding cdstubs/freedb/etc..).
-
ocharles
"Kuno doesn't appear to read Jira email" haha
-
(Seen reading my jira email :P)
-
reosarevok
Well, it's a fact :p
-
ocharles
I really want to start moving stuff from NGS and Post NGS
-
but better wait for rob to come back
-
reosarevok
That's like, in a day or two, right?
-
ocharles
Yea, hopefully
-
sweet, 57 editors have voted :)
-
reosarevok
Wow
-
That's *much* more than I ever expected
-
ocharles
-
good work with the title, me.
-
reosarevok
:)
-
bitmap joined the channel
-
ianmcorvidae
ocharles: plans re: showing people results?
-
or will that be purely internal?
-
reosarevok
ianmcorvidae, they're shown
-
ianmcorvidae
they are?
-
huh, that's new
-
reosarevok doesn't remember the URL
-
reosarevok
But it's public
-
ocharles
//results
-
ianmcorvidae
ah
-
neat
-
ocharles
who'd a thunked it
-
ianmcorvidae
hah, personalize music news page: 0 3 11 XD
-
ocharles
:P
-
reosarevok wins the award for most important new feature!
-
ianmcorvidae
seems like "make there BE a music news page" comes first :P
-
actually, [MBS-645] Add specific link phrase support to ARs depending on gender, dates, and quantities
-
ocharles
reosarevok: your prize is... to implement it!
-
ianmcorvidae
is 0 2 11, apparently
-
ocharles
wait, actually, that's just most voted, not most important
-
oops
-
ianmcorvidae
haha
-
ocharles
MBS-2770 is still a reosarevok ticket though, heh
-
ianmcorvidae
lol, my "timeline graph events should be in the DB" ticket is 0 0 10
-
probably anything that's assigned to me should be unscheduled, though
-
reosarevok
ianmcorvidae, that's mostly it
-
ocharles
My plan is
-
reosarevok
ocharles, remember a lot of my tickets are just jira imports (some of them I even disagree with)
-
ocharles
wait for rob to come back, empty the majority of this because it has enough votes to make a decision
-
Then dump *everything* into it
-
and make a new blog announcement that it'll be updated daily/weekly/whatever
-
ijabz joined the channel
-
the_metalgamer joined the channel
-
hawke__ joined the channel
-
the_metalgamer joined the channel
-
ijabz joined the channel
-
bitmap joined the channel
-
kepstin joined the channel
-
ruaok joined the channel
-
Leftmost joined the channel
-
the_metalgamer joined the channel
-
the_metalgamer joined the channel
-
Leftmost joined the channel
-
ijabz joined the channel
-
ruaok joined the channel
-
nikki
-
ocharles
nikki: nope
-
atleast a grep -r for "DEFERRED_UPDATE_LOG" yields no matches
-
nikki
so we're still using deferred update stuff?
-
-
ocharles
nikki: no, we're not using it
-
but it looks like that ticket is still valid if that file still exists :)
-
nikki
it does still exist :P I just linked to it :P
-
bitmap joined the channel
-
ijabz joined the channel
-
-
ocharles
nikki: I don't know if the beeb still need it, but I don't agree that it should be supported :)
-
bitmap joined the channel
-
ruaok
they never used it, so go ahead and close the bug.
-
ocharles
ruaok: btw, are you still on holiday til monday?
-
ruaok
kinda sorta.
-
trying to get into the swing of things today and tomorrow.
-
but certainly back 100% on monday
-
ocharles nods
-
but, if you slackers get me invoices by tomorrow morning, I'll get em paid
-
ocharles
oh yea
-
i sent my last.fm one, better send the other!
-
ruaok
ocharles: did you ever setup up a mileage plus account with united?
-
ocharles
ruaok: nope
-
ruaok
bummer.