#musicbrainz-devel

luks, have you had the opportunity to have a look at my file_system branch?

luks: ping

outsidecontext: pong

hey luks. do you have some time?

yes

we introduced some bug in picard with the itunnorm fix :( it now deletes all COM frames when saving

ouch

nxisgod fixed it here: http://bazaar.launchpad.net/~openshift/picard/i...

but he has the habit to always fix two things together :) my question is what do you think about his second change?

how he handles the comment language

it's a good idea, but it's not backwards compatible

I think the fix for itunnorm isn't correct

it should not delete anything by default

yep, i was not sure why he did that at all

without deleting, would it cause duplicate tags?

only if the description or the language doesn't match

there was a problem before, because picard was writting all COMM tags with language ' ' (three spaces)

so it was writing a duplicate frame

one for 'eng', one for ' '

ok, now i see. so he originally needed the deletion, but with you language fix this got obsolete

I think handling this is a good idea, because there shouldn't be more than one iTunNORM

but it should be done only if we have a comment:iTunNORM entry in metadata

sounds better

what about "if desc.lower()[:4]=="itun":"? shouldn't it check for iTunNORM?

I think there is one more special iTunes frame that should be handled similarly

I can't remember what it is now

ok

i will change his fix to check for the tag present in metadata

guess we must do a 0.12.1 then :(

outsidecontext: I'd simply do it in the "if desc.lower()[:4]=="itun":" branch

becuse there can be only one tag anyway, ok

maybe just something like tag.delall('COMM:' + desc)

about his language changes (which i won't merge right now): i told him to change the order to comment:des:lang, because it looked more backward compatible

I'm not sure about that change

me neither.

one of my problems with many of his patches: they include one thing i like, and another i don't like :)

comment:desc:lang would definitely be better

but it should handle also the case of comment:desc

because that's what existing plugins might write

exactly. and we must check all other formats

and a better default for lang is maybe 'eng' instead of None

I'm not sure if None would actually work

what was it set to before we explicitely added it?

nothing

so it used the default value

which would be None in mutagen, and would result in 3 null bytes

luks: ok, i added the fix for the COMM frames. i will make a0.12.1 then. damn

is it hard to re-build the installer?

no, that's done quickly

i have finally a VM set up :)

nice example of what you can expect in audio file tags - https://bugs.kde.org/show_bug.cgi?id=211089#c6 :)

i think you can expect everything in audio files :)

yep, that was the point :)

I don't really understand it

ok, for ID3v2

but flac and vorbis comments are TRIVIAL

it's hard to screw that up

some people take that as a challenge :P

"hard to screw up? ok, I'll see what I can do!"

luks: http://users.musicbrainz.org/~outsidecontext/pi..., can ypu copy the 0.12.1 files to the ftp?

outsidecontext: yes

i'll update the download page in the wiki

yes, once luks has copied the files

copied to where they should be, now we have to wait for the cron job to rsync them

thx. how long should that take?

outsidecontext: http://ftp.musicbrainz.org/pub/musicbrainz/picard/

great, can you publish the wiki download page?

which version number is it?

I could do it...

ok

where do i see the version number?

thx nikki

there

I usually go to the history and copy it from the url, I dunno if there's an easier way than that