Actually, I almost prefer the Lead Belly version, and that one's from like 1922 :D
2010-03-26 08548, 2010
luks
well, each of the adaptations should be a separate work
2010-03-26 08557, 2010
navap
Oh jeez, work types. Way to just complicate my understanding of works :p
2010-03-26 08504, 2010
luks
there is no score or anything for such songs
2010-03-26 08514, 2010
luks
so the artists have to do their own composition
2010-03-26 08531, 2010
navap
Types do make (even more) flexible though.
2010-03-26 08535, 2010
warp
/win 17
2010-03-26 08536, 2010
navap
make them*
2010-03-26 08536, 2010
brianfreud
I picked that one cause, if you drew a tree of version to version, it's actually possible; from what I've read, it has two main lyrics versions, each of which goes to the 20's or so, then those 2 merge into the 1890s or so, into a single trad folk song
2010-03-26 08545, 2010
warp
hrm
2010-03-26 08549, 2010
warp
time-of-day! :)
2010-03-26 08556, 2010
navap
TOD!
2010-03-26 08506, 2010
brianfreud
luks: btw... do you have a few minutes you could fix something for me and navap?
2010-03-26 08515, 2010
luks
not right now
2010-03-26 08518, 2010
brianfreud
k
2010-03-26 08536, 2010
navap
brianfreud: Actually, it's only djce that can do it. You need server access to add a namespace.
2010-03-26 08544, 2010
brianfreud
hmph
2010-03-26 08501, 2010
brianfreud
djce said he, luks, and nikki were the 3 who could modify namespaces
2010-03-26 08510, 2010
navap
That was me actually :p
2010-03-26 08513, 2010
brianfreud
ah
2010-03-26 08529, 2010
navap
That was my mistake, I then looked up the process and realized you'd need server access.
I'm thinking of maybe using JS to cap the number of edit notes visible by default.
2010-03-26 08512, 2010
navap
And I also need to figure out what to use for a separator between the edits, the orange line is just a placeholder.
2010-03-26 08555, 2010
navap
Oh and I'm having the same problem as before where editor names have mysteriously vanished from that page :/
2010-03-26 08521, 2010
brianfreud
I would really like to see old and new on separate lines
2010-03-26 08540, 2010
navap
I haven't touched any of the actual edit detail templates yet.
2010-03-26 08547, 2010
brianfreud
and why would you cap the edit note display?
2010-03-26 08536, 2010
navap
Because I think it makes more sense to keep the page short and easy to scroll through. I'd use a "see more" JS link to bring the rest into view.
2010-03-26 08551, 2010
brianfreud
personally, I think edit debates, when they exist, should be entirely viewed; otherwise, you'll get people who read only the visible notes, and jump in with an opinion on something perhaps long settled
2010-03-26 08523, 2010
navap
That's easily fixable, (and already is actually), the add edit note box isn't visible if you notice.
2010-03-26 08548, 2010
brianfreud
what did you do with it?
2010-03-26 08516, 2010
navap
Nothing actually, that functionality hasn't been implemented yet. Don't worry I'm not hiding it on purpose :p
2010-03-26 08524, 2010
brianfreud
lol
2010-03-26 08533, 2010
navap
Of course it will be there on the mass edit page.
2010-03-26 08555, 2010
navap
But as for your concern it's easily handled by not showing the box unless you're seeing all thenotes.
2010-03-26 08530, 2010
brianfreud
to me, that adds a click - ie, adds annoyance, rather than removing it
2010-03-26 08523, 2010
navap
In the cases where that click would be necessary there are alreasy 3 or 4 edit notes visible. If there are more notes than that on that edit then the extra 1 second it takes to click the link is vastly overshadowed by note reading time.
2010-03-26 08552, 2010
navap
Anyway, that's a minor point. Are there any other points of concern about this design?
2010-03-26 08530, 2010
navap
I think it makes a lot of sense since it's a similar layout to the rest of the pages on the site, and the individual edit page also look very similar.
2010-03-26 08551, 2010
brianfreud
Edit #2 has far too much vertical whitespace
2010-03-26 08512, 2010
brianfreud
also, the edits appear to be in decending order?
2010-03-26 08551, 2010
brianfreud
and where is the count of abstaining votes?
2010-03-26 08506, 2010
navap
There's never been a count of abstaining votes before.
2010-03-26 08516, 2010
navap
It could be added in though.
2010-03-26 08559, 2010
navap
And as for the decending order, yeah that is quite odd. I'm not sure why they do that.
2010-03-26 08551, 2010
brianfreud
ah, for some reason I thought I remembered seeing abstains counted
2010-03-26 08555, 2010
navap
Edit 2 will have much less whitespace once you add in extra rows for the edit changes.
2010-03-26 08502, 2010
brianfreud
but the order thing is problematic, I think
2010-03-26 08506, 2010
navap
For example links to the entiy.
2010-03-26 08519, 2010
navap
I'm sure the ordering is easily fixed.
2010-03-26 08522, 2010
brianfreud
what about the 1/2 inch below and above the orange bar?
2010-03-26 08551, 2010
brianfreud
I'd much rather see more edits at once than have highly spaced out edits
2010-03-26 08500, 2010
brianfreud
just that much more scrolling to have to do when I'm voting
2010-03-26 08522, 2010
navap
Good point, okay I'll minimize the space between the edits.
2010-03-26 08524, 2010
warp
hm, don't we always have edits in descending order?
2010-03-26 08533, 2010
brianfreud
atm, I can see 5 edits at a time on the voting page; in that picture, I see 2.
2010-03-26 08542, 2010
warp
newest first, etc..
2010-03-26 08552, 2010
warp
s/newest/most recent/ :)
2010-03-26 08507, 2010
navap
brianfreud: Are you factoring in the comments though?
2010-03-26 08513, 2010
brianfreud
navap yep
2010-03-26 08525, 2010
brianfreud
warp: just checked - looks like yes, by default, when you view an entity's edits, it's in decending order.
2010-03-26 08544, 2010
brianfreud
:P I always use the ascending order option when I vote, via advanced edit search
2010-03-26 08518, 2010
brianfreud
I'd much rather see edits which are about to expire, not edits which only were created 15 seconds ago
2010-03-26 08524, 2010
warp
ah, right.
2010-03-26 08528, 2010
navap
Okay I'm off to bed. Looks like I wasn't able to stick this branch up on review board tonight :(
2010-03-26 08536, 2010
navap aims for tomorrow!
2010-03-26 08519, 2010
ijabz joined the channel
2010-03-26 08529, 2010
djce joined the channel
2010-03-26 08508, 2010
ijabz joined the channel
2010-03-26 08532, 2010
avi| joined the channel
2010-03-26 08537, 2010
avi| has left the channel
2010-03-26 08535, 2010
ijabz joined the channel
2010-03-26 08505, 2010
dzan joined the channel
2010-03-26 08537, 2010
aCiD2
morning!
2010-03-26 08541, 2010
aCiD2 prods warp
2010-03-26 08556, 2010
warp was prodded.
2010-03-26 08511, 2010
aCiD2
warp: I want to get you on board helping with the edit migration stuff
2010-03-26 08519, 2010
aCiD2
but i'm going to take a shower first, so i'll be back in 20 mins :)
2010-03-26 08558, 2010
warp
haha
2010-03-26 08533, 2010
aCiD2
ok, back!
2010-03-26 08504, 2010
aCiD2
there's probably no rush to get started right now, but it'd be nice to have you set up and ready to hack by sunday (ie, you can run the migration script and you understand what we're doing and how the code looks)
2010-03-26 08506, 2010
avi| joined the channel
2010-03-26 08514, 2010
avi| has left the channel
2010-03-26 08548, 2010
warp
aCiD2: I'll be away tomorrow, helping someone move, but I can try and get the non ngs database on my box on sunday.
2010-03-26 08513, 2010
avi| joined the channel
2010-03-26 08528, 2010
avi| has left the channel
2010-03-26 08559, 2010
aCiD2
warp: ok, sounds good
2010-03-26 08538, 2010
aCiD2
HRMMM. How to migrate a remove release edit... it doesn't know what release to relate the edit too, because obviously it got removed
2010-03-26 08557, 2010
brianfreud
add one new release as part of the migration, use it for all of those edits, then really remove the release at the end?
2010-03-26 08547, 2010
aCiD2
no, we're not doing migration
2010-03-26 08551, 2010
aCiD2
where we can't anyway
2010-03-26 08554, 2010
aCiD2
we're doing read only edit types
2010-03-26 08521, 2010
aCiD2
for now I've gone with linking it if I can, and if not we just display the release name and artist
2010-03-26 08528, 2010
brianfreud
makes sense to me :)
2010-03-26 08522, 2010
aCiD2
it seems to work well :)
2010-03-26 08530, 2010
aCiD2
i checked it with gleen freemans failed edits ;)
2010-03-26 08546, 2010
brianfreud
LOL
2010-03-26 08502, 2010
ruaok joined the channel
2010-03-26 08524, 2010
ijabz joined the channel
2010-03-26 08507, 2010
navap
haha sub is_newbie
2010-03-26 08550, 2010
navap
How would I find out if an edit was applied as an auto-edit?
