Quick NGS question regarding collaboration artists in the old schema, such as 'Ravi Shankar and Philip Glass' that have been migrated to their proper separate artist credits in the NGS. Is there any way to retrieve the mapping of old collaboration artists to NGS artists? artist_gid_redirect doesn't seem to have any entries for cases like this, as it's PK is gid.
2010-11-30 33421, 2010
automator
It's not a big deal - but would help to avoid loss of some legacy musicbrainz data, such as last.fm's listening data.
2010-11-30 33433, 2010
dinog joined the channel
2010-11-30 33438, 2010
dinog1 joined the channel
2010-11-30 33405, 2010
ijabz joined the channel
2010-11-30 33439, 2010
luks
automator: could you please file a bug report about that?
2010-11-30 33428, 2010
nikki wonders how the mapping would work
2010-11-30 33434, 2010
nikki
since there'd be multiple target mbids
2010-11-30 33409, 2010
luks
I assumed linking to the first artist would be better than nothing
2010-11-30 33423, 2010
warp
can we not make it possible to redirect to the artist credit?
right, I guess we don't expose artist credits at all like that.
2010-11-30 33410, 2010
ocharles
warp: can I use for(foo in bar) ?
2010-11-30 33436, 2010
ocharles
I know you said use $.each, but my code uses multiple exit points so it doesn't map as nicely to using an anonymous function. and each doesn't seem to return anything useful for me
2010-11-30 33433, 2010
warp
ocharles: let me check the code again.
2010-11-30 33432, 2010
warp
but where is it...
2010-11-30 33411, 2010
warp
ocharles: you typo'ed the branch in code review
2010-11-30 33421, 2010
warp
(cleanup vs clean-up)
2010-11-30 33448, 2010
ocharles
oops
2010-11-30 33417, 2010
ocharles
pushed the new branch out with "for...in" loops
2010-11-30 33427, 2010
warp
yeah, as long as you use hasOwnProperty like that, it's fine.
2010-11-30 33449, 2010
ocharles
ok, cool
2010-11-30 33452, 2010
ocharles updates review
2010-11-30 33458, 2010
warp
with jquery you could have returned false to break the loop, and just assign the return value to a variable before doing that.
2010-11-30 33458, 2010
ocharles
warp: I need to borrow you for a bit shortly too
2010-11-30 33417, 2010
warp
neither is particularly pretty, so I have no strong preference.
2010-11-30 33428, 2010
ocharles
i prefer my approach (naturally :))
2010-11-30 33432, 2010
warp
haha
2010-11-30 33454, 2010
warp is borrowed.
2010-11-30 33401, 2010
ocharles
ok
2010-11-30 33408, 2010
ocharles
I want to work on add artist/add label from the RE
2010-11-30 33417, 2010
warp
yay!
2010-11-30 33418, 2010
warp
ok
2010-11-30 33445, 2010
ocharles
I think I'll do it by reusing the old artist/create code and stuff, by adding some sort of parameters of where to store the created artist gid
2010-11-30 33453, 2010
ocharles
firstly, do you think that's enough data?
2010-11-30 33408, 2010
warp
what is the old artist create code?
2010-11-30 33410, 2010
ocharles
and secondly, is just stuffing it into the wizard in session enough?
2010-11-30 33438, 2010
ocharles
Well, it just redirects you to the new artist page after, but I can factor that out to a callback
2010-11-30 33448, 2010
warp
right
2010-11-30 33415, 2010
ocharles
so my questions are...
2010-11-30 33431, 2010
ocharles
how should we get to this form, and where do we go when it's submitted? :)
2010-11-30 33433, 2010
warp
I'm just thinking a bit ahead, e.g. when adding a VA release with dozens of new artists. It would be nice to be able to add those artists on a single page... but I guess that's post-NGS, so ignore me.
2010-11-30 33412, 2010
ocharles
It'd be nice yea, but tricky
2010-11-30 33431, 2010
ocharles
How hard would it be to let your artist credits/release labels have no ID, and then add separate "add artist" and "add label" steps?
2010-11-30 33443, 2010
ocharles
and then I can fill the ids in
2010-11-30 33447, 2010
warp thinks.
2010-11-30 33438, 2010
warp
ocharles: I added validation bits recently, so if I did that correctly, the wizard currently will not let you continue when there is no id or gid (I forgot which one we're using internally there).
2010-11-30 33458, 2010
ocharles
yep, i've seen that
2010-11-30 33405, 2010
warp
I guess it would be best to just add a flag to each artist/label field which indicates that those will be added in a later step.
2010-11-30 33405, 2010
ocharles
thinking a bit more generally, this needs to be able to plug in to the edit recording stuff too, preferably
2010-11-30 33421, 2010
ocharles
but the id and gid would still be null and fail velidation
2010-11-30 33429, 2010
warp
edit release group, and currently edit work also have artist credits.
2010-11-30 33442, 2010
ocharles
yea, that's what I meant about more generally
2010-11-30 33407, 2010
warp
we can always add sub validate {} calls to the forms if they need to allow more complicated stuff.
2010-11-30 33411, 2010
ocharles_ joined the channel
2010-11-30 33443, 2010
warp
(to deal with either id/gid should be present, or an 'add artist' checkbox should be checked).
2010-11-30 33457, 2010
warp
or we just introduce some fake id which means to add the artist in a later step, but that's a hack ;)
2010-11-30 33413, 2010
ocharles
Yea, not too keen on hacks :)
2010-11-30 33400, 2010
ocharles
Ok, first things first I'm gonna make an action that has an AC editor, allows blanks, and then redirects to some other page when you submit with artists
2010-11-30 33404, 2010
ocharles
then we'll see where we end up
2010-11-30 33434, 2010
warp
haha, ok
2010-11-30 33424, 2010
warp
can you spend some time on review code later today or tomorrow? there's some release editor stuff in code review I'd like to build on.
2010-11-30 33437, 2010
warp
s/review code/code review/
2010-11-30 33441, 2010
ocharles
certainly
2010-11-30 33455, 2010
ocharles
warp: it seems all the "add release group" and "add work" pages AC editor doesn't work
2010-11-30 33457, 2010
ocharles
known bug?
2010-11-30 33436, 2010
warp
ocharles: hm, did it break when merging?
2010-11-30 33439, 2010
warp checks.
2010-11-30 33427, 2010
warp
it works on test. but I guess you're on master.
2010-11-30 33439, 2010
ocharles
i couldn't get it to work on test either
2010-11-30 33444, 2010
ocharles
hrm
2010-11-30 33430, 2010
warp
browser/platform?
2010-11-30 33446, 2010
ocharles
ff 3.6 on ubuntu
2010-11-30 33449, 2010
ocharles
i'll poke more later
2010-11-30 33409, 2010
warp
hm, I have ff 3.6 on debian. that should be almost identical. :)
2010-11-30 33431, 2010
nikki
ocharles: did you update test with the url stuff?
2010-11-30 33404, 2010
ocharles
nikki: i forgot to restart, one mo
2010-11-30 33413, 2010
ocharles
nikki: ok restarted, should have the new merge stuff as well
2010-11-30 33442, 2010
djce joined the channel
2010-11-30 33428, 2010
djce
Hello! Anyone want to claim ownership of /home/search/updateindex.sh on test? (murdos?)
2010-11-30 33455, 2010
djce
It's generating whiney emails to me every 5 minutes.
2010-11-30 33415, 2010
warp hides behind the fridge.
2010-11-30 33456, 2010
ocharles
warp: I'm looking at how Discogs handles this and they give you a little warning saying: "The following do not currently exist. Please check this box to make sure you want to create new artists and/or labels"
2010-11-30 33415, 2010
ocharles
I wonder if the same will be ok for us because that is considerably easier than managing page flow between multiple controllers
2010-11-30 33426, 2010
warp
ocharles: I would definitely prefer that.
2010-11-30 33456, 2010
djce fixes the whiney cron
2010-11-30 33406, 2010
warp
ocharles: but in that process a user does need to be prompted for artist disambig comments and sortnames.
2010-11-30 33425, 2010
ocharles
We should be able to do that though with a custom form in the ER
2010-11-30 33426, 2010
ocharles
RE*
2010-11-30 33441, 2010
warp
ocharles: yes, I'd be perfectly happy with that approach.
2010-11-30 33401, 2010
ocharles
great, because i'm scared of doing the current server behaviours approach :)
2010-11-30 33409, 2010
warp
indeed.
2010-11-30 33427, 2010
nikki
ocharles: found another problem with the url stuff... every time you press a key, it moves the cursor to the end, so selecting the text or fixing typos is rather hard
2010-11-30 33444, 2010
nikki
that's in safari at least
2010-11-30 33404, 2010
nikki
yeah, it's not doing that in opera
2010-11-30 33422, 2010
nikki
ocharles: and it's not working on the edit url page
2010-11-30 33405, 2010
alastairp joined the channel
2010-11-30 33427, 2010
ijabz_ joined the channel
2010-11-30 33435, 2010
alastairp joined the channel
2010-11-30 33402, 2010
ocharles
nikki: ah, good catch on edit url - it's not enabled there
2010-11-30 33422, 2010
ocharles
re the cursor stuff, I found that too, but I don't know how to fix it :( maybe I can give it to warp to look at when I fix /url/edit
2010-11-30 33406, 2010
warp
sure.
2010-11-30 33438, 2010
warp wonders where to stick the 'use direct search' checkbox
2010-11-30 33420, 2010
ocharles
I'LL TELL YOU WHERE YOU CAN STICK THAT CHECKBOX WARP
