ianmcorvidae: have upgraded to the newest chrome 14, now I see the timeline. So definitely not your bug.
2011-07-19 20012, 2011
reosarevok
:)
2011-07-19 20007, 2011
warp
hello!
2011-07-19 20050, 2011
reosarevok
warp: can you please see if fixing whatever happened with tracklist edits now is a straightforward, simple thing, or we have to wait until Ollie comes back?
2011-07-19 20054, 2011
reosarevok
(also, hi)
2011-07-19 20003, 2011
Leftmost
Hello, warp.
2011-07-19 20009, 2011
Leftmost
(I wasn't raised in a barn.)
2011-07-19 20031, 2011
ruaok
montana, barn. I would disagree
2011-07-19 20036, 2011
Leftmost
Western Montana isn't big on livestock. It was a shed.
2011-07-19 20040, 2011
warp
reosarevok: any idea if it can be reproduced on test?
Leftmost: does the .json look correct in edit 14857888? All the names are changed to "Alright!". (if the json is correct, that is "just" a display bug)
2011-07-19 20004, 2011
Leftmost
Yes, that's correct.
2011-07-19 20015, 2011
warp
urgh.. jira uses picture smileys in the comments :(
looks like the devs didn't look at the Track Relationships Conversion page after writing migration scripts
2011-07-19 20056, 2011
ianmcorvidae
since re-arranged version doesn't exist either
2011-07-19 20045, 2011
nikki
the arranger stuff is a complete mess :(
2011-07-19 20052, 2011
ianmcorvidae
yeah
2011-07-19 20003, 2011
ianmcorvidae
we had worked through this in the track relationship conversion meeting
2011-07-19 20009, 2011
ianmcorvidae
apparently nobody wanted to implement it though
2011-07-19 20039, 2011
bitmap
luks: I think I've discovered something: when I apply http://paste.pocoo.org/show/442411/ I don't seem to run into file loading issues anymore. do you remember why the queues are set up like that?
2011-07-19 20018, 2011
luks
bitmap: to be able to use more than one thread for loading
2011-07-19 20002, 2011
bitmap
ah, I see
2011-07-19 20023, 2011
luks
but maybe it doesn't make much sense
2011-07-19 20050, 2011
bitmap
luks: would having only one queue per thread, but letting two threads share a queue work?
2011-07-19 20046, 2011
luks
I don't know understand
2011-07-19 20016, 2011
luks
oh, you mean merging the load/other queues?
2011-07-19 20034, 2011
luks
to be honest, I don't remember much of the code
2011-07-19 20052, 2011
luks
I think other handles directory listing, load file loading
2011-07-19 20012, 2011
luks
if you merge them, it will first fully load files, instead of listing directories first
2011-07-19 20054, 2011
luks
anyway, I'd try one queue per thread and then maybe adding one extra thread for the load queue
2011-07-19 20027, 2011
bitmap
hmm, yes, that's what I was thinking
2011-07-19 20005, 2011
luks
I can't really see why would that fix the problem
2011-07-19 20028, 2011
luks
ah, right, it can
2011-07-19 20018, 2011
luks
if qsize() returns something >0 and in between the other thread takes the task the thread will be stuck on the non-primary queue
2011-07-19 20026, 2011
luks
then no thread will be waiting on one of the queues and whole picard is stuck
2011-07-19 20017, 2011
luks
it's probably best to get rid of the multi-queue code
2011-07-19 20053, 2011
bitmap
I agree with that, it's rather complex to debug too
2011-07-19 20047, 2011
bitmap
luks: I don't actually see anything being added to the load_queue anywhere
2011-07-19 20016, 2011
bitmap
only to the other_queue
2011-07-19 20025, 2011
luks
"grep load_queue -R ."
2011-07-19 20027, 2011
luks
:P
2011-07-19 20040, 2011
luks
./picard/file.py: self.tagger.load_queue.put((
2011-07-19 20002, 2011
bitmap
aha! I missed that one
2011-07-19 20048, 2011
luks
picard's classes are really badly designed
2011-07-19 20018, 2011
luks
I didn't know much about GUI applications when I was writing the code
2011-07-19 20007, 2011
bitmap
well, at least the code is readble/understadable
2011-07-19 20009, 2011
bitmap
the only part that scares me is the itemviews.py code :)
2011-07-19 20030, 2011
bitmap
it's nearly 1000 lines long now, in fact
2011-07-19 20053, 2011
outsidecontext joined the channel
2011-07-19 20051, 2011
bitmap
luks: having two threads each for the load_queue/other_queue seems most responsive I think
