In the web service, ratings are submitted on a scale of 0-100, but returned on a scale of 0-5. This seems a little odd, is it too late to do anything about this?
2011-08-16 22800, 2011
adhawkins
Was there supposed to be a release yesterday? Or was it postponed to today like the dev meeting?
2011-08-16 22821, 2011
reosarevok joined the channel
2011-08-16 22848, 2011
Mineo joined the channel
2011-08-16 22841, 2011
muesli joined the channel
2011-08-16 22819, 2011
Leftmost joined the channel
2011-08-16 22817, 2011
reosarevok
luks, what would you do with non-english words that mean feat.?
2011-08-16 22830, 2011
reosarevok
Standardise to feat. in recordings and use the original on tracks?
2011-08-16 22838, 2011
reosarevok
Use feat. in both? Original in both?
2011-08-16 22858, 2011
reosarevok usually used feat. in tracklists before NGS but is not sure now
2011-08-16 22820, 2011
luks
asking the wrong person :)
2011-08-16 22826, 2011
luks
I'd remove all feat. info
2011-08-16 22818, 2011
luks
but generally I don't think that tracks and recordings should use different wording on purpose
2011-08-16 22801, 2011
luks
if you have X english releases and one german, then use mit just for the german track
2011-08-16 22830, 2011
luks
but it doesn't make any sense to me to change the recording to something that is not used on *any* of the linked tracks
2011-08-16 22823, 2011
ocharles
adhawkins: postponed to today
2011-08-16 22827, 2011
ocharles
adhawkins: as we have no ruaok
2011-08-16 22818, 2011
kepstin-laptop has left the channel
2011-08-16 22858, 2011
flamingspinach joined the channel
2011-08-16 22814, 2011
adhawkins
np, figured as much
2011-08-16 22824, 2011
warp
breakfast!
2011-08-16 22811, 2011
ocharles
lunch!
2011-08-16 22800, 2011
kepstin-laptop joined the channel
2011-08-16 22843, 2011
hawke_ joined the channel
2011-08-16 22837, 2011
warp
ocharles: I'd like to discuss MBS-3102, do you have some time today?
2011-08-16 22843, 2011
ocharles
I do indeed
2011-08-16 22823, 2011
ocharles
fire away :)
2011-08-16 22804, 2011
warp
this is about the "change track artists" boolean of the "edit release artist" edit
2011-08-16 22835, 2011
warp
we previously decided that it should be on by default, and that there shouldn't be an interface to turn it off.
2011-08-16 22800, 2011
ocharles
right
2011-08-16 22835, 2011
warp
however, even if you manually reset all the artists on the tracklist tab, they will still be changed --- because those changes will result in a no-op mediam edit.
2011-08-16 22854, 2011
ocharles nods
2011-08-16 22821, 2011
warp
so, I'm think I need to detect such a no-op medium edit (both when previewing and submitting edits) and clear the boolean in that situation.
2011-08-16 22831, 2011
warp
however, currently the medium edit doesn't know this at the preview stage, because missing entities have not been resolved.
2011-08-16 22844, 2011
ocharles
If I have "Foo" by "Bar", which has one track: "Pancakes!" by "Bar", if I change the release "Bar" to "Waffles", does the RE internally change "Pancakes!" to be by "Waffles" as well?
2011-08-16 22859, 2011
warp
ocharles: yes.
2011-08-16 22850, 2011
ocharles
so, if the user changed it back to "Bar", (grep { $_->{artist_credit} eq 'Bar'} $release_editor->tracks > 0) will be true?
2011-08-16 22801, 2011
warp
ocharles: well, only for those tracklists loaded into a release. so not for releases with more than X discs.
2011-08-16 22807, 2011
ocharles
ah
2011-08-16 22843, 2011
ocharles
is that likely to be a problem?
2011-08-16 22825, 2011
warp
maybe? :)
2011-08-16 22840, 2011
ocharles
well if you haven't expanded any mediums, you accepting the default
2011-08-16 22842, 2011
ocharles
which is to rename them
2011-08-16 22845, 2011
warp
well, I can imagine edge cases where the result will not be what an editor expects, but they're edge cases, not likely to occur often.
that condition might be wrong, but I'm mostly saying that I don't see how this needs to change any edits internals
2011-08-16 22849, 2011
warp
I'm not sure I understand what you're saying :)
2011-08-16 22853, 2011
ocharles
well carry on with explaining what you want to discuss
2011-08-16 22855, 2011
ocharles
and we can come back to that
2011-08-16 22825, 2011
warp
well, the solution I had in mind to solve the problem already seems bad, so let me start fresh by explaining the problem again :)
2011-08-16 22815, 2011
warp
Imagine 2 disc release: release artist: Foo, artist on all tracks on disc 1: Foo, artist on all tracks on disc 2: Foo
2011-08-16 22844, 2011
warp
I want to change the release artist from Foo to Bar, but not change the track artists on disc 2.
2011-08-16 22852, 2011
warp
the release editor should make:
2011-08-16 22808, 2011
warp
1. Edit Release Artist (with change track artists), Foo -> Bar
2011-08-16 22825, 2011
warp
2. Edit Medium Edit for disc 2, change Bar back to Foo.
2011-08-16 22841, 2011
ocharles
I think it's easier to enter Edit Release Artist *without* changing artists, and entering edit medium edits
2011-08-16 22847, 2011
warp
that second edit is currently not entered by the release editor, because it is a no-op before the first edit is applied.
2011-08-16 22853, 2011
ocharles
we want to see edits that make changes, not edits that revert them
2011-08-16 22807, 2011
kepstin-laptop would expect 1. Edit Release Artist Foo -> Bar and 2. Edit Medium Edit for disc 1, change Foo -> Bar
2011-08-16 22816, 2011
ocharles
yep
2011-08-16 22822, 2011
ocharles
that's much more votable too
2011-08-16 22826, 2011
warp
ocharles: right, so the 'with change track artists' boolean should be disabled based on some condition, or always disabled?
2011-08-16 22822, 2011
ocharles
Well, the reason we bought it in, was because loading n tracklists was too much work
2011-08-16 22808, 2011
warp
right.
2011-08-16 22840, 2011
kepstin-laptop
so you need some way to tell the server that a tracklist was loaded, but a no-op edit was made on it, so the server won't attempt to change the artists on that tracklist when the edit is sumbitted?
2011-08-16 22847, 2011
ocharles thinks
2011-08-16 22826, 2011
ocharles
well, the only way what me and kepstin-laptop suggest is to load all the tracklists
2011-08-16 22853, 2011
warp
I'm afraid the edit preview / submit will choke on 180 disc releases.
2011-08-16 22816, 2011
ocharles
we have so few of them though
2011-08-16 22834, 2011
ocharles
but I guess at some point we have to address that problem
2011-08-16 22847, 2011
warp
you should still be able to change the release artist of those boxes :)
2011-08-16 22811, 2011
ocharles
I imagine if we've got as far as 180 discs, the release artist is correct :)
2011-08-16 22858, 2011
warp
ocharles: could the boolean be changed to a list of discs to touch? so any edited discs can be removed from the list and get regular "edit medium" edits (if neccesary).
2011-08-16 22808, 2011
ocharles
yea, I was going to suggest that
2011-08-16 22818, 2011
ocharles
but that's also fairly hard to vote on
2011-08-16 22833, 2011
ocharles
"Edit release artist on mediums 1, 2, 3, 4, 5, 7, 8, 9" or even "except 6"
2011-08-16 22837, 2011
ocharles
"medium 6" is pretty useless to voters
2011-08-16 22850, 2011
warp
well, you can display the mediums with a bit more details.
2011-08-16 22801, 2011
warp
I expect the big classical composer boxes to have disc titles
2011-08-16 22821, 2011
warp
Edit release artist on:
2011-08-16 22826, 2011
warp
- CD 3: Stage Works II
2011-08-16 22834, 2011
warp
- CD 5: Symphonic Works II
2011-08-16 22850, 2011
warp
- CD 29: Early Works and Rarities
2011-08-16 22839, 2011
warp
if the list maintained in the edit is a list of medium row ids, that shouldn't be a lot of extra querying.
2011-08-16 22800, 2011
ocharles
well... it gets us somewhere, yea
2011-08-16 22807, 2011
warp
if you want to think on it some more, I'm not in any hurry to work on it :)
2011-08-16 22816, 2011
ocharles
my thoughts aren't really getting me anywhere. the only real solution I'm gravitating to is that it should support 180 disc releases :)
2011-08-16 22825, 2011
ocharles
but it's non trivial to get there
2011-08-16 22810, 2011
warp
hm
2011-08-16 22836, 2011
warp looks for something else to work on
2011-08-16 22849, 2011
ocharles
home time
2011-08-16 22801, 2011
wpl joined the channel
2011-08-16 22852, 2011
voiceinsideyou1 joined the channel
2011-08-16 22855, 2011
voiceinsideyou joined the channel
2011-08-16 22841, 2011
reosarevok
heh
2011-08-16 22806, 2011
reosarevok
I mistakenly wrote a space in the label field and it tried to create a new, " " label in Add Missing Entities
2011-08-16 22848, 2011
reosarevok guesses he should add a ticket unless warp can fix that with a single line right now or something
2011-08-16 22834, 2011
warp
reosarevok: hm. sounds related to some othe recent fix.
