#musicbrainz-devel

/

      • ocharles
        it'll be quite difficult to do that for releases though, which have many edits for 1 release object
      • 2011-11-01 30536, 2011

      • ocharles
        which moves to an EditFactory that can create edits for a given set of entities :) EditFactory->create_edits( $release );
      • 2011-11-01 30547, 2011

      • warp
        doh
      • 2011-11-01 30553, 2011

      • ocharles
        but there's even more architecture changes to get there (such as the ability to make a distinction if something is a create or update)
      • 2011-11-01 30558, 2011

      • ocharles
        so I doubt we'll actually get there
      • 2011-11-01 30513, 2011

      • warp
        ocharles: at the HTTP level the PATCH method/verb could be useful to submit partial changes to an entity.
      • 2011-11-01 30534, 2011

      • ocharles
        has that been accepted?
      • 2011-11-01 30520, 2011

      • ocharles
        but yes, that definitely sounds like a good method to support
      • 2011-11-01 30535, 2011

      • warp
        no, still a proposed standard from the looks of it. http://tools.ietf.org/html/rfc5789
      • 2011-11-01 30552, 2011

      • muesli joined the channel
      • 2011-11-01 30529, 2011

      • ocharles
      • 2011-11-01 30511, 2011

      • ocharles
        it's at the same status as http 1.1, nice
      • 2011-11-01 30520, 2011

      • warp
        oh, haha
      • 2011-11-01 30540, 2011

      • muesli joined the channel
      • 2011-11-01 30516, 2011

      • warp
        ocharles: thanks for your help so far. I know enough to continue mucking with for a while :)
      • 2011-11-01 30519, 2011

      • warp
        +it
      • 2011-11-01 30521, 2011

      • ocharles
        kewl
      • 2011-11-01 30528, 2011

      • ocharles
        back to putting out my jira email fires
      • 2011-11-01 30552, 2011

      • muesli joined the channel
      • 2011-11-01 30523, 2011

      • reosarevok
        ocharles, with http://tickets.musicbrainz.org/browse/MBS-3706 I don't want to change Picard behaviour
      • 2011-11-01 30530, 2011

      • reosarevok
        I think it should keep doing what it does
      • 2011-11-01 30547, 2011

      • reosarevok
        I just think it might be useful if it had an option to use direct search directly from there if the user found no results
      • 2011-11-01 30523, 2011

      • ocharles
        right, but I consider that a change of behavior :)
      • 2011-11-01 30531, 2011

      • reosarevok
        (tsk 504)
      • 2011-11-01 30543, 2011

      • ocharles
        504 from jira for you too?
      • 2011-11-01 30547, 2011

      • reosarevok
        Yes
      • 2011-11-01 30549, 2011

      • reosarevok
        Well, it doesn't *change* the current behavior
      • 2011-11-01 30555, 2011

      • reosarevok
        It just complements it with another option
      • 2011-11-01 30558, 2011

      • reosarevok
        I can see your point
      • 2011-11-01 30504, 2011

      • reosarevok
        But I don't think it changes a lot
      • 2011-11-01 30506, 2011

      • davitf joined the channel
      • 2011-11-01 30509, 2011

      • ocharles
        right, so it changes behavior :) But I mostly mean I'm not a Picard dev, so I can't do that
      • 2011-11-01 30516, 2011

      • reosarevok
        Oh
      • 2011-11-01 30521, 2011

      • ocharles
        if you want to run it by other picard devs and see what they think, go ahead
      • 2011-11-01 30527, 2011

      • reosarevok
        Isn't that page a MB one?
      • 2011-11-01 30537, 2011

      • ocharles
        yes, but pretty much only there for picard
      • 2011-11-01 30546, 2011

      • ocharles
        so I'm hesitant to change it without clear motivation
      • 2011-11-01 30551, 2011

      • reosarevok
        Ok
      • 2011-11-01 30557, 2011

      • reosarevok will query bitmap and luks
      • 2011-11-01 30515, 2011

      • reosarevok
        bitmap and luks! Please look at http://tickets.musicbrainz.org/browse/MBS-3706 when you're around and Jira stops 504'ing!
      • 2011-11-01 30516, 2011

      • reosarevok
        :)
      • 2011-11-01 30526, 2011

      • muesli joined the channel
      • 2011-11-01 30518, 2011

      • reosarevok wonders what is happening to Jira
      • 2011-11-01 30522, 2011

      • ocharles
        djce: ping!
      • 2011-11-01 30523, 2011

      • ocharles
        :)
      • 2011-11-01 30542, 2011

      • djce
        ocharles: pong.
      • 2011-11-01 30545, 2011

      • djce goes traditional
      • 2011-11-01 30517, 2011

      • ocharles
        djce: tickets.musicbrainz.org seems to be 504'ing an awful lot
      • 2011-11-01 30525, 2011

      • ocharles
        as in nothing but 504s for the last 10 minutes
      • 2011-11-01 30533, 2011

      • djce is looking....
      • 2011-11-01 30538, 2011

      • ocharles
        thanks
      • 2011-11-01 30506, 2011

      • djce
        meh. Busy, overloaded server.... it'll pass.
      • 2011-11-01 30521, 2011

      • djce
        backups and enormous web stats analysis currently running
      • 2011-11-01 30547, 2011

      • djce
        but I should probably try and arrange for those to run at separate times of daty
      • 2011-11-01 30549, 2011

      • djce
        day
      • 2011-11-01 30504, 2011

      • ocharles
        ah, ok
      • 2011-11-01 30504, 2011

      • djce
        We really need a server /just/ to do backups.
      • 2011-11-01 30508, 2011

      • voiceinsideyou
        502s, 504s; sad times :(
      • 2011-11-01 30513, 2011

      • reosarevok
        Is the wiki in the same server as Jira?
      • 2011-11-01 30517, 2011

      • djce
        yup
      • 2011-11-01 30520, 2011

      • reosarevok
        Ok
      • 2011-11-01 30525, 2011

      • djce
        overloaded, like I said :-)
      • 2011-11-01 30526, 2011

      • Leftmost joined the channel
      • 2011-11-01 30514, 2011

      • djce
        backups killed :-( but jira lives, somewhat.
      • 2011-11-01 30519, 2011

      • djce
        Not a long term solution, natch.
      • 2011-11-01 30506, 2011

      • reosarevok
      • 2011-11-01 30507, 2011

      • reosarevok
        ?
      • 2011-11-01 30535, 2011

      • reosarevok
        If not, could anyone update it?
      • 2011-11-01 30544, 2011

      • reosarevok is looking mostly at "required software"
      • 2011-11-01 30533, 2011

      • navap wonders what to do with old images such as http://wiki.musicbrainz.org/Image:MBComponents.png
      • 2011-11-01 30534, 2011

      • reosarevok
        Remove?
      • 2011-11-01 30540, 2011

      • reosarevok
        are they used anywhere?
      • 2011-11-01 30522, 2011

      • navap
        Not really
      • 2011-11-01 30543, 2011

      • navap
        There are lots of old images such as of the old schema as well
      • 2011-11-01 30545, 2011

      • reosarevok
        voiceinsideyou, ocharles: Does a text like 'Search indexes are updated every 3 hours. If you just added the content you're looking for, use the search bar at the top and select the \"Direct database search\" option from the results page.' sound OK for that page?
      • 2011-11-01 30522, 2011

      • ocharles
        hrm, you can't choose direct database from the search bar at the top
      • 2011-11-01 30525, 2011

      • navap
        Where is that text going?
      • 2011-11-01 30545, 2011

      • navap
        You'd want to direct them to click the search link in the menu
      • 2011-11-01 30500, 2011

      • reosarevok
        ocharles, that's why it says "from the results page"
      • 2011-11-01 30505, 2011

      • reosarevok
        navap, /taglookup
      • 2011-11-01 30526, 2011

      • reosarevok
        But yeah, that makes sense
      • 2011-11-01 30505, 2011

      • navap
        Ah. Well you'd want to direct them to visit /search. If you wanted to get fancy you could pass on the search parameters in the url.
      • 2011-11-01 30531, 2011

      • reosarevok
        navap, 'Search indexes are updated every 3 hours. If you just added the content you're looking for and you can't find it here, click Search from the top menu and select the \"Direct database search\" option.'
      • 2011-11-01 30532, 2011

      • reosarevok
        ?
      • 2011-11-01 30539, 2011

      • reosarevok doesn't really know how to get fancy :p
      • 2011-11-01 30500, 2011

      • reosarevok
        I mean
      • 2011-11-01 30510, 2011

      • reosarevok
        From this page, they could be searching for a recording or for a release
      • 2011-11-01 30528, 2011

      • reosarevok
        So I don't know if it's even possible to get fancy...
      • 2011-11-01 30554, 2011

      • navap
        hm. Well at least you can make a link to the search page instead of sayig 'click search...'
      • 2011-11-01 30512, 2011

      • navap
        If you open up the template for the menu (root/layout/menu.tt) you'll see how to do tha
      • 2011-11-01 30510, 2011

      • reosarevok
        Ok :)
      • 2011-11-01 30556, 2011

      • navap
        AIDs have started submitting for me again. 
      • 2011-11-01 30506, 2011

      • navap
        That's a bad acronym
      • 2011-11-01 30528, 2011

      • reosarevok
        That it is
      • 2011-11-01 30554, 2011

      • reosarevok
        navap, is there any way to make it select the Direct Database option from the search link?
      • 2011-11-01 30505, 2011

      • navap
        I think you should be able to do this: c.uri_for('/search', { direct = 1 }), but without giving it other parameters the page gives you form errors
      • 2011-11-01 30543, 2011

      • navap
        So I don't know if it's worth it
      • 2011-11-01 30547, 2011

      • reosarevok
        Probably not
      • 2011-11-01 30514, 2011

      • reosarevok guesses if someone is too stupid to click the option he'd be too stupid to read the text anyway
      • 2011-11-01 30545, 2011

      • reosarevok
        So this should be 'Search indexes are updated every 3 hours. If you just added the content you're looking for and you can't find it here, go ' <a href="[% c.uri_for('/search') %]">[% l('to the Search page') %]</a> ' and select the \"Direct database search\" option.'
      • 2011-11-01 30546, 2011

      • reosarevok
        ?
      • 2011-11-01 30556, 2011

      • navap
        Actually there's another way to make a link.
      • 2011-11-01 30514, 2011

      • navap
        l('...go to {url|the search page} and...', { url => c.uri_for('/search')} )
      • 2011-11-01 30527, 2011

      • navap
        Much more compact
      • 2011-11-01 30551, 2011

      • reosarevok
        Can do
      • 2011-11-01 30552, 2011

      • reosarevok
        So all in all: [%- create_guideline(l('Search indexes are updated every 3 hours. If you just added the content you're looking for and you can't find it here, go to {url|the Search page} and select the \"Direct database search\" option.', {url => c.uri_for('/search')})) %]
      • 2011-11-01 30539, 2011

      • navap
        Looks fine
      • 2011-11-01 30545, 2011

      • reosarevok
        Ok :)
      • 2011-11-01 30546, 2011

      • voiceinsideyou1 joined the channel
      • 2011-11-01 30548, 2011

      • ruaok joined the channel
      • 2011-11-01 30532, 2011

      • kepstin-laptop joined the channel
      • 2011-11-01 30500, 2011

      • reosarevok
        Erm
      • 2011-11-01 30509, 2011

      • reosarevok
        What do red lines mean in code review?
      • 2011-11-01 30523, 2011

      • ruaok
        you're about to blow up.
      • 2011-11-01 30526, 2011

      • reosarevok
        red "whitespace"
      • 2011-11-01 30534, 2011

      • reosarevok
        Did I mess something up again? :p
      • 2011-11-01 30535, 2011

      • ruaok
        boom
      • 2011-11-01 30552, 2011

      • reosarevok
      • 2011-11-01 30507, 2011

      • reosarevok
      • 2011-11-01 30516, 2011

      • reosarevok
        If that needs to be fixed somehow let me know :)
      • 2011-11-01 30512, 2011

      • ocharles
        reosarevok: it means whitespace has been deleted
      • 2011-11-01 30516, 2011

      • navap
        You've hit tab on those two lines 
      • 2011-11-01 30525, 2011

      • reosarevok
        Hmm
      • 2011-11-01 30529, 2011

      • reosarevok
        I actually didn't
      • 2011-11-01 30542, 2011

      • reosarevok
        But I copied it from github as a normal text copy-paste
      • 2011-11-01 30547, 2011

      • reosarevok
        So maybe it comes from there :p
      • 2011-11-01 30504, 2011

      • reosarevok
        (or maybe I did that the other time)
      • 2011-11-01 30509, 2011

      • reosarevok
        So should I fix that then? :)
      • 2011-11-01 30558, 2011

      • navap
        If you hilight the text you can see the tab here https://raw.github.com/reosarevok/musicbrainz-ser…
      • 2011-11-01 30508, 2011

      • navap
        I'd leave it be, no big deal
      • 2011-11-01 30517, 2011

      • reosarevok
        Ok
      • 2011-11-01 30518, 2011

      • reosarevok
        :)
      • 2011-11-01 30523, 2011

      • reosarevok
        ocharles, same opinion? :p
      • 2011-11-01 30508, 2011

      • ocharles
        I'd like the tab to be replaced by spaces
      • 2011-11-01 30519, 2011

      • reosarevok
        Ok
      • 2011-11-01 30520, 2011

      • reosarevok
        Can do
      • 2011-11-01 30523, 2011

      • ocharles
        in fact, I'd like that whitespace to be removed entirely :)
      • 2011-11-01 30534, 2011

      • ocharles
        trailing whitespace should not be present
      • 2011-11-01 30519, 2011

      • reosarevok
        Hmm
      • 2011-11-01 30523, 2011

      • reosarevok
        It's not supposed to be trailing
      • 2011-11-01 30527, 2011

      • reosarevok
        It's supposed to be a new line
      • 2011-11-01 30529, 2011

      • reosarevok
        Wayt
      • 2011-11-01 30531, 2011

      • reosarevok
        *wait
      • 2011-11-01 30540, 2011

      • reosarevok
        You mean the new lines should have no spaces in them?
      • 2011-11-01 30552, 2011

      • reosarevok
        Ok :)
      • 2011-11-01 30557, 2011

      • ocharles
        si
      • 2011-11-01 30545, 2011

      • reosarevok
      • 2011-11-01 30529, 2011

      • ijabz
        ocharles: hi u have a minute
      • 2011-11-01 30519, 2011

      • ocharles
        ijabz: sure, what's up?
      • 2011-11-01 30532, 2011

      • djce joined the channel