#musicbrainz-devel

/

      • reosarevok
        (even if you can't actually *name* the sides)
      • 2012-02-15 04624, 2012

      • warp
        yeah. we do need disc sides though. I really want those.
      • 2012-02-15 04631, 2012

      • warp
        but ocharles doesn't like my attempts at making that a more general grouping. so I'm not idea championing that for now until I figure out something else or feel like hammering into ocharles more with what I want for it right now.
      • 2012-02-15 04644, 2012

      • kurtjx_ joined the channel
      • 2012-02-15 04644, 2012

      • kurtjx joined the channel
      • 2012-02-15 04607, 2012

      • ocharles
        well it's not that I don't like it, I just don't think we're "there" yet
      • 2012-02-15 04623, 2012

      • ocharles
        warp: where would be an appropriate place to put renderArtistCredit?
      • 2012-02-15 04659, 2012

      • warp
        ocharles: no idea :)
      • 2012-02-15 04657, 2012

      • warp
        ocharles: in general all this MB.Control stuff needs to go away, it's too tightly coupled to the html.
      • 2012-02-15 04649, 2012

      • warp
        ocharles: if it's really small I'd say common/MB/utility.js. but I expect yours is a bit larger, and so perhaps it should start something new.
      • 2012-02-15 04659, 2012

      • ocharles
        meh, MB.utility for now :P
      • 2012-02-15 04642, 2012

      • warp
        ocharles: why does MBS-842 not depend on MBS-4314 ?
      • 2012-02-15 04624, 2012

      • ocharles
        because you can just enter "AA1" by hand
      • 2012-02-15 04641, 2012

      • ocharles
        in fact you're going to still have to do that if you want "A", "AA" and "B"
      • 2012-02-15 04655, 2012

      • ocharles
        oh, I guess you need a way to declare the order of that, and you don't want to have a separate field
      • 2012-02-15 04658, 2012

      • ocharles
        nvm, I understand now :)
      • 2012-02-15 04604, 2012

      • warp
        cool :)
      • 2012-02-15 04655, 2012

      • voiceinsideyou joined the channel
      • 2012-02-15 04605, 2012

      • warp
        reosarevok: oh, I just realized MBS-842 also mentions disc sides. I thought it was only about an editable tracknumber field.
      • 2012-02-15 04628, 2012

      • warp
        reosarevok: IMO they are different problems, and for now I'm only attacking the editable tracknumber field.
      • 2012-02-15 04635, 2012

      • reosarevok
        Yeah
      • 2012-02-15 04638, 2012

      • reosarevok
        I'd agree
      • 2012-02-15 04656, 2012

      • ocharles
        +1
      • 2012-02-15 04650, 2012

      • reosarevok
        After all, it's not as if, say, discogs marked sides as such
      • 2012-02-15 04658, 2012

      • reosarevok
        They just use A1-An, B1-Bn
      • 2012-02-15 04613, 2012

      • reosarevok
        That's enough to kind-of mark sides
      • 2012-02-15 04626, 2012

      • reosarevok
        (and I'd argue it even resolves that ticket fully)
      • 2012-02-15 04643, 2012

      • reosarevok
        (with a follow-up for a more perfect option maybe)
      • 2012-02-15 04621, 2012

      • warp
        hey, found another thing mysql can do which postgresql cannot. (doesn't happy that often, but when it does it again becomes clear to me that mysql is vastly superior)
      • 2012-02-15 04627, 2012

      • warp
        s/happy/happen/
      • 2012-02-15 04616, 2012

      • warp
        reosarevok: your black/metal edge case already shows that it doesn't solve the ticket fully.
      • 2012-02-15 04640, 2012

      • reosarevok
        warp: it does allow me to mark sides though - 1, 2, 3, n, 1, 2, 3, n
      • 2012-02-15 04646, 2012

      • reosarevok
        It just doesn't allow me to title them yet
      • 2012-02-15 04648, 2012

      • warp
        right.
      • 2012-02-15 04618, 2012

      • reosarevok
        See "The letters mark the sides, which is something we're currently missing"
      • 2012-02-15 04648, 2012

      • reosarevok
        In any case, I care about having the feature, I don't care that much whether it resolves the ticket :p
      • 2012-02-15 04636, 2012

      • nikki
        warp: the ticket should be split
      • 2012-02-15 04654, 2012

      • kurtjx joined the channel
      • 2012-02-15 04655, 2012

      • kurtjx_ joined the channel
      • 2012-02-15 04614, 2012

      • nikki
        ocharles: the diff for http://codereview.musicbrainz.org/r/1789/ doesn't seem to address tabs at all
      • 2012-02-15 04623, 2012

      • reosarevok
        nikki: admittedly tabs are mentioned in comments only, not in the ticlet
      • 2012-02-15 04628, 2012

      • reosarevok
        *ticket
      • 2012-02-15 04637, 2012

      • nikki
        what's the point of commenting on tickets if they don't get read?
      • 2012-02-15 04616, 2012

      • reosarevok
        what I meant is that tabs are not a requirement to resolve that particular ticket
      • 2012-02-15 04625, 2012

      • reosarevok
        (although they'd be nice to have too)
      • 2012-02-15 04625, 2012

      • ocharles
        nikki: it did get read
      • 2012-02-15 04635, 2012

      • ocharles
        and I don't know about tabs, because they are invisible
      • 2012-02-15 04648, 2012

      • ocharles
        so that might lead to confusing behavior
      • 2012-02-15 04600, 2012

      • kepstin-laptop
        well, manually entering tabs in a web browser text field is really hard, and I can't think of anything you'd copy that would contain tabs unless it's from a table format
      • 2012-02-15 04634, 2012

      • nikki
        yeah, exactly
      • 2012-02-15 04659, 2012

      • ocharles
        so am I hearing "please support tabs for this" universally?
      • 2012-02-15 04620, 2012

      • reoexam doesn't oppose it at least, sure
      • 2012-02-15 04624, 2012

      • reoexam
        Bye!
      • 2012-02-15 04641, 2012

      • ocharles
        good luck
      • 2012-02-15 04645, 2012

      • nikki
        (the funny thing is that you can't copy and paste from mb because we use a table and you get tabs which mb doesn't understand)
      • 2012-02-15 04642, 2012

      • ocharles
        heh
      • 2012-02-15 04624, 2012

      • ocharles
        I'm aware all my recent reviews haven't been on test.mb
      • 2012-02-15 04627, 2012

      • ocharles
        do you want them there?
      • 2012-02-15 04629, 2012

      • nikki
        (and before anyone tells me about the "add disc" stuff, that doesn't help when some bootleg is an existing release plus n tracks from another release :P)
      • 2012-02-15 04630, 2012

      • nikki
        yes
      • 2012-02-15 04641, 2012

      • ocharles
        ok, i'll merge them all in now
      • 2012-02-15 04602, 2012

      • nikki
        ideally they'd go straight there once you did the review
      • 2012-02-15 04627, 2012

      • nikki
        I mean, if you want me to test stuff, putting it somewhere so it can be tested is generally a requirement :P
      • 2012-02-15 04627, 2012

      • ocharles
        ideally :)
      • 2012-02-15 04645, 2012

      • ocharles
        well this is why i want to really have it clear how we want to go about having formal testing
      • 2012-02-15 04606, 2012

      • ocharles
        because at the moment everyone is kind of assuming how each other works, and assumptions are wrong or misintepreted
      • 2012-02-15 04650, 2012

      • ocharles
        ok, should all be on test now
      • 2012-02-15 04608, 2012

      • ocharles awaits being told that he broke javascript :P
      • 2012-02-15 04620, 2012

      • nikki
        the lookups don't work at least :P
      • 2012-02-15 04625, 2012

      • ocharles
        ok, so something is broke
      • 2012-02-15 04627, 2012

      • ocharles
        warp: halp!
      • 2012-02-15 04631, 2012

      • ocharles
        what breaks javascript?
      • 2012-02-15 04635, 2012

      • ocharles
        how do I debug it?
      • 2012-02-15 04649, 2012

      • nikki
        but the artist credit stuff opens and closes so it doesn't seem to be everything
      • 2012-02-15 04602, 2012

      • warp
        halp!
      • 2012-02-15 04622, 2012

      • hawke_ joined the channel
      • 2012-02-15 04602, 2012

      • warp
        ocharles: cd root/static/scripts/ ; find . -name "*js" -exec closure-verify {} \;
      • 2012-02-15 04628, 2012

      • warp
        to find trailing comma's mostly.
      • 2012-02-15 04644, 2012

      • ocharles
        where can I find closure-verify?
      • 2012-02-15 04647, 2012

      • warp
        on my gitorious. which is loading slow because I have crappy internet.
      • 2012-02-15 04655, 2012

      • ocharles
        lol
      • 2012-02-15 04605, 2012

      • warp
      • 2012-02-15 04649, 2012

      • kepstin-laptop joined the channel
      • 2012-02-15 04630, 2012

      • ocharles
        cool
      • 2012-02-15 04635, 2012

      • kepstin-laptop joined the channel
      • 2012-02-15 04648, 2012

      • warp
        it will warn about an issue in ./release-editor/MB/TrackParser.js which I still haven't fixed, but isn't causing trouble.
      • 2012-02-15 04613, 2012

      • ocharles
        hmm, I only got that one warning
      • 2012-02-15 04643, 2012

      • warp
        then closure not being able to compile stuff is not the problem.
      • 2012-02-15 04615, 2012

      • ocharles
        nikki: is that the autocomplete boxes being broken?
      • 2012-02-15 04640, 2012

      • nikki
        hm?
      • 2012-02-15 04650, 2012

      • nikki
        gaaaaah
      • 2012-02-15 04659, 2012

      • nikki wishes she'd never wasted her money on this piece of shit mac mini
      • 2012-02-15 04640, 2012

      • nikki
        for some reason downloading a file on the mini is going at 24 kb/s... same file on the macbook right next to it? 1.something mb/s
      • 2012-02-15 04649, 2012

      • ocharles
        weird
      • 2012-02-15 04650, 2012

      • ocharles
        wifi?
      • 2012-02-15 04655, 2012

      • nikki
        both using the wifi
      • 2012-02-15 04659, 2012

      • ocharles
        hm
      • 2012-02-15 04609, 2012

      • nikki
        and it's been happening for ages for various different sites
      • 2012-02-15 04614, 2012

      • ocharles
        nikki: I just wondered what I should be fixing.
      • 2012-02-15 04624, 2012

      • nikki
        the lookup boxes
      • 2012-02-15 04640, 2012

      • nikki
        I type an artist or label and nothing appears
      • 2012-02-15 04648, 2012

      • ocharles
        ok
      • 2012-02-15 04619, 2012

      • ocharles
        my computer can never connect to closure, it's so weird o.O
      • 2012-02-15 04618, 2012

      • ocharles
      • 2012-02-15 04639, 2012

      • warp
        five hundred!
      • 2012-02-15 04634, 2012

      • ocharles
        nikki: give that a sho
      • 2012-02-15 04635, 2012

      • ocharles
        shot
      • 2012-02-15 04650, 2012

      • ocharles
        warp: did you see this arrived this morning? https://lh4.googleusercontent.com/-Rfs7fRqoalE/Tz…
      • 2012-02-15 04651, 2012

      • ocharles
        :)
      • 2012-02-15 04650, 2012

      • warp
        nope
      • 2012-02-15 04632, 2012

      • warp
        now you need more modules and a place to stack them?
      • 2012-02-15 04628, 2012

      • ocharles
        correct
      • 2012-02-15 04647, 2012

      • ocharles
        I have a MIDI->CV converter coming, and an LFO, I still need an oscillator
      • 2012-02-15 04654, 2012

      • ocharles
        and I need some way to connect it to my speakers :)
      • 2012-02-15 04657, 2012

      • ocharles
        oh, and a power supply
      • 2012-02-15 04617, 2012

      • warp
        hah
      • 2012-02-15 04626, 2012

      • warp
        it's like legos for audio geeks!
      • 2012-02-15 04625, 2012

      • ocharles
        that's exactly how I describe it :)
      • 2012-02-15 04620, 2012

      • andreypopp joined the channel
      • 2012-02-15 04609, 2012

      • hawke_ joined the channel
      • 2012-02-15 04627, 2012

      • ruaok joined the channel
      • 2012-02-15 04604, 2012

      • ocharles
        ocharles has changed the topic to: This week's dev chat meeting has been moved to WEDNESDAY, apparently. Agenda: Reviews, Cover Art Archive (ocharles), edit searches (ocharles), beta (ocharles), ocharles stuff - https://gist.github.com/b0fb25133eaa3454a734
      • 2012-02-15 04614, 2012

      • ocharles
        https://gist.github.com/b0fb25133eaa3454a734 is my notes for the meeting as I won't be here
      • 2012-02-15 04617, 2012

      • warp
        oh, hm CAA. I assume there is work I can do for that.
      • 2012-02-15 04623, 2012

      • ocharles
        k, i'm off now, i'll be back about 2130utc I expect
      • 2012-02-15 04603, 2012

      • kepstin-laptop joined the channel
      • 2012-02-15 04618, 2012

      • kurtjx__ joined the channel
      • 2012-02-15 04618, 2012

      • kurtjx_ joined the channel
      • 2012-02-15 04610, 2012

      • bitmap joined the channel
      • 2012-02-15 04603, 2012

      • kurtjx joined the channel
      • 2012-02-15 04604, 2012

      • kurtjx_ joined the channel
      • 2012-02-15 04629, 2012

      • reosarevok
        warp: please do :D
      • 2012-02-15 04656, 2012

      • reosarevok
        Well, I guess we *can* wait, since we are doing it
      • 2012-02-15 04659, 2012

      • reosarevok
        But still
      • 2012-02-15 04643, 2012

      • reosarevok
        Argh more twitter spam
      • 2012-02-15 04652, 2012

      • warp
        spitter twam
      • 2012-02-15 04604, 2012

      • reosarevok
        splitter tw am
      • 2012-02-15 04636, 2012

      • reosarevok shuts up
      • 2012-02-15 04617, 2012

      • ruaok joined the channel
      • 2012-02-15 04623, 2012

      • bitmap joined the channel
      • 2012-02-15 04656, 2012

      • ruaok
        Agenda: Reviews, Cover Art Archive (ocharles), edit searches (ocharles), beta (ocharles), ocharles stuff - https://gist.github.com/b0fb25133eaa3454a734
      • 2012-02-15 04622, 2012

      • ruaok
        feh.
      • 2012-02-15 04626, 2012

      • ruaok
        ruaok has changed the topic to: Agenda: Reviews, Cover Art Archive (ocharles), edit searches (ocharles), beta (ocharles), ocharles stuff - https://gist.github.com/b0fb25133eaa3454a734
      • 2012-02-15 04646, 2012

      • ruaok
        hmm. all the topics are set by ocharles, who can't attend the meeting.
      • 2012-02-15 04607, 2012

      • ruaok
        <BANG>
      • 2012-02-15 04609, 2012

      • ruaok
        meeting time.
      • 2012-02-15 04612, 2012

      • ruaok
        anyone here?
      • 2012-02-15 04631, 2012

      • reosarevok
        ruaok, ocharles said that that github thing was for substituting him in themeeting
      • 2012-02-15 04639, 2012

      • ruaok nods
      • 2012-02-15 04642, 2012

      • reosarevok
        (also, I know ianmcorvidae and nikki are around)