#musicbrainz-devel

i think this is nicer than a column

and I don't have a choice of maximizing my windows, I use a tiling window manager :P

use a different window manager if you don't like how big it makes your windows :P

tiling+++

anyway, it'd be nice to see how it looks both ways in our browsers

http://i.imgur.com/ZU9ez.png is what I have atm

ocharles: are you going for a single colour or different colours for each type?

could be nice if the most common types had unique colours, make the list faster to scan

Wizzcat: a single colour

Agreed it would be nice - maybe ocharles can leave it as a single colour and go work on the next schema change or something and someone else (navap?) can add colours? :D

reosarevok: i'd like to do that, yes :)

http://test.musicbrainz.org/artist/de1edf40-2b3... is what we have now

either way works for me, it's trivial to fix with userjs

Wizzcat: Or, y'know, submitting patches :P

Doesn't look bad!

I am sure some people will be like "we want Compilation out of this", but....

yeah yeah :P

Hmmm

So, ocharles: would you say this is going to ship May15 for sure?

and yes, I think comps and lives need to be split into Live Albu' and 'Compilation albums'

Wizzcat: Maybe that can be done with better filtering later... (and with userjs for now :p)

reosarevok: sure, it's not critical

ocharles: I ask because maybe it's the time to RFC for DJ-Mix as a subtype :)

woo, dj-mix!

Whats the problem with putting secondary types in a separate column, think that would look a lot neater

reosarevok: yes

ijabz: if one release group has a lot of secondary types it creates a big column

and that will affect all other rows

which adds a lot of wrapping for people with small screens

reosarevok: we've announced this schema change has happening, so we have to deliver it now :)

I see

ocharles: bug!

Selecting new (multiple) types deselects main type it seems

Known?

i thought I fixed that

evidently not

so you mean the "Album" bit gets lost?

Yes

Look at the bottom

what type was it before?

Album

(Album, Live)

http://test.musicbrainz.org/edit/16086600 doesn't seem to show the primary type changing and the weird display at http://test.musicbrainz.org/release-group/05739... makes me think it still seems to have a primary type

ocharles: http://test.musicbrainz.org/artist/9bffb20c-dd1... is why I think it might be better right-aligned. as it is, they're all over the place

nope, type has gone in the db too. odd

nikki: they're also all after the name too, though...

nikki: i found it hard to understand with it right aligned, but if people want that then it can be done

(so if you're looking at a discography, you're likely to want to read name + what it is)

Of course it is not so good if you're just looking for live albums

But really, that should be done with a filter

reosarevok: but right now all I see is blue bits all over the page :/

nikki: would using one colour per type help?

if the colours were a lot more subtle, it might. not sure

right now my eyes are just like OMG BRIGHT LET'S LOOK AT IT

i'd rather hand this over to navap now

i don't think it's very productive having me spend a day tweaking CSS

warp: heh, I run out of disk space applying your track changes :)

Project search_server build #134: UNSTABLE in 46 sec: http://ci.musicbrainz.org/job/search_server/134/

Paul Taylor: SEARCH-208:Output release group secondary types for release group searches

Yippie, build fixed!

Project search_server build #135: FIXED in 42 sec: http://ci.musicbrainz.org/job/search_server/135/

ianmcorvidae: I forget... were you working on the timeline schema change?

warp: You here?

adhawkins: yes!

hello!

Hi, the change you committed to the schema last night.

Appears to be adding a language element to a work

correct.

My code already has handling for a work element called language!

your code is from the future!

haha

I did that work on 25th April at 23:00 BST

Or at least, that's when I committed it.

Oh hold on

My browser wasn't showing the latest commit

The latest one is about release groups with multiple types

Secondary type doesn't appear to be defined in the schema?

secondary-type-list contains zero or more secondary-types, but I can't see what a secondary-type is

There does seem to have been some news stuff added to alias as well?

yep

it sounds like the secondary type stuff is buggy then

i'm doing nikki's voting game changes first

:o

Ah, sorry ocharles, didn't realise it was you did that last commit.

Is any of the stuff in the latest commit implemented?

I don't want to miss any of the schema changes, that's why I've been trying to keep on top of them

all of it is

Oh, so is there something missing from the schema?

yea, that def_secondary-type it sounds like

Ah ok.

is there a way to validate a RelaxNG file?

No idea. I've just been reading it myself and adding the new elements

What's the production branch used for?

given the name, I'd /hope/ it matches whatever is running on musicbrainz.org at the moment.

correct

THat's what I thought, but there are a ton of commits in there that haven't been merged into master

also correct

there aren't a 'ton' either, do a git diff master...production and you'll see the differences are minimal

I was going by https://github.com/metabrainz/musicbrainz-serve...

But yeah I just checked the file diffs and they're minimal

ocharles: Got a pointer to something on test.mb.org that I can use to test the new alias elements?

adhawkins: nope, you'll need to edit an alias I think

there's no automatic migration

Umm, how do I do that? :D

go to an artist /aliases page and click "edit" or add a new alias

ocharles: isn't there? Or you mean there's none yet?

(afaik we had mentioned language should become language + primary, which is some level of automigration)

there is that much then

Ok, I'll take a look

Oh, ok :)

Just making sure if you had forgotten that part

Cool! :D

i'm checking now :)

i don't think that's there

no, that's missing, if you're sure that's what we want, then I can add it

nikki, please confirm (but yeah, pretty sure, since that's what the locale thing means now)

hm?

Locale now - locale + primary on test

ocharles: How do I add all the new elements for the alias?

All I've entered is a name and a locale

maybe that work isn't on test yet

ah, it's not

one moment

Grr :)

reosarevok: yes

ocharles: yes, that's what we want :p

ok

ok, it's on test now

My changes don't seem to 'stick'

Set the type, primary, start and end. Says they've been applied, and then when I go back they're not there.

They're in my list of edits as closed.