10:59 AM
ocharles
i think this is nicer than a column
2012-04-27 11810, 2012
11:00 AM
ocharles
and I don't have a choice of maximizing my windows, I use a tiling window manager :P
2012-04-27 11824, 2012
11:00 AM
nikki
use a different window manager if you don't like how big it makes your windows :P
2012-04-27 11846, 2012
11:00 AM
warp
tiling+++
2012-04-27 11856, 2012
11:01 AM
nikki
anyway, it'd be nice to see how it looks both ways in our browsers
2012-04-27 11823, 2012
11:03 AM
ocharles
2012-04-27 11837, 2012
11:04 AM
djce joined the channel
2012-04-27 11843, 2012
11:05 AM
kepstin-laptop joined the channel
2012-04-27 11823, 2012
11:21 AM
reosarevok joined the channel
2012-04-27 11837, 2012
11:25 AM
Wizzcat
ocharles: are you going for a single colour or different colours for each type?
2012-04-27 11808, 2012
11:26 AM
Wizzcat
could be nice if the most common types had unique colours, make the list faster to scan
2012-04-27 11830, 2012
11:27 AM
ocharles
Wizzcat: a single colour
2012-04-27 11835, 2012
11:28 AM
reosarevok
Agreed it would be nice - maybe ocharles can leave it as a single colour and go work on the next schema change or something and someone else (navap?) can add colours? :D
2012-04-27 11856, 2012
11:28 AM
ocharles
reosarevok: i'd like to do that, yes :)
2012-04-27 11805, 2012
11:29 AM
ocharles
2012-04-27 11809, 2012
11:29 AM
Wizzcat
either way works for me, it's trivial to fix with userjs
2012-04-27 11824, 2012
11:29 AM
ocharles
Wizzcat: Or, y'know, submitting patches :P
2012-04-27 11855, 2012
11:29 AM
reosarevok
Doesn't look bad!
2012-04-27 11811, 2012
11:30 AM
reosarevok
I am sure some people will be like "we want Compilation out of this", but....
2012-04-27 11814, 2012
11:30 AM
Wizzcat
yeah yeah :P
2012-04-27 11826, 2012
11:30 AM
reosarevok
Hmmm
2012-04-27 11844, 2012
11:30 AM
reosarevok
So, ocharles: would you say this is going to ship May15 for sure?
2012-04-27 11847, 2012
11:30 AM
Wizzcat
and yes, I think comps and lives need to be split into Live Albu' and 'Compilation albums'
2012-04-27 11813, 2012
11:31 AM
reosarevok
Wizzcat: Maybe that can be done with better filtering later... (and with userjs for now :p)
2012-04-27 11827, 2012
11:31 AM
Wizzcat
reosarevok: sure, it's not critical
2012-04-27 11845, 2012
11:31 AM
reosarevok
ocharles: I ask because maybe it's the time to RFC for DJ-Mix as a subtype :)
2012-04-27 11805, 2012
11:32 AM
Wizzcat
woo, dj-mix!
2012-04-27 11841, 2012
11:32 AM
kepstin-laptop joined the channel
2012-04-27 11801, 2012
11:33 AM
ijabz
Whats the problem with putting secondary types in a separate column, think that would look a lot neater
2012-04-27 11807, 2012
11:33 AM
ocharles
reosarevok: yes
2012-04-27 11825, 2012
11:33 AM
ocharles
ijabz: if one release group has a lot of secondary types it creates a big column
2012-04-27 11832, 2012
11:33 AM
ocharles
and that will affect all other rows
2012-04-27 11840, 2012
11:33 AM
ocharles
which adds a lot of wrapping for people with small screens
2012-04-27 11857, 2012
11:33 AM
ocharles
reosarevok: we've announced this schema change has happening, so we have to deliver it now :)
2012-04-27 11809, 2012
11:34 AM
ijabz
I see
2012-04-27 11855, 2012
11:34 AM
reosarevok
ocharles: bug!
2012-04-27 11807, 2012
11:35 AM
reosarevok
Selecting new (multiple) types deselects main type it seems
2012-04-27 11809, 2012
11:35 AM
reosarevok
Known?
2012-04-27 11815, 2012
11:35 AM
ocharles
i thought I fixed that
2012-04-27 11819, 2012
11:35 AM
ocharles
evidently not
2012-04-27 11824, 2012
11:35 AM
ocharles
so you mean the "Album" bit gets lost?
2012-04-27 11835, 2012
11:35 AM
reosarevok
2012-04-27 11836, 2012
11:35 AM
reosarevok
Yes
2012-04-27 11841, 2012
11:35 AM
reosarevok
Look at the bottom
2012-04-27 11850, 2012
11:36 AM
ijabz_ joined the channel
2012-04-27 11859, 2012
11:36 AM
ocharles
what type was it before?
2012-04-27 11822, 2012
11:37 AM
reosarevok
Album
2012-04-27 11828, 2012
11:37 AM
reosarevok
(Album, Live)
2012-04-27 11832, 2012
11:37 AM
ocharles
2012-04-27 11849, 2012
11:37 AM
nikki
2012-04-27 11805, 2012
11:38 AM
ocharles
nope, type has gone in the db too. odd
2012-04-27 11813, 2012
11:38 AM
reosarevok
nikki: they're also all after the name too, though...
2012-04-27 11827, 2012
11:38 AM
ocharles
nikki: i found it hard to understand with it right aligned, but if people want that then it can be done
2012-04-27 11834, 2012
11:38 AM
reosarevok
(so if you're looking at a discography, you're likely to want to read name + what it is)
2012-04-27 11844, 2012
11:38 AM
reosarevok
Of course it is not so good if you're just looking for live albums
2012-04-27 11851, 2012
11:38 AM
reosarevok
But really, that should be done with a filter
2012-04-27 11805, 2012
11:39 AM
nikki
reosarevok: but right now all I see is blue bits all over the page :/
2012-04-27 11809, 2012
11:39 AM
ijabz joined the channel
2012-04-27 11829, 2012
11:39 AM
reosarevok
nikki: would using one colour per type help?
2012-04-27 11842, 2012
11:39 AM
nikki
if the colours were a lot more subtle, it might. not sure
2012-04-27 11855, 2012
11:39 AM
nikki
right now my eyes are just like OMG BRIGHT LET'S LOOK AT IT
2012-04-27 11813, 2012
11:40 AM
ocharles
i'd rather hand this over to navap now
2012-04-27 11822, 2012
11:40 AM
ocharles
i don't think it's very productive having me spend a day tweaking CSS
2012-04-27 11824, 2012
11:40 AM
ijabz_ joined the channel
2012-04-27 11819, 2012
11:51 AM
ocharles
warp: heh, I run out of disk space applying your track changes :)
2012-04-27 11815, 2012
11:57 AM
MBJenkins
2012-04-27 11816, 2012
11:57 AM
MBJenkins
Paul Taylor: SEARCH-208:Output release group secondary types for release group searches
2012-04-27 11857, 2012
11:57 AM
MBJenkins
Yippie, build fixed!
2012-04-27 11858, 2012
11:57 AM
MBJenkins
2012-04-27 11837, 2012
12:03 PM
djce joined the channel
2012-04-27 11817, 2012
12:14 PM
kurtjx joined the channel
2012-04-27 11800, 2012
12:16 PM
adhawkins2 joined the channel
2012-04-27 11826, 2012
13:05 PM
ocharles
ianmcorvidae: I forget... were you working on the timeline schema change?
2012-04-27 11807, 2012
13:08 PM
kurtjx joined the channel
2012-04-27 11813, 2012
13:10 PM
djce joined the channel
2012-04-27 11800, 2012
13:16 PM
adhawkins
warp: You here?
2012-04-27 11849, 2012
13:19 PM
warp
adhawkins: yes!
2012-04-27 11851, 2012
13:19 PM
warp
hello!
2012-04-27 11803, 2012
13:20 PM
adhawkins
Hi, the change you committed to the schema last night.
2012-04-27 11811, 2012
13:20 PM
adhawkins
Appears to be adding a language element to a work
2012-04-27 11817, 2012
13:20 PM
warp
correct.
2012-04-27 11829, 2012
13:20 PM
adhawkins
My code already has handling for a work element called language!
2012-04-27 11850, 2012
13:20 PM
warp
your code is from the future!
2012-04-27 11854, 2012
13:20 PM
nikki
haha
2012-04-27 11800, 2012
13:21 PM
adhawkins
I did that work on 25th April at 23:00 BST
2012-04-27 11805, 2012
13:21 PM
adhawkins
Or at least, that's when I committed it.
2012-04-27 11811, 2012
13:22 PM
adhawkins
2012-04-27 11858, 2012
13:22 PM
adhawkins
Oh hold on
2012-04-27 11811, 2012
13:23 PM
adhawkins
My browser wasn't showing the latest commit
2012-04-27 11821, 2012
13:23 PM
adhawkins
The latest one is about release groups with multiple types
2012-04-27 11850, 2012
13:24 PM
adhawkins
Secondary type doesn't appear to be defined in the schema?
2012-04-27 11811, 2012
13:25 PM
adhawkins
secondary-type-list contains zero or more secondary-types, but I can't see what a secondary-type is
2012-04-27 11813, 2012
13:27 PM
adhawkins
There does seem to have been some news stuff added to alias as well?
2012-04-27 11846, 2012
13:29 PM
ocharles
yep
2012-04-27 11816, 2012
13:30 PM
ocharles
it sounds like the secondary type stuff is buggy then
2012-04-27 11835, 2012
13:30 PM
ocharles
i'm doing nikki's voting game changes first
2012-04-27 11856, 2012
13:30 PM
nikki
:o
2012-04-27 11809, 2012
13:31 PM
MBChatLogger
2012-04-27 11809, 2012
13:31 PM
adhawkins
Hmm...the schema change has been committed. I thought we'd agreed that meant it was on test.mb.org?
2012-04-27 11839, 2012
13:31 PM
adhawkins
Ah, sorry ocharles, didn't realise it was you did that last commit.
2012-04-27 11804, 2012
13:32 PM
adhawkins
Is any of the stuff in the latest commit implemented?
2012-04-27 11821, 2012
13:32 PM
adhawkins
I don't want to miss any of the schema changes, that's why I've been trying to keep on top of them
2012-04-27 11821, 2012
13:32 PM
ocharles
all of it is
2012-04-27 11848, 2012
13:33 PM
adhawkins
Oh, so is there something missing from the schema?
2012-04-27 11815, 2012
13:34 PM
ocharles
yea, that def_secondary-type it sounds like
2012-04-27 11820, 2012
13:34 PM
adhawkins
Ah ok.
2012-04-27 11824, 2012
13:34 PM
ocharles
is there a way to validate a RelaxNG file?
2012-04-27 11837, 2012
13:34 PM
adhawkins
No idea. I've just been reading it myself and adding the new elements
2012-04-27 11817, 2012
13:42 PM
kepstin-laptop joined the channel
2012-04-27 11845, 2012
13:47 PM
navap
What's the production branch used for?
2012-04-27 11857, 2012
13:48 PM
kepstin-laptop
given the name, I'd /hope/ it matches whatever is running on
musicbrainz.org at the moment.
2012-04-27 11842, 2012
13:49 PM
ocharles
correct
2012-04-27 11843, 2012
13:49 PM
navap
THat's what I thought, but there are a ton of commits in there that haven't been merged into master
2012-04-27 11849, 2012
13:49 PM
ocharles
also correct
2012-04-27 11837, 2012
13:50 PM
ocharles
there aren't a 'ton' either, do a git diff master...production and you'll see the differences are minimal
2012-04-27 11801, 2012
13:51 PM
navap
2012-04-27 11826, 2012
13:51 PM
navap
But yeah I just checked the file diffs and they're minimal
2012-04-27 11807, 2012
13:53 PM
adhawkins
ocharles: Got a pointer to something on
test.mb.org that I can use to test the new alias elements?
2012-04-27 11808, 2012
13:53 PM
MBChatLogger
2012-04-27 11830, 2012
13:53 PM
ocharles
adhawkins: nope, you'll need to edit an alias I think
2012-04-27 11834, 2012
13:53 PM
ocharles
there's no automatic migration
2012-04-27 11842, 2012
13:53 PM
adhawkins
Umm, how do I do that? :D
2012-04-27 11855, 2012
13:53 PM
ocharles
go to an artist /aliases page and click "edit" or add a new alias
2012-04-27 11835, 2012
13:55 PM
reosarevok
ocharles: isn't there? Or you mean there's none yet?
2012-04-27 11854, 2012
13:55 PM
reosarevok
(afaik we had mentioned language should become language + primary, which is some level of automigration)
2012-04-27 11805, 2012
13:56 PM
ocharles
there is that much then
2012-04-27 11807, 2012
13:56 PM
adhawkins
Ok, I'll take a look
2012-04-27 11817, 2012
13:56 PM
reosarevok
Oh, ok :)
2012-04-27 11823, 2012
13:56 PM
reosarevok
Just making sure if you had forgotten that part
2012-04-27 11825, 2012
13:56 PM
reosarevok
Cool! :D
2012-04-27 11833, 2012
13:56 PM
ocharles
i'm checking now :)
2012-04-27 11849, 2012
13:56 PM
ocharles
i don't think that's there
2012-04-27 11830, 2012
13:57 PM
ocharles
no, that's missing, if you're sure that's what we want, then I can add it
2012-04-27 11810, 2012
13:58 PM
reosarevok
nikki, please confirm (but yeah, pretty sure, since that's what the locale thing means now)
2012-04-27 11830, 2012
13:58 PM
nikki
hm?
2012-04-27 11805, 2012
13:59 PM
reosarevok
Locale now - locale + primary on test
2012-04-27 11801, 2012
14:00 PM
adhawkins
ocharles: How do I add all the new elements for the alias?
2012-04-27 11806, 2012
14:00 PM
adhawkins
All I've entered is a name and a locale
2012-04-27 11852, 2012
14:00 PM
ocharles
maybe that work isn't on test yet
2012-04-27 11809, 2012
14:01 PM
ocharles
ah, it's not
2012-04-27 11810, 2012
14:01 PM
ocharles
one moment
2012-04-27 11837, 2012
14:02 PM
adhawkins
Grr :)
2012-04-27 11859, 2012
14:09 PM
nikki
reosarevok: yes
2012-04-27 11813, 2012
14:10 PM
reosarevok
ocharles: yes, that's what we want :p
2012-04-27 11813, 2012
14:12 PM
ocharles
ok
2012-04-27 11832, 2012
14:12 PM
ocharles
ok, it's on test now
2012-04-27 11842, 2012
14:15 PM
adhawkins
My changes don't seem to 'stick'
2012-04-27 11847, 2012
14:15 PM
adhawkins
2012-04-27 11805, 2012
14:16 PM
adhawkins
Set the type, primary, start and end. Says they've been applied, and then when I go back they're not there.
2012-04-27 11828, 2012
14:16 PM
adhawkins
They're in my list of edits as closed.
