or id = any(array[1, 2, 3]) perhaps, I forget array syntax
2012-05-21 14244, 2012
warp
ah, right. '{ works.
2012-05-21 14226, 2012
ocharles
cool
2012-05-21 14236, 2012
warp
so how is that different from id IN (1, 2, 3) ?
2012-05-21 14209, 2012
ocharles
warp: to do that you need to generate n placeholders, and then provide n parameters
2012-05-21 14228, 2012
ocharles
I find it much more convenient to provide 1 query parameter
2012-05-21 14248, 2012
warp
ok, so that's the only difference?
2012-05-21 14254, 2012
ocharles
yea
2012-05-21 14259, 2012
warp is just trying to understand it :)
2012-05-21 14205, 2012
ocharles
it's especially simpler in this example though, because we repeat that set of ids twice
2012-05-21 14214, 2012
warp
sure
2012-05-21 14215, 2012
ocharles
so that code would get quite unweildly having to call ' . placeholders(@ids) . ' twice
2012-05-21 14202, 2012
warp
ocharles: I'm still not understanding something, that delete always seems a no-op.
2012-05-21 14229, 2012
ocharles
it will be a no-op if there are no release group types to merge
2012-05-21 14247, 2012
ocharles
if you have rg1=(live, remix) and rg2=(live), one of those live attributes will be deleted
2012-05-21 14220, 2012
ocharles
What we're doing here is filtering changing the bag of release group types over all release groups being merged into a set of release group types, and then we can safely move each release group type to be on the 'new' release gorup
2012-05-21 14245, 2012
warp
delete from release_group_secondary_type_join all those rows for which the secondary type does not occur within itself.
2012-05-21 14208, 2012
warp
I'm parsing something wrong, or the query is wrong.
2012-05-21 14244, 2012
ocharles
oh, the query is indeed wrong (:
2012-05-21 14200, 2012
ocharles
the where clause should be on release_group_secondary_type_join (secondary_type, release_group)
2012-05-21 14210, 2012
ocharles
but distinct on just secondary_type
2012-05-21 14215, 2012
ocharles
So...
2012-05-21 14233, 2012
ocharles
WHERE ... AND (release_group, secondary_type) NOT IN (SELECT DISTINCT ON (secondary_type) relaese_group, secondary_type ... )
2012-05-21 14241, 2012
warp
ok, now I get a result when I select the query.
2012-05-21 14243, 2012
warp
thanks :)
2012-05-21 14244, 2012
ocharles
cool
2012-05-21 14247, 2012
ocharles
we got there in the end :)
2012-05-21 14251, 2012
ocharles
thanks for reviewing my review :P
2012-05-21 14205, 2012
warp
haha, np.
2012-05-21 14225, 2012
VectorX
in the edit table, what do the values of status mean ?
DETAIL: Key (id)=(1) already exists. at lib/Sql.pm line 103, <FILE> line 1.
2012-05-21 14251, 2012
warp
I always get this kind of stuff, and I never understand it.
2012-05-21 14215, 2012
warp blindly resets sequences.
2012-05-21 14248, 2012
warp jumps to conclusions :)
2012-05-21 14251, 2012
ocharles
warp: if you run all tests you have to create_test_db first
2012-05-21 14200, 2012
ocharles
if you only run edits.t you should only have to run it once
2012-05-21 14209, 2012
warp
ocharles: I often get it when changing tests even after a create_test_db run. in this case the sequence wasn't a problem, I just mucked up the sql, hence "jumps to conclusions" :)
2012-05-21 14215, 2012
ocharles
heh
2012-05-21 14224, 2012
warp
ocharles: btw, the artist and label merges probably need similar changes to what I'm doing now.
2012-05-21 14258, 2012
warp
(in Data::IPI::merge)
2012-05-21 14200, 2012
ocharles
yep
2012-05-21 14204, 2012
ocharles
wanna go ahead and do that?
2012-05-21 14212, 2012
warp
but I'll do that in a separate patch.
2012-05-21 14221, 2012
ocharles
sounds good
2012-05-21 14235, 2012
warp
yeah, sure. I'm going to push this to code review now, then I can do those.
2012-05-21 14233, 2012
warp
bah. new code review is very buggy.
2012-05-21 14237, 2012
ocharles
deleting your comments too?
2012-05-21 14251, 2012
warp
yes.
2012-05-21 14223, 2012
warp
well, I pasted my comment, and I need to trigger a keystroke in the textarea before code review is aware that there is data there. just the paste event is not enough.
2012-05-21 14205, 2012
ocharles
yea
2012-05-21 14207, 2012
ocharles
i found that
2012-05-21 14231, 2012
warp
I had some issues before where certain keys just didn't work in the textarea, I couldn't type some letters.
2012-05-21 14223, 2012
warp
(but I just wrote/deployed an ~/.XCompose file which is also causing some issues, so I'm not always certain where the problem originates :)
2012-05-21 14246, 2012
warp takes a break.
2012-05-21 14212, 2012
adhawkins
ocharles: The image IDs for cover art, I assume they are always unique?
2012-05-21 14217, 2012
adhawkins
Or are they unique per release?
2012-05-21 14254, 2012
ocharles
adhawkins: they are unique
2012-05-21 14202, 2012
ocharles
(over all ids)
2012-05-21 14206, 2012
adhawkins
Ok.
2012-05-21 14220, 2012
adhawkins
Just thinking about how to handle multiple images in flactag.
2012-05-21 14228, 2012
adhawkins
Currently it only has one per FLAC file.
2012-05-21 14244, 2012
adhawkins
However if I'm going to put all of them in, I need to be able to tie up which one is which when checking for changes.
2012-05-21 14213, 2012
adhawkins
Is there any concept of 'editing' an image? Or do they just get added and deleted?
2012-05-21 14231, 2012
ocharles
The metadata can be added, the artwork cannot
2012-05-21 14240, 2012
ocharles
when we add support for replacing images, we will be using a new ID
2012-05-21 14257, 2012
adhawkins
Ok, so (for example) uploading a new front cover will cause a new ID to be generated?
2012-05-21 14232, 2012
ocharles
yea
2012-05-21 14259, 2012
adhawkins
Ok, think I've got it straight in my head then. Need to come up with a way of mapping the CAA image ID to an image in a FLAC file then.
2012-05-21 14212, 2012
adhawkins
There is a description field for each image, I guess I could hijack that.
2012-05-21 14206, 2012
Swarup joined the channel
2012-05-21 14216, 2012
Swarup
hi..after upgrade and startup of mb servers..getting this memcache error in logs though request is getting processed.. [error] Caught exception in engine "Can't locate object method "forget_dead_hosts" via package "Cache::Memcached::Fast" at local/lib/perl5/Cache/Memcached/Managed.pm line 765."
2012-05-21 14245, 2012
Swarup
is it of any concern?
2012-05-21 14248, 2012
ocharles
Swarup: yea
2012-05-21 14204, 2012
ocharles
Change the reference of Cache::Memcached::Fast to Cache::Memcached in your DBDefs
2012-05-21 14210, 2012
ocharles
we should get that out our default config, because it's broken
2012-05-21 14217, 2012
Swarup
ha ok
2012-05-21 14255, 2012
hawke_1 joined the channel
2012-05-21 14215, 2012
ocharles
4 unit tests to go and then I can actually start trying to fix this bug
2012-05-21 14225, 2012
ocharles
what a productive day...
2012-05-21 14219, 2012
andreypopp joined the channel
2012-05-21 14244, 2012
voiceinsideyou1 joined the channel
2012-05-21 14216, 2012
plaintext joined the channel
2012-05-21 14212, 2012
ianmcorvidae joined the channel
2012-05-21 14218, 2012
Leftmost joined the channel
2012-05-21 14228, 2012
ruaok joined the channel
2012-05-21 14213, 2012
ruaok joined the channel
2012-05-21 14240, 2012
ruaok joined the channel
2012-05-21 14233, 2012
Prophet5 joined the channel
2012-05-21 14213, 2012
ruaok
ruaok has changed the topic to: agenda: review, artist page fixes (ruaok)
2012-05-21 14250, 2012
Prophet5 joined the channel
2012-05-21 14237, 2012
ianmcorvidae
Mineo: since rika uses data dumps, nobody's set to AE -- if you need that on the slave DB I can make it happen, otherwise set it yourself on the static one
2012-05-21 14253, 2012
ianmcorvidae
Mineo: and until yesterday nginx was off on rika since the databases were updating; should be back now
2012-05-21 14214, 2012
ruaok
ruaok has changed the topic to: agenda: review, artist page fixes (ruaok), forums (ruaok), bug triage (ruaok)
2012-05-21 14234, 2012
ocharles
ruaok: scheduling.ocharles is offline atm
2012-05-21 14243, 2012
ruaok
k
2012-05-21 14245, 2012
ocharles
just to make sure you're aware of that
2012-05-21 14252, 2012
ruaok
another good reason to address it in the meeting.
2012-05-21 14255, 2012
ocharles
though I could bring it up on my other server actually
2012-05-21 14258, 2012
ocharles
alrighty
2012-05-21 14218, 2012
ruaok
have seen mr 2099 freaking out on our blog?
2012-05-21 14237, 2012
ocharles
si
2012-05-21 14239, 2012
ruaok
k
2012-05-21 14241, 2012
ocharles
don't really see point in responding
2012-05-21 14256, 2012
ruaok
yeah, its just froth.
2012-05-21 14207, 2012
ruaok
but, a solution should be very high on your priorities list.
2012-05-21 14214, 2012
ruaok
but I suspect you know that. >)
2012-05-21 14216, 2012
ruaok
:)
2012-05-21 14237, 2012
ruaok
ianmcorvidae: I'm kinda stuck with the forums box.
2012-05-21 14254, 2012
ruaok
I ordered a raid card that should've been compatible with the box, but it didn't fit.
2012-05-21 14206, 2012
ruaok
have you got any experience with raid cards?
2012-05-21 14209, 2012
ianmcorvidae
not really, no
2012-05-21 14239, 2012
ianmcorvidae
the one I've ever tried to use didn't actually hold configurations :P
