#musicbrainz-devel

I'll filter Various artists out the next time

top in what sense. most requested through the webservice?

heh so out of touch never heard of Mz Bratt

artists that have their mbids the most in nginx log

but 99% of that are requests through the ws

ijabz: you're not the only one. of the top artists I have never heard of "Terri Hooley", "Mz. Bratt", and "Adele".

I don't know Terri hooley either, but Adele is probably no1 star in UK for last year

ijabz: out of the top release groups I only know the two linkin park ones at the bottom.

I'm really confused on why Terri Hooley is #2

most of the release groups are from coldplay and adele

it'd be nice if the release group's artist was shown

good idea

plaintext: it'd be nice if you add a short sentence answering the "top of what?" question. (i.e. explaining that it is requests to musicbrainz.org)

warp: do you mean a description for the category?

plaintext: maybe? I don't know.

yeah, that would make sense

plaintext: just to explain to a visitor what they're looking at.

yeah, it could be misleading if it wasn't there

Terri Hooley had a movie about his life come out recently, but that was months ago I believe. Still confused

warp: the 'x' would be a primary key

ocharles: ok, then you don't have the problem of pages being unpredictable in size.

ocharles: you probably also need an items-before-x to be able to page back.

warp: perhaps. as i said, need more research there, I've never done it before

it also means you can't jump arbitrary distances, which may or may not be a problem

ocharles: I'm used to working with it in couchdb (which doesn't really have unique keys, so you get the unpredictable page size problem).

ah

ijabz: questions answered

ocharles: so I actually maintain a seperate index of which page starts where because I don't want to expose the keys I use for paging in the url :)

ocharles: I added the purple question at the bottom.

warp: yep, watched you type it while I'm eating a Mr. Freeze

(:

Mr. Freeze?

Isn't that Arnie's guy in Batman?

I wasn't 100% sure google docs would show it as me, considering everyone else is still Anonymous User 9000

warp: well, I assumed it was you then

a slushy?

reosarevok: https://www.google.co.uk/search?q=mr+freeze&... apparently

nikki: those things that are liquid and you freeze them

ooh those

I don't even know what I call those any more

they became massively popular in the office when we found out they are only 15 calories :P

I used to eat tons of them as a kid 'cause they were only 5p from the shop

i had those frozen-milk-on-a-stick things, I forget what they are called

basically ice cream on a stick

I don't know if I ever had those. they never appealed to me

but calling it ice cream is a stretch :P

also I'm jealous, I ate all my ice lollies

ocharles: haha

ocharles: I guess they are mostly water with only a bit of sugar/flavouring.

chemical*

but yea

all of them

E numbers! panic! :P

this one has "tropical" flavouring

:)

awesome

I always wanted the cola ones.

yay freezies

the plastic on those freezepops would always cut the sides of my mouth. maybe it was just the brand that was shoddy

or you were doing it wrong

am I the only one who never liked eating ice with some flavouring?

yes. weirdo

haha

it was always awesome when someone had one of the giant freezies, so much cooler than the little ones :)

bitmap: I don't think I would cut my mouth, but it was often quite sharp

awesome, the mini-fridge at work has a freezer section. I should pick some up.

You have a mini-fridge at work? With free stuff?

Duh, why can't I get that working from home! :p

occasionally, yeah.

it's a pretty small company, just 10 of us right now.

MB is not *that* smaller! I demand free stuff in my fridge! :p

reosarevok: you could try expensing it ;)

lol "expensing it"

you act like MB has expense accounts :P

ianmcorvidae: I suggest we ask for donations for candy

however, you could possibly buy yourself a mini-fridge and put things in it and deduct the costs from your taxes :P

does food count as a deductable expense?

i guess if the company is providing lunch every day it could

probably not, really, I was just kidding around :)

ocharles: in general, not.

s/t//

ocharles: at least, here in .nl the tax office considers food for employees to be a specific compensation, somewhat similar to wages/salary.

ijabz: "If its not part of this proposal then it should be altered to represent what the propsal is" -- I don't know where I said it was.

warp: ah

ocharles: a self-employed business-owner is (in general) now allowed to consider lunches and such as a business expense.

ocharles:in the example query and the statement The important thing to note is that the ‘result’ field contains the exact same data you’d be given back from findArtist

s/now/NOT/

or are you saying not everything in the doc is part of the proposal ?

ijabz: there's no reason that data can't come from the Lucene server

I didn't say where it came from, only that it should correspond to what findArtist returns

Well how the webservice construct the data currently returned , if the searchArtists method only returns one of it

s/one/part

sorry, still not following...

ocharles: so NES is part of or atleast exposed through the data access layer. NES is not built on top of the data access layer.

correct?

warp: correct, because NES is so fundamental to our storage

that was my main question there :)

ok, hopefully i've answered it then

ocharles: yes.

ws/2//release/search returns search results consisting of releases with a ceraina about of detail i.e http://musicbrainz.org/ws/2/release/?query=fred

right

the information in a release element is different to the details you would return with the findByRelease() method

so yes, when returning the search result to the client, that information would be discarded

we could expand the type returned by the search result if we wanted to be the product of Artist, ArtistAlias etc

i think i explained my point incorrectly. it was more that whatever data it returns must also be in the same format as data type from other (database accessing methods)

it could be a tuple of artist, artist aliases, artist tags, for example

ocharles: why would a server be different from a library approach (for this NES question) ?

warp: well, you can't pass a higher order function in for one

you'd probably do it be requesting a revision token or something, making adjustments there, and then 'publishing' the revision

hm, sounds pretty horrible to me, Id much prefer to pass object that represent the existing MMD, and then just fill in as rehired. i.e findbyArtist() returned would return a simple artist, with empty alias list, whereas the search would return the artist with the alias list filled in

You /could/ have an Artist object with a list of aliases, but the problem is you now have to check 'is artist.aliases defined?'

ocharles: hm, it isn't clear to me why that would be neccesary, but I guess I'd have to know more about NES to understand that aspect.

thus you have to work around it possibly being null all over the place

warp: mostly because a revision can be the result of multiple operations

thus multiple requests

ocharles: ah, because editing is also granular. so I cannot just make all the changes on my side of the data access layer and then submit that revision in one go?

warp: hm, that's also an option

you could return all data of an artist, and then put all data of an artist back to create the revision

ocharles: that is how I'd imagine an editable webservice to work.

s/to/would/

web service != data access layer though, just to point that out

yes, I know.

You just need to know what the function does i.e. if I call findByArtist() it doesn't return aliases if do searchByArtiists() it does

ijabz: that's great for humans, but that doesn't translate to code

you either have aliases by either null, or a list, or you always have it as a list, but sometimes an empty list might mean 'this hasn't been loaded' and thus the burden is on the programmer

or you separate objects and construct just what you need, guaranteeing its presence

Well it does, that is what we currently have , looking at a release returned by search is different to a release retrieved by a lookup, I don't find it a burden

having to reconstrue the tuples into a single object is a lot more work

woah, you've all been busy on code review again.

warp: we're very busy atm :)

ocharles: I was on there just this morning!

warp: http://tickets.musicbrainz.org/browse/MBS-5146 can you submit a bug report to your country for having an overly verbose language?

ocharles: let's just all switch to hanza

hanzi

ok, that's enough tech discussion, time to write some codez\

ocharles: not that I disagree, but the only sites which account for more than 1% of urls are discogs, amazon, wikipedia, myspace and facebook, so by that measure most of our existing cleanups wouldn't meet that criteria either :P

(of course, that's largely because 80% of our urls are those five sites)

hm, fair enough

do you think I should keep them closed?

(bunch of unused functions in there, and most of the rest were untested)