ianmcorvidae: It's a long time since I wrote the discid generation code in flactag, so I couldn't remember exactly how it's derived :)
2012-10-12 28631, 2012
adhawkins
I'd forgotten there was an sha1 in there.
2012-10-12 28632, 2012
ianmcorvidae
libdiscid is the recommended method anyway
2012-10-12 28640, 2012
ianmcorvidae
so if you used that you wouldn't have seen that anyway
2012-10-12 28642, 2012
adhawkins
I might actually be using that thinking about it!
2012-10-12 28613, 2012
adhawkins
So are you saying that (for example) flactag should be passing in the toc as well when it does the discid lookup?
2012-10-12 28622, 2012
ianmcorvidae
yes!
2012-10-12 28632, 2012
adhawkins
Aha, that's new. I'd better add that to my TODO list :)
2012-10-12 28657, 2012
ianmcorvidae
I don't know when that was added; it's certainly not well-advertised
2012-10-12 28608, 2012
ianmcorvidae
but you will get better results if you do, for things that don't have discids already
2012-10-12 28611, 2012
ianmcorvidae
so you should do it :)
2012-10-12 28633, 2012
adhawkins
Do I know that there's been a fuzzy match in the response? (As opposed to a 'definite' match on the discid)?
2012-10-12 28635, 2012
ianmcorvidae
bonus: it means we know someone who's using that feature, and provides a route for bug fixes on that feature to end up on our plate :P
2012-10-12 28642, 2012
ianmcorvidae
not sure
2012-10-12 28649, 2012
ianmcorvidae
I'm about to go look at the code
2012-10-12 28611, 2012
adhawkins
Because it'd probably be a good idea for flactag to say "I've found these matches, but they weren't on discid, you might still want to submit the discid"
2012-10-12 28659, 2012
ianmcorvidae
hm, I don't see anything that would disambiguate
2012-10-12 28612, 2012
adhawkins
There was talk of putting in a percentage match or something?
2012-10-12 28654, 2012
adhawkins
I think there was a ticket for it somewhere...
2012-10-12 28603, 2012
ianmcorvidae
currently it uses a hardcoded value of 10000
2012-10-12 28618, 2012
ianmcorvidae
the significance of which I don't totally understand because it's passed to the postgresql cube extension
2012-10-12 28636, 2012
ocharles
good morning
2012-10-12 28613, 2012
ocharles
ianmcorvidae: iirc, that means 10 seconds leeway
2012-10-12 28627, 2012
ianmcorvidae
yeah
2012-10-12 28645, 2012
ianmcorvidae
the create_bounding_cube function is rather long
2012-10-12 28653, 2012
ianmcorvidae
I was working through it slowly :)
2012-10-12 28646, 2012
ianmcorvidae
adhawkins: one hack, though, is that the discids are returned in the result
2012-10-12 28658, 2012
ianmcorvidae
adhawkins: so you can assume it's a fuzzy match if the discid you passed in isn't one of the ones in the release
was a rather subtle thing involving postgresql's user-space spinlocks and kernel logic for balancing processes between processor cores but trying to keep processes on shared cache if possible.
2012-10-12 28628, 2012
kepstin-work
which ended up bouncing the postgresql threads between cores too much
2012-10-12 28634, 2012
CatBuss joined the channel
2012-10-12 28620, 2012
ocharles
kepstin-work: yea, I saw that
2012-10-12 28619, 2012
kepstin-work joined the channel
2012-10-12 28648, 2012
hawke_1 joined the channel
2012-10-12 28609, 2012
hawke joined the channel
2012-10-12 28636, 2012
nikki joined the channel
2012-10-12 28624, 2012
djce joined the channel
2012-10-12 28601, 2012
Freso joined the channel
2012-10-12 28635, 2012
ijabz joined the channel
2012-10-12 28627, 2012
MBJenkins
ollie: Various schema change process improvements:
