#musicbrainz-devel

you're driving from SLO tomorrow?

friday.

which means, yes.

it just turned thursday here

hah, yeah.

is ocharles driving with us as well?

no clue.

I have no idea where is at or how to reach him.

he is currently in san francisco, he was on irc a few hours ago.

I got that much, ya.

he'll soon realize that he needs a ride to the south bay. :)

ocharles: take bart to SFO and be at SFO at… 1800

that should work out ok.

well, he can always take the bus

;)

you mean three buses. :)

Does BART even run that late?

or 5

ruaok: it was three for me last year, yes

at 6pm?

yes.

from SFO to sunnyvale.

Oh 1800 gods, I'm tired.

I guess he can bart to milbrae and catch a bus from here

OOW10 I got caught out because I was a train and a bus away from my hotel.

"It's only freaking 1AM and the trains stopped?!"

ianmcorvidae: alright, shall we look at that edit stuff before I go all around the city preparing for imminent travel?

nn

goodnight ruaok

warp: yes, lets, if you have a bit of time

ianmcorvidae: have you looked at the code and/or the output?

I've looked at the code, not yet the output

I'm wondering what cross-checking you've done -- how closely have you compared the sets it produces with known problem sets (e.g. what modbot complains about)?

it looks largely obvious and I think we can probably go forward with it, but just for basic checking :)

the query only grabs edits which have a comment":null in the data field, so that should only grab edits which are actually affected.

ianmcorvidae: BTW, I forgot to thank you. That agg exposed a bug I missed.

we have a comment field on many entities, but as far as I can tell the edits are all either $editdata->{comment} or $editdata->{new}->{comment}.

RootWyrm_: hah; well, glad to be of assistance :P

warp: I was just checking that we always double-quote "comment" and that null never has a space before it, looks like we're good on that count though

ianmcorvidae: heh, I don't know if I'd go -that- far.. I don't know that I can FIX the bug. ;(

heh

ianmcorvidae: ah, yes, I assumed encode_json() to be consistent there.

or atleast has been for the past X weeks, because we're only looking at open edits.

yeah, I think we're fine, I just wanted to double-check

you're happy re: data->comment and data->new->comment being the only targets?

it touches 3523 edits on my local dev machine.

3798 here

ianmcorvidae: yes, I checked all the edit types with comment in them ( git grep comment | sed 's/:.*//' | sort | uniq | xargs )

here is your august dump, right?

yeah

beta [at hobbes]:~/musicbrainz-server$ cat changes2.sql | wc 3370 49461 1310238

okay

can we also make a wiki page or such of all affected edits?

and jesus' edit is in there.

running the script and redirecting STDERR to something would probably be sufficient for generating a start of a wiki page

ok, I'm doing that now.

okay, cool

can you copy that to whereever you want it? :)

I think I'm comfortable with running this

ok, then I will run it.

yeah, I'll put it on the wiki so we have somewhere to direct people if questions arise

UPDATE 1

UPDATE 1

etc..

COMMIT

http://wiki.musicbrainz.org/User:Ianmcorvidae/O... though that can probably use improvement

http://musicbrainz.org/edit/19332225 approved.

cool

in 30 minutes hopefully we don't get an email :)

:)

thanks ianmcorvidae

I will now go shower, and then hunt for some chocolate and possibly printer ink

uml_map -fk -i spne.uml -o spne_10182012.xml -xs_spne

Gah.. pardon my mispaste :(

warp: I see the XML schema has changed. Has that code change made it anywhere I can test libmb against?

Can you give me some WS URLs that include these new annotation fields? Ideally one for each if possible.

adhawkins: I think not, MBS-209 is on codereview

Ah ok, so it won't even be on beta yet?

nope

Okey dokey.

Will there be an update to that ticket once it's pushed to beta?

Or should I watch the code review rather than the ticket?

yeah, the ticket should get the In Beta Testing status

the codereview will have more activity, if you operate on the assumption it'll eventually get reviewed :)

Got a link to the codereview? I'll watch that too.

Ta

incidentally, ocharles is already in california for the GSoC mentor summit and warp is leaving to go there soon

the next release is likely to be pretty small

well, and the schema change release was a giant pain in the ass, so we haven't really gotten much done this week, heh

(he optimistically says in the past tense :P)

:p

ianmcorvidae: Are those 'shipits' likely to stop people going back to review?

Not sure how you guys search codereview for things that need reviewing.

I regularly check on things

it's still open, so it's clearly not "done"

Just that ocharles (for example) has already put a 'shipit' on there, so wondered if he might see that and assume he doesn't need to look again?

http://codereview.musicbrainz.org/dashboard/ only lists 28, that's not too bad for keeping in your head

well, I can't speak for the others, but I try to check in on things periodically whether or not I've given them a shippit before

Ok cool. I'll just keep an eye out for it then.

Just want to make sure libmb is updated as soon as possible after this code makes it in.

I'll try to ping you if it gets shipped to test or such (I'm suggesting as much on the ticket now)

Excellent. warp knows I'm watching it ready to do my bit anyway.

Just that as I saw the XML schema change I thought I could now get on and do it.

I could probably put the code in now, then just wait to test until it ships.

What's the URL for the SVN browser at musicbrainz? I thought it was part of trac?

trac.mb.org doesn't seem to work (403)

and yes, that trac.mb doesn't work is silly

Ah

That's better, ta :)

Is there a ticket for that?

It really should

there might have been one?

man, my brain is fried :P

And seems simple enough too

Hmm, wonder if djce is actually the man for that job :p

Hi djce, is it you who can make track.mb.org lead to our trac?

djce knows how to do everything :P

*trac.mb.org obviously

there was once one :P http://bugs.musicbrainz.org/ticket/2895

meh, modbot is back to yelling at us

great

nikki: lol

http://tickets.musicbrainz.org/browse/MBH-250 mentioned on here too

Doesn't sound hugely difficult to me...

Turning off trac would be a bit of a pain.

It's useful for visual diffs on SVN as you mentioned in the ticket.

we should probably migrate whatever's left using svn to git

or deprecate it

not sure what cdlookup even is, libdiscid should get migrated, libmusicbrainz already is, dunno about libmusicbrainz-java

libofa is PUIDs so who cares

libtunepimp is presumably ancient and probably irrelevant

mb2freedb is already on git

search server and the mmd thingy

mb_server/mb_tagger/metabrainz/picard/picard-plugins are all migrated

The schema is the only thing I use that's in SVN and not git