#musicbrainz-devel

yeah, I forgot to change the renderArtistCredit function

removing the () should fix it

I guess that function isn't tested?

(not that I know exactly how to test it, but :P)

I thought it was…but I was thinking of compareArtistCredits

I'll add tests for it

so I should reopen the code review right?

uhhh do whatever ocharles said last time, I totally forget

I don't remember either :)

to chatlogs -- do you remember when that was? XD

within the last two months, if that narrows it down at all :P

heh, I've found where he said not to do what I did last time, but not whether it should be a new review or reopening the old one

anyway do whichever, point out the changes, I'll at least review it quickly

k, I opened a code review here http://codereview.musicbrainz.org/r/2435/

since this is just an issue on beta I guess it doesn't need a ticket either

yeah, I wouldn't worry about it

man, it's really confusing that git://git.musicbrainz.org/picard.git still exists, but is out of date

hopefully git.musicbrainz.org will stop existing soon

except as a read-only mirror of github

heh

other than the fact that I don't want to put it into overwrite mode just yet, because I still have a couple images around that I haven't uploaded yet which are better than what's on caa.

I would also like to see a 'use all image types as filename' so I get files like 'Booklet,Front.jpg' or something... And the ability to have it save images to a subdirectory/with a custom path.

so many hoops to jump through to get audio playback in wine working on this system

I guess that's what I get for shuttling things through multiple emulation layers in sequence :)

whoo, seems to have worked

other than my internet sucking :P

kepstin-laptop nikki https://gist.github.com/3999676 (removed all the risky innerHTML / outerHTML bits)

And more important removed the (MF) out of the catalogue number display so that I can double+click copy catalogue numbers easily and fast as before

http://gist.github.com/3999676 (for chatlogs convenience)

reosarevok: hi, you were wondering where I was ?

Oh hi ijabz!

Yep, did you see my mail?

Mail, I don't recall (Ive been on a mini-holiday)

hello!

ianmcorvidae: https://320x200.org/2012/spotify/

warp: heh :)

Sounds about right for my experience

Obviously I was pretty sure spotify wouldn't have everything I want to listen to

But then, most people listen to more western-mainstream stuff

but this result is quite a bit worse than I expected.

While I have pretty much meh'ed every time I've tried Spotify (I think it had *four* Estonian artists) most of my friends seem to think it's pretty good :p

it will be good to get them to speak MBIDs, to get more reliable results.

heh, yeah

But that still means we need manual matching :p

sure

(also, to get ISRCs :) )

but then I would've fixed the El dueño del sistema example already :)

I wonder if the summit will really last until 21

21?

hours

There seem to be some nice-looking noise shows Thu Fri and Sat at 20...

we did go on for quite a bit in Rotterdam.

Why can't they make that stuff at 22 like normal people

oh, looking at the summit page reminds me I need to check if I still have some wifi routers which can act as a client.

¿?

I imagine the wifi there will be decent...

Ok, I *want to think* the wifi there will be decent :p

reosarevok: ruaok wants to avoid the problem we had in rotterdam

warp: sure, but this isn't an appartment, it's a "professional" conference room...

well, dunno :p

ocharles has changed the topic to: tropical week! | http://musicbrainz.org/#devel | Next meeting: reviews, decoupling search server from web service (ocharles), log analysis project (ocharles), MBS-3665 (ian), nes & 'applied' open edits (ocharles)

how can I access postgres on musicbrainz VM as a superuser? I am trying to install a module but getting the warning that I don't have permission for the untrusted language c

Bookle: ./admin/psql --system

ocharles: heads up! I'm adding tests to coverart_redirect, I'd like to get that on ci.musicbrainz.org when I'm done, so probably next week.

sure thing

need a hand, or are you ok doing it on your own?

I probably need a hand, as I don't see anything documented in syswiki about ci.musicbrainz :)

but not today, I only have a 200 OK test for the index page so far.

ok

well i'll be around all next week as normal

I doubt that.

ocharles: I get "unrecognized option --system"

You shouldn't be around as normal on friday :)

(and parts of thursday)

warp: true :)

Bookle: running ./admin/psql ?

Bookle: I assume you're actually running 'psql --system' ?

I think I'm confused - not that familiar with linux. tried running ./admin/psql directly from bash got "no such file or folder", so went to admin folder and ran psql --system and got "unrecognized option --system"

you need to go to the musicbrainz-server folder

'psql --user postgres' will also work

ah ok, that worked

perfect, installed module now - thanks :)

https://github.com/metabrainz/modbot/blob/maste... hi modbot1

!

:D

modbot don't care bout no vote counters

yet :(

warp: I have support in musicbrainz-data for creating artists, but you don't get an edit for that (so no edit notes yet) - that's the meeting topic I added

however, edit artist does create edits, and can have edit notes

would that give you something to work with?

ocharles: is that the nes modbod?

kepstin-work: si

hmm, so you're making it run continuously but sleeping between runs instead of being started periodically by a cron job?

right, that's the current implementation

open to discussion whether we want that or not

looks like right now it won't stay aligned on e.g. hour intervals, it will drift.. not sure if that's good or bad :)

yea, it can certainly drift

bitmap: http://tickets.musicbrainz.org/browse/MBS-5547

(easily fixable by recomputing the sleep time each loop based on the current time, if desired)

kepstin-work: if I was doing that I'd just use cron rather than reinvent the wheel

i suppose it could be argued that I'm still reinventing the wheel with this polling

reosarevok: noted, thanks

ocharles: sure, hopefully I will have some time to work on this before the summit.

of course if you use cron like that, you have to write some protection to prevent concurrent modbot runs for the off chance that one run goes over time :)

warp: cool, i haven't added anything to the service yet, so hopefully we'll both be online to coordinate what you need

or you can add the end points yourself

kepstin-work: yep, either way you've gotta do some stuff.

i wonder if systemds cron addresses that

ocharles: I have lots of bits and pieces in the air still (known json webservice bugs is what I want to do when I'm done improving coverart_redirect)

cool

ocharles: I'd also like to ship those HTML5 bits ( http://codereview.musicbrainz.org/r/2231/ ) before the freeze.

ocharles: I *think* so, but the systemd repeating job support can't align to the clock.

kepstin-work: even with timer units?

ocharles: yeah, the timer units are relative to either system boot time or unit start time.

yep, just read systemd.unit (5) :)