13:47 PM
alastairp
interesting comment\
2013-03-12 07125, 2013
13:47 PM
JonnyJD
I was kind of suprised (I start using the module for isrcsubmit2)
2013-03-12 07131, 2013
13:47 PM
alastairp
right
2013-03-12 07158, 2013
13:47 PM
alastairp
I guess it's "you eventually get releases"
2013-03-12 07106, 2013
13:48 PM
alastairp
which is why it's get_releases_by_*
2013-03-12 07127, 2013
13:48 PM
JonnyJD
Well, it looks like somebody wrote like "what he needs", not what is provided
2013-03-12 07142, 2013
13:48 PM
JonnyJD
So from the point of a user, not a dev of the API
2013-03-12 07154, 2013
13:48 PM
alastairp
I guess it's because the XML returned from the ws has the <discid> element
2013-03-12 07156, 2013
13:48 PM
alastairp
or whatever
2013-03-12 07110, 2013
13:49 PM
JonnyJD
A specific user, that is. It does get weird when you DO want the discid request
2013-03-12 07117, 2013
13:49 PM
alastairp
hmm, right
2013-03-12 07122, 2013
13:49 PM
alastairp
what else does a discid give you?
2013-03-12 07131, 2013
13:49 PM
JonnyJD
sectors/toc
2013-03-12 07133, 2013
13:49 PM
alastairp
and do you need to inc=releases to make it useful anyway?
2013-03-12 07142, 2013
13:49 PM
JonnyJD
no, releases are implied
2013-03-12 07144, 2013
13:49 PM
alastairp
ok
2013-03-12 07158, 2013
13:49 PM
alastairp
the thing is, I'm not sure a function get_discid() is very useful
2013-03-12 07118, 2013
13:50 PM
alastairp
or maybe we need a get_discid, and a wrapper, get_releases_by_discid that returns just a release list
2013-03-12 07103, 2013
13:51 PM
alastairp
I want to do an api rewrite for 0.5
2013-03-12 07113, 2013
13:51 PM
alastairp
lots of things I want to change/fix
2013-03-12 07147, 2013
13:51 PM
JonnyJD
well, I also need get_releases in terms of actually getting releases, though
2013-03-12 07134, 2013
13:52 PM
alastairp
but you can just use get_release_by_id for that?
2013-03-12 07137, 2013
13:52 PM
JonnyJD
The point is, I access the "release_list" with ["disc"]["release-list"]
2013-03-12 07111, 2013
13:53 PM
JonnyJD
yes, from the technical point it works, after I found out that this gives me the discid, not a release-list
2013-03-12 07126, 2013
13:53 PM
JonnyJD
So this is only a usage issue
2013-03-12 07134, 2013
13:53 PM
alastairp
ok, and the function name made you think it should give you a release-list?
2013-03-12 07141, 2013
13:53 PM
JonnyJD
A relevant one though, since we have no wrapper, but expose the dicts directly
2013-03-12 07146, 2013
13:53 PM
JonnyJD
Yes.
2013-03-12 07156, 2013
13:53 PM
alastairp
if that's the case then my preference would be to have 2 methods ^^\
2013-03-12 07114, 2013
13:54 PM
alastairp
get_discid will give a <discid>, get_releases will parse that and just return the list
2013-03-12 07123, 2013
13:54 PM
JonnyJD
That would work.
2013-03-12 07117, 2013
13:55 PM
JonnyJD
Like I said, I am actually interested in get_releases, it's just that the usage is not at all straightforward.
2013-03-12 07137, 2013
13:55 PM
JonnyJD
Do you open a ticket for 0.5 (api change)?
2013-03-12 07145, 2013
13:55 PM
JonnyJD
Or should I
2013-03-12 07108, 2013
13:56 PM
alastairp
if no one else is using it, I'm happy to break api on the next release
2013-03-12 07111, 2013
13:56 PM
alastairp
file against 0.3\
2013-03-12 07122, 2013
13:56 PM
alastairp
check if beets or headphones use it
2013-03-12 07126, 2013
13:56 PM
JonnyJD
Well, there is samsyo
2013-03-12 07136, 2013
13:56 PM
alastairp
sampsyo: ?? :)
2013-03-12 07143, 2013
13:56 PM
JonnyJD
asampson
2013-03-12 07148, 2013
13:56 PM
JonnyJD
beets dev
2013-03-12 07125, 2013
13:57 PM
JonnyJD
Mineo has a isrcsubmit variant that uses the function, but I guess that is no big deal
2013-03-12 07155, 2013
13:57 PM
alastairp
nothing in beets
2013-03-12 07138, 2013
13:58 PM
alastairp
headphones uses _by_discid
2013-03-12 07153, 2013
13:58 PM
alastairp
no, wait
2013-03-12 07104, 2013
13:59 PM
alastairp
it just has its own copy of mbngs
2013-03-12 07141, 2013
13:59 PM
JonnyJD
Well, then they can decice if they update it or not.
2013-03-12 07119, 2013
14:00 PM
alastairp
so I'm happy to put it in the next release, or wait until the api break release
2013-03-12 07129, 2013
14:00 PM
alastairp
fingers crossed next release will be within in a month
2013-03-12 07128, 2013
14:01 PM
JonnyJD
For isrcsubmit2 I could wrap it (test which dict I get). So it's up to you when to include the API change.
2013-03-12 07135, 2013
14:01 PM
alastairp
k
2013-03-12 07155, 2013
14:01 PM
alastairp
can you remember who the debian maintainer is?
2013-03-12 07101, 2013
14:02 PM
alastairp
I have a bunch of emails from him
2013-03-12 07104, 2013
14:02 PM
alastairp
but can't remember his name
2013-03-12 07109, 2013
14:02 PM
JonnyJD
The earlier it is, the earlier people can adapt and/or start using pymbngs with the new API
2013-03-12 07115, 2013
14:02 PM
JonnyJD
nope
2013-03-12 07136, 2013
14:02 PM
JonnyJD
2013-03-12 07155, 2013
14:03 PM
JonnyJD
For debian you have to check if you want to include it in wheezy or not
2013-03-12 07105, 2013
14:04 PM
alastairp
oh, it was a netbsd guy
2013-03-12 07108, 2013
14:04 PM
alastairp
just replied to him
2013-03-12 07140, 2013
14:04 PM
JonnyJD
Currently the 0.2 API will be in Debian wheezy. (stable)
2013-03-12 07158, 2013
14:04 PM
alastairp
when's wheezy planning to go stable?
2013-03-12 07113, 2013
14:05 PM
JonnyJD
No real plan, but they release RC1 in february
2013-03-12 07122, 2013
14:05 PM
JonnyJD
*released
2013-03-12 07150, 2013
14:05 PM
JonnyJD
so it's like "anytime now"
2013-03-12 07154, 2013
14:05 PM
alastairp
right
2013-03-12 07104, 2013
14:06 PM
alastairp
so 0.3 definitely, probably not 0.4
2013-03-12 07108, 2013
14:06 PM
alastairp
well, definitely
2013-03-12 07110, 2013
14:06 PM
alastairp
hopefully
2013-03-12 07129, 2013
14:06 PM
JonnyJD
2013-03-12 07102, 2013
14:08 PM
alastairp
huh, right
2013-03-12 07109, 2013
14:08 PM
alastairp
let me email Jonas
2013-03-12 07119, 2013
14:08 PM
adhawkins joined the channel
2013-03-12 07147, 2013
14:08 PM
alastairp
he says it's fixed -- is it?
2013-03-12 07159, 2013
14:08 PM
alastairp
or does your patch fix it?
2013-03-12 07112, 2013
14:10 PM
JonnyJD
that is the fix I called "hiding fix"
2013-03-12 07134, 2013
14:10 PM
alastairp
I can't find the debdiff
2013-03-12 07137, 2013
14:10 PM
JonnyJD
I think, checking atm
2013-03-12 07106, 2013
14:11 PM
JonnyJD
2013-03-12 07157, 2013
14:11 PM
JonnyJD
The error is gone, but the includes don't work right, unless given as explicit keyword
2013-03-12 07116, 2013
14:12 PM
alastairp
OK
2013-03-12 07135, 2013
14:12 PM
alastairp
I'm tempted to spin a 0.4 in the next few days then with your current fix, no api change
2013-03-12 07157, 2013
14:12 PM
JonnyJD
Don't rush things though.
2013-03-12 07125, 2013
14:13 PM
JonnyJD
That problem persists for a year already and nobody noticed. So we have enough time for additional review.
2013-03-12 07151, 2013
14:13 PM
alastairp
I'll email Jonas, see what his status is - if he just replied to the morituri bug, or is now a maintainer
2013-03-12 07124, 2013
14:19 PM
alastairp
2013-03-12 07149, 2013
14:22 PM
JonnyJD
No, I don't know.
2013-03-12 07142, 2013
14:23 PM
alastairp
I /suppose/ I could install debian in a vm :-P
2013-03-12 07122, 2013
14:24 PM
JonnyJD
On Arch Linux only "beets" needs python-musicbrainzngs atm. Morituri doesn't (morituri 0.2.0)
2013-03-12 07148, 2013
14:24 PM
alastairp
ok
2013-03-12 07154, 2013
14:24 PM
alastairp
yeah, same in the latest ubuntu
2013-03-12 07135, 2013
14:26 PM
JonnyJD
I also don't have an unstable or testing debian VM atm
2013-03-12 07125, 2013
14:28 PM
alastairp
installing testing now
2013-03-12 07157, 2013
14:36 PM
Ben\Sput joined the channel
2013-03-12 07129, 2013
14:41 PM
alastairp
heh, mirrors on peer'd networks are fast :)
2013-03-12 07132, 2013
14:59 PM
navap
I'm getting a start up error: "encode_base64url" is not exported by the MIME::Base64 module
2013-03-12 07140, 2013
14:59 PM
navap
Any ideas?
2013-03-12 07158, 2013
14:59 PM
warp
navap: yes
2013-03-12 07132, 2013
15:00 PM
warp
2013-03-12 07113, 2013
15:01 PM
hawke_1 joined the channel
2013-03-12 07149, 2013
15:01 PM
navap
Awesome, thanks
2013-03-12 07135, 2013
15:02 PM
hawke joined the channel
2013-03-12 07102, 2013
15:04 PM
alastairp
JonnyJD: ok, finally got experimental merged
2013-03-12 07110, 2013
15:04 PM
alastairp
morituri is an rdepends
2013-03-12 07119, 2013
15:04 PM
alastairp
0.2.0-1
2013-03-12 07125, 2013
15:04 PM
alastairp
only that and beets,though
2013-03-12 07109, 2013
15:05 PM
alastairp
squeeze and sid/wheezy are still at 0.1.2
2013-03-12 07117, 2013
15:05 PM
alastairp
experiemental is 0.2
2013-03-12 07158, 2013
15:05 PM
JonnyJD
2013-03-12 07129, 2013
15:06 PM
JonnyJD
experimental is 0.2-1.1, according do that
2013-03-12 07132, 2013
15:07 PM
alastairp
unless this mirror hasn't updated yet, apt-cache policy says sid has 0.1.2-2
2013-03-12 07145, 2013
15:07 PM
alastairp
oh
2013-03-12 07149, 2013
15:07 PM
alastairp
I mean morituri
2013-03-12 07152, 2013
15:07 PM
alastairp
not pymb
2013-03-12 07159, 2013
15:07 PM
JonnyJD
ah, k
2013-03-12 07157, 2013
15:08 PM
JonnyJD
Yes, that is because of wheezy freeze, I guess. Libdiscid also isn't progressing to unstable.
2013-03-12 07142, 2013
15:10 PM
alastairp
right, yeah
2013-03-12 07148, 2013
15:11 PM
JonnyJD
So that means beets and morituri need to be patched or updated when pymbngs gets into debian etc. with a different (backwards incompatible) api.
2013-03-12 07129, 2013
15:12 PM
alastairp
yes
2013-03-12 07152, 2013
15:12 PM
alastairp
we can submit an issue to them before the release saying the api is changing
2013-03-12 07117, 2013
15:13 PM
alastairp
I may consider bumping the major version so make it clear there's a break
2013-03-12 07121, 2013
15:14 PM
JonnyJD
Yes, that is a possibility.
semver.org says 0.x API isn't supposed to be stable, but pymbngs is already out for some time.
2013-03-12 07134, 2013
15:14 PM
JonnyJD
Libdiscid is also stable in 0.x releases ;-)
2013-03-12 07145, 2013
15:15 PM
JonnyJD
That also means you are supposed to keep making bugfixes for the 0.x branch then.
2013-03-12 07105, 2013
15:16 PM
alastairp
that's exactly what I was thinking of
2013-03-12 07116, 2013
15:16 PM
alastairp
"technically", breaking an api on 0.x is fine :)
2013-03-12 07128, 2013
15:17 PM
JonnyJD
I guess I would have lots of angry mails when I would introduce a backwards incompatibe change in Libdiscid after 7 years :-D
2013-03-12 07104, 2013
15:18 PM
JonnyJD
So much for "technically". You have to talk about that with the beets and morituri devs, I guess.
2013-03-12 07113, 2013
15:19 PM
JonnyJD
For isrcsubmit I kept working on isrcsubmit1, because pymbngs isn't supposed to be stable anyways ;-)
2013-03-12 07122, 2013
15:19 PM
alastairp
sure
2013-03-12 07133, 2013
15:47 PM
Freso_laptop joined the channel
2013-03-12 07145, 2013
15:53 PM
teuf_ joined the channel
2013-03-12 07147, 2013
16:00 PM
Ben\Sput has left the channel
2013-03-12 07100, 2013
16:01 PM
CatCat joined the channel
2013-03-12 07120, 2013
16:23 PM
alastairp
heh, got a nice email from the debian packager
2013-03-12 07134, 2013
16:23 PM
alastairp
saying "how nice that you email the package maintainers after you make a release"
2013-03-12 07154, 2013
16:23 PM
alastairp
it turns out the easy way to do it is to just wait for their magic system to realise there's a new version on pypi
2013-03-12 07130, 2013
16:30 PM
hawke_1
blah, I hate aliases. is “サンセット・フライト” Japanese, or is it English (in katakana script)?
2013-03-12 07142, 2013
16:31 PM
hawke_1
kinda wrong channel but whatever
2013-03-12 07134, 2013
16:33 PM
JonnyJD
alastairp: yes, they have this "watch" file. So after 1-2 days it turns up in the dashboard and possibly they also get a mail. When you send a mail you can tell them about important things though.
2013-03-12 07116, 2013
16:34 PM
JonnyJD
So I also send mails/open update requests for "important releases".
2013-03-12 07136, 2013
16:34 PM
alastairp
right
2013-03-12 07150, 2013
16:34 PM
alastairp
I've sub'd to the package, anyway, so I can see any updates that happen there
2013-03-12 07149, 2013
16:36 PM
CatCat
2013-03-12 07129, 2013
16:37 PM
hawke_1
CatCat: →#musicbrainz
2013-03-12 07130, 2013
16:37 PM
CatCat
sunset fright?
2013-03-12 07138, 2013
16:37 PM
CatCat
what?
2013-03-12 07145, 2013
16:37 PM
CatCat
but you *Asked* here
2013-03-12 07103, 2013
16:38 PM
hawke_1
yeah I re-asked in #musicbrainz
2013-03-12 07105, 2013
16:38 PM
hawke_1
:-)
