JonnyJD: probably. you can look at lib/MusicBrainz/Server/Test/HTML5.pm to see which things we ignore and why
2013-03-18 07737, 2013
warp
JonnyJD: a lot of them are because our RDFa output is still 1.0, not 1.1.
2013-03-18 07715, 2013
JonnyJD
Ah, okay. So that is fine. Not sure though why validator.nu is down and html5.validator.nu is not.
2013-03-18 07758, 2013
Mineo wonders if https://musicbrainz.org/doc/Development/XML_Web_Service/Version_2/Search is one of the pages that need a transclusion editor to update and, if so, if anyone could do that :)
2013-03-18 07739, 2013
warp
Mineo: that looks like the current version. (unless someone secretly transcluded it just now).
2013-03-18 07702, 2013
Mineo
it *is* the current version, but I've updated the included pages
2013-03-18 07727, 2013
reosarevok
Mineo: included pages aren't transcluded
2013-03-18 07736, 2013
reosarevok
(unless I remember this bit wrong)
2013-03-18 07710, 2013
Mineo
I don't know, that's why I'm asking :)
2013-03-18 07722, 2013
nikki
did it change now?
2013-03-18 07722, 2013
reosarevok
Well, does it show your changes?
2013-03-18 07736, 2013
nikki just told it to transclude the same version and doesn't know if that works
2013-03-18 07745, 2013
warp
included pages?
2013-03-18 07746, 2013
Mineo
that's a no for both of you
2013-03-18 07714, 2013
nikki
I have no idea if it's just cached or actually transcluded :(
2013-03-18 07740, 2013
reosarevok
I think it was just cached
2013-03-18 07741, 2013
warp
nikki: can you transclude an older version? (and then put it back to this afterward).
2013-03-18 07758, 2013
reosarevok
warp: look at the code ;)
2013-03-18 07700, 2013
nikki
warp: I guess it'd work, but it's not really a proper solution :P
2013-03-18 07718, 2013
warp
nikki: sure
2013-03-18 07736, 2013
nikki
it's also annoying to do
2013-03-18 07707, 2013
warp
I assume that will reset the cache.
2013-03-18 07727, 2013
Prophet5 joined the channel
2013-03-18 07727, 2013
reosarevok
warp: and thus we still won't know if it's just cached or actually transcluded somehow
2013-03-18 07731, 2013
reosarevok
Just wait until cache expires and check again :p
2013-03-18 07755, 2013
warp
I don't understand what the problem is yet, so cannot say much else on the topic.
2013-03-18 07704, 2013
JonnyJD
Is there anything I need to set up on the VM additionally to make digest auth working? The digest auth tests fail for me (401, rather than 200)
2013-03-18 07723, 2013
ijabz joined the channel
2013-03-18 07734, 2013
reosarevok
warp: that page is including the content of other pages that aren't in the transclusion table
2013-03-18 07743, 2013
reosarevok
warp: those are the pages that changed, not the main one
2013-03-18 07755, 2013
Mineo
JonnyJD: the passwords are probably 'mb' not the real ones
2013-03-18 07704, 2013
JonnyJD
No, I mean in the tests
2013-03-18 07717, 2013
Mineo
ah
2013-03-18 07728, 2013
JonnyJD
When I read the code correctly users are created in the tests, but the access fails anyways.
2013-03-18 07733, 2013
warp
reosarevok: ah, nasty.
2013-03-18 07733, 2013
Mineo
JonnyJD: I didn't say anything then :)
2013-03-18 07718, 2013
warp
JonnyJD: no, I don't remember any of that code needing anything special. I wonder why those tests fail.
ok, and are you sure you have that editor in your database?
2013-03-18 07743, 2013
JonnyJD
the user (my use) exists. I can login at the normal login page
2013-03-18 07749, 2013
ocharles
hm
2013-03-18 07754, 2013
ocharles
what branch are you running?
2013-03-18 07737, 2013
JonnyJD
master d3238e5
2013-03-18 07703, 2013
ocharles
hm
2013-03-18 07710, 2013
nikki
nikki has changed the topic to: 🌅 SUNRISE week | http://musicbrainz.org/#devel | note about meeting time in the US: http://bit.ly/Ym40ql | Agenda: reviews, MBS-5933 (ocharles), code reviewing non-MBS projects (ocharles/warp), MBS-2411 (ocharles)
2013-03-18 07710, 2013
JonnyJD
updated from the latest VM, changed RT_STANDALONE, update scripts were all executed
Nor does he, hence the "can't reproduce it locally"
2013-03-18 07728, 2013
ocharles
at least, that was my understanding
2013-03-18 07742, 2013
nikki
because that character isn't in the list of things it removes. I'm guessing it's one of the other functions that removes unprintable stuff
2013-03-18 07716, 2013
ocharles
I know that
2013-03-18 07731, 2013
ocharles
but maybe the Perl that is running on production is doing something weird
2013-03-18 07747, 2013
nikki
it's probably just older than the version he has locally
2013-03-18 07752, 2013
ocharles
yes
2013-03-18 07759, 2013
ocharles
and so there is more chance it is buggy
2013-03-18 07705, 2013
ocharles
that machine is also not configured how ian's machine is configured
2013-03-18 07710, 2013
nikki
not buggy. just knows about an older version of unicode :P
2013-03-18 07722, 2013
ocharles
how do you know Perl's regular expressions on 5.10 aren't buggy?
2013-03-18 07733, 2013
ocharles
All I'd like him to do is take a look at it
2013-03-18 07700, 2013
ocharles
or say "i dunno ocharles, you look"
2013-03-18 07714, 2013
nikki
I don't know anything for sure, I just think the problem is that we're removing unprintable characters in some other function and those characters are so new that they're being seen as unprintable
2013-03-18 07739, 2013
ocharles
yep, that sounds possible
2013-03-18 07734, 2013
ocharles goes home
2013-03-18 07710, 2013
warp
bye!
2013-03-18 07731, 2013
nikki
perl -C -e 'for $char ("a", "\x{732B}", "\x{20B9}", "\x{20BA}") { print "$char\n" if $char =~ /[[:print:]]/; }' prints the first two for me but not the last two (added in 6.0 and 6.1 respectively)
2013-03-18 07726, 2013
nikki
(that's with 5.10.1 in three places and 5.12 in another)
2013-03-18 07744, 2013
nikki
I guess I run stuff that's too old to have the latest stuff :P
2013-03-18 07741, 2013
nikki
ocharles: when you reappear, can you rerun failed events please?
2013-03-18 07737, 2013
ianmcorvidae
ocharles: the ticket I linked, I realized after, wasn't actually shipped to production when that was filed
2013-03-18 07753, 2013
ianmcorvidae
ocharles: I think it's because of :print: actually, because we're using an older perl before those characters were added
2013-03-18 07712, 2013
nikki
which is what I said :P
2013-03-18 07718, 2013
nikki
ianmcorvidae: can you try that line I pasted?
2013-03-18 07724, 2013
nikki is curious how many work
2013-03-18 07749, 2013
ianmcorvidae
nikki: all three print for me
2013-03-18 07754, 2013
nikki
there's four :P
2013-03-18 07703, 2013
ianmcorvidae
yeah
2013-03-18 07712, 2013
Freso
I see two + the a.
2013-03-18 07716, 2013
ianmcorvidae
I get a 猫 ₹
2013-03-18 07719, 2013
nikki
(the letter a, the kanji for cat, indian rupee sign, turkish lira sign)
2013-03-18 07723, 2013
nikki
ah, so you have 6.0 but not 6.1
2013-03-18 07728, 2013
Freso
v5.16.2
2013-03-18 07744, 2013
ianmcorvidae
5.16.2 here as well
2013-03-18 07755, 2013
Freso
a
2013-03-18 07756, 2013
Freso
猫
2013-03-18 07758, 2013
Freso
₹
2013-03-18 07702, 2013
Freso
^ is what I get.
2013-03-18 07750, 2013
JonnyJD
Do the tests need edits? I get tests 20 and 31 failing, last error:
2013-03-18 07752, 2013
JonnyJD
Failed query:
2013-03-18 07753, 2013
JonnyJD
'UPDATE edit SET status = ?, close_time = NOW() WHERE id = ?'
2013-03-18 07755, 2013
JonnyJD
(2 11)
2013-03-18 07721, 2013
ianmcorvidae
it should tell you *why* that failed, but no -- you should need the edit table, but not edits
2013-03-18 07701, 2013
JonnyJD
Well I have that afterwards: DBD::Pg::st execute failed: ERROR: current transaction is aborted, commands ignored until end of transaction block at lib/Sql.pm line 107, <FILE> line 35.
2013-03-18 07723, 2013
JonnyJD
and that before:
2013-03-18 07724, 2013
JonnyJD
# Failed test 'all'
2013-03-18 07726, 2013
JonnyJD
# at /usr/share/perl/5.14/Test/Builder.pm line 239.
2013-03-18 07717, 2013
JonnyJD
I also have an error where the test gets 403 http code but excpects 401. As I understand these are 2 different failing tests (20 and 31)
2013-03-18 07748, 2013
ianmcorvidae
current transaction is aborted should mean that's not the first failed query
2013-03-18 07748, 2013
CatCat nominates ❄ RANDOM SNOW IN MARCH for the next "freeze" theme
2013-03-18 07713, 2013
CatCat
well amybe to long but i was definitely peeved to see the sudden onslaught of snow again.
2013-03-18 07734, 2013
warp
CatCat: feel free to change the topic.
2013-03-18 07739, 2013
JonnyJD
Hm, "Child (all) exited without calling finalize()" might be the actual problem. That is the last meaningfull I get after test 29 (so that should be the failur in test 31)
2013-03-18 07745, 2013
warp
freeze should have started around 6 hours ago.
2013-03-18 07747, 2013
CatCat
warp: :O
2013-03-18 07752, 2013
ianmcorvidae
that's because of the query failure
2013-03-18 07701, 2013
CatCat
CatCat has changed the topic to: ❄ RANDOM SNOW IN MARCH week | http://musicbrainz.org/#devel | note about meeting time in the US: http://bit.ly/Ym40ql | Agenda: reviews, MBS-5933 (ocharles), code reviewing non-MBS projects (ocharles/warp), MBS-2411 (ocharles)
2013-03-18 07719, 2013
nikki
that's not a unicode character name :(
2013-03-18 07733, 2013
CatCat
oh it went by that?
2013-03-18 07739, 2013
CatCat
snowflake then :/
2013-03-18 07743, 2013
CatCat
or haang on
2013-03-18 07759, 2013
nikki
yeah, the capitals are a convention for unicode character names
2013-03-18 07715, 2013
CatCat
❅ TIGHT TRIFOLIATE SNOWFLAKE
2013-03-18 07734, 2013
nikki
sure XD
2013-03-18 07725, 2013
JonnyJD
"select count(*) from edit;" -> 0 (so the table exists and is empty, for TEST and READWRITE)
2013-03-18 07738, 2013
CatCat
CatCat has changed the topic to: ❅ TIGHT TRIFOLIATE SNOWFLAKE week | http://musicbrainz.org/#devel | note about meeting time in the US: http://bit.ly/Ym40ql | Agenda: reviews, MBS-5933 (ocharles), code reviewing non-MBS projects (ocharles/warp), MBS-2411 (ocharles)
2013-03-18 07703, 2013
nikki
:D
2013-03-18 07726, 2013
Freso
CatCat: :D
2013-03-18 07737, 2013
Freso
"❄ Random Snow in March week" would have worked though.
