-
zag
yeh we are hitting the rate limiter in our testing, and offering to mirror
-
ijabz
The current reosarevok_ server has release events containing just date and area, NO country
-
ocharles
that sounds correct
-
as reosarevok_ is running the areas branch
-
ijabz
Right, so both you and me need to make changes to use area instead of country
-
ocharles
I don't need to make any changes, as ian is handling the merge
-
ijabz
ok, unfortunately I do
-
ruaok starts an export and runs off to meet up with the BMAT guys
-
so that point you made about date should come before country is kind of moot, as there dis no longer country
-
ocharles
ijabz: true
-
but it was invalid within my branch
-
reosarevok_ joined the channel
-
reosarevok_
Of course it failed just when I changed my name
-
Anyway
-
-
ijabz
well it will have to come after the schema release as ian hasn't left me any time to do this, and u still haven't raised an issue
-
reosarevok_ doesn't see how he adding a ticket will make it happen faster, but ok, I will do that
-
reosarevok
Added
-
ijabz
i work from tickets
-
reosarevok
The search server isn't in git yet, right?
-
reosarevok finds svn too confusing to try to do this himself
-
ijabz
not least because it provides a place to spec out the requests, discussions etc
-
reosarevok
Anyway, first I should fix all these tests
-
ijabz
no, thank goodness
-
ocharles
reosarevok: heh, never heard it that way round before :)
-
ijabz
Okay, but if you want to do search server ping me, I can guide you through, its really pretty easy
-
reosarevok
ok! :) I'll finish the broken bits here first
-
But after that I might try :)
-
ocharles: well, that's what I'm used to :)
-
maybe svn is easy, but it looks kinda intimidating
-
ocharles
iirc
-
ijabz
trust me if yo can use git you can use svn, anyway the exact commands you need for search server ar win the readme
-
reosarevok
huh
-
-
reosarevok really wonders wtf is with the docs
-
reosarevok finds more tests that fail because of silly syntax errors he made
-
(on the tests themselves)
-
"
-
meeeh
-
warp
hola!
-
reosarevok
hola warp :)=
-
warp looks at his release editor checklist.
-
Oh, so I need to add ids, huh :)
-
(or fix the ids or something)
-
warp
add ids?
-
zag has left the channel
-
reosarevok
to the html to fix the for thingies
-
warp
ids are not usually mandatory in html :). (though they are often useful for our userscripting friends)
-
ah, for clicking <label>s
-
reosarevok
yep
-
ocharles
meh, /ws/2 doesn't give you enough information to actually display a relationship
-
at least, I don't think there's a way to get a verbose link phrase out of it
-
reosarevok
I think nikki did complain about how sucky ws/2 is for rels, yeah
-
(when trying to do stuff with it a while ago)
-
ocharles
I wanted to use /ws/2 to search for example relationships
-
I may continue to do so, just with a crappy UI - but the UI is for relationship editors anyway so I don't mind shipping something a little rough
-
burrito time now though
-
UmkaDK joined the channel
-
ijabz
-
reosarevok
niiice, now it passes :)
-
function instead" all the time
-
warp
reosarevok: hm, I haven't seen that. perhaps that was recently added to Catalyst.
-
reosarevok
I mean, they work
-
they just say that over and over
-
warp
sure
-
reosarevok fixes a few more issues, re-runs the script
-
warp emacses lib/MusicBrainz/Server/Controller/CDTOC.pm some more.
-
reosarevok
D:
-
he said emacs
-
reosarevok runs away
-
Mineo
-
reosarevok
hah
-
It's been a while since I saw that :)
-
djce joined the channel
-
ocharles
-
warp
what does it do?
-
ocharles
lets you write JavaScript in Haskell, by providing a monad that can be reified and compiled to javascript
-
which is a bit different from the competition, which either try and parse haskell, or literally compile haskell to js
-
So now we have blaze-html, clay and sunroof to build web applications in Haskell, all sharing code and types
-
and aeson for json
-
voiceinsideyou joined the channel
-
warp
ok, that sounds interesting.
-
(I need more time per day)
-
ocharles
if you find some and have too much, i'll take some of that
-
ijabz
and me
-
warp
:)
-
djce joined the channel
-
reosarevok
-
mb-chat-logger
-
reosarevok
Oh, nvm :)
-
that *should* be fine
-
reosarevok wonders why it breaks here then
-
Oh, I see now :)
-
heh, keeps failing but with Can't locate object method "load_with_tracklist_for_recording" now
-
warp
that sounds like my area of breaking stuff
-
reosarevok
I guess we want load_with_medium_for_recording now
-
heh
-
DBD::Pg::st execute failed: ERROR: relation "tracklist" does not exist
-
fiine, not ready yet
-
warp
reosarevok: where/how did you get that? (so I can fix it)
-
reosarevok
Wait, I'm pulling in case it's fixed
-
nope
-
:)
-
There are a few tests
-
warp
hm, t/rdfa/recording/recording-rdfa.t seems to be the only one
-
and perhaps the pgtap things, but I don't know exactly how that stuff works.
-
the others seem unused
-
reosarevok
Well, if unused then we should remove them, right? :)
-
This is the t/lib/t/MusicBrainz/Server/Data/Release.pm one I think
-
warp
yes.
-
Data::Release passes here
-
reosarevok
huh
-
warp
(here being mbs-6023-master in my account on bitbucket)
-
mb-chat-logger
-
reosarevok
I just merged that one in
-
And it still fails here
-
But it fails in more places so I'll start with those
-
Maybe that'll magically fix it :p
-
warp
hrm, I don't know how the t/rdfa/* tests run either.
-
Ben\Sput joined the channel
-
CallerNo6 joined the channel
-
outsidecontext joined the channel
-
reosarevok
huh
-
t::MusicBrainz::Server::Edit::Label::Edit
-
You must specify isni_codes at lib/MusicBrainz/Server/Edit/Role/ValueSet.pm line 18, <FILE> line 6.
-
warp
reosarevok: I think I've done enough release editor testing for now. anything I can do to help with what you're doing?
-
reosarevok
warp: maybe. Try running t::MusicBrainz::Server::Edit::Release::AddCoverArt
-
warp
on which branch?
-
reosarevok
Er, dunno, wherever you have your changes for file types
-
ocharles gets tired of more runtime errors
-
warp
reosarevok: ok
-
warp checks out mbs-4115
-
mb-chat-logger
-
reosarevok
warp: I expect that just requires adding the same line I added to caa.sql to some other file, really
-
(the INSERT INTO cover_art_archive.image_type (mime_type, suffix) VALUES ('image/jpeg', 'jpg'); ) thingy
-
but unsure where
-
warp
reosarevok: possibly, though there may be some fussing with "image/jpeg" not being default for one of the columns.
-
reosarevok
dunno. if you fix it, I'll be happy :)
-
warp
(I wanted it default, ocharles didn't. I think ocharles made a ticket for it, but I cannot quickly find it now)
-
djce joined the channel
-
ZaphodBeeblebrox
well I'd never seen it. agai nand agai nandagain. wtf :D
-
hawke_1 joined the channel
-
reosarevok
ocharles: when you have some time, could you see if t::MusicBrainz::Server::Edit::Label::Edit passes in your ISNI branch in isolation?
-
voiceinsideyou joined the channel
-
hawke joined the channel
-
ocharles
warp: A ticket for it not being default?L
-
I asked for it to not be the default until I gave you an approval on the PR
-
warp
-
ocharles
ah
-
warp
ocharles: the approval was for the version where image/jpeg is not default