I've put the ones I think are more important in the next fix version
2013-07-24 20517, 2013
warp
12 sounds like a lot of work.
2013-07-24 20528, 2013
warp
the others shouldn't be.
2013-07-24 20537, 2013
nikki
and 17 XD
2013-07-24 20547, 2013
nikki
I think that was everything...
2013-07-24 20504, 2013
nikki
now to upload stuff! :D
2013-07-24 20521, 2013
warp
I'm leaving 12 and 17 unassigned
2013-07-24 20526, 2013
nikki nods
2013-07-24 20530, 2013
warp
the other's I will try to fix tomorrow.
2013-07-24 20534, 2013
nikki
great :)
2013-07-24 20538, 2013
warp
s/'//
2013-07-24 20517, 2013
warp runs off to get some dinner
2013-07-24 20524, 2013
nikki
and thanks :D
2013-07-24 20527, 2013
nikki is super excite
2013-07-24 20528, 2013
nikki
d
2013-07-24 20539, 2013
warp
:)
2013-07-24 20543, 2013
nikki
warp: assigned 18 to you too
2013-07-24 20536, 2013
bitmap
ianmcorvidae: (in case you don't see the chatlog) there's two postgres queries on rika that need killing (9212, 9359)
2013-07-24 20506, 2013
bitmap
ianmcorvidae: although it'd be nice to figure out why they're stalled, because this is a common occurrence :/
2013-07-24 20543, 2013
bitmap
aaaand now there's three. they seem to be spawned whenever I try to load a release group page (the query is from load_for_release_groups in lib/MusicBrainz/Server/Data/Artwork.pm)
no slowdown error when I try it now, so I guess I missed it :(
2013-07-24 20538, 2013
nikki tries again
2013-07-24 20536, 2013
nikki
is there a way I can find out what it's returning when it gets stuck?
2013-07-24 20548, 2013
nikki
(I mean, so you know what it should be looking for)
2013-07-24 20513, 2013
warp
I'd like to know what headers and status code it is returning
2013-07-24 20557, 2013
warp
you'd have to open the developer tools of your browser (before the request) and go to the network tab.
2013-07-24 20504, 2013
nikki
the status code should be 503
2013-07-24 20526, 2013
warp
ah, indeed.
2013-07-24 20511, 2013
warp
but the question is whether that 503 makes it to the javascript. if the slowdown doesn't have CORS headers then it will be difficult to deal with it properly.
2013-07-24 20545, 2013
warp
but I should just fake a 503 tomorrow with and without CORS headers and check if it deals with either of them properly.
2013-07-24 20547, 2013
kepstin-work
there should be some event fired due to the request failure...
2013-07-24 20546, 2013
nikki
I seem to have found the network stuff
2013-07-24 20551, 2013
nikki
I'll keep an eye out
2013-07-24 20503, 2013
warp
kepstin-work: if the request is denied because of CORS the browser gives you no information at all. it wouldn't surprise me if no event fired.
2013-07-24 20528, 2013
warp
but anyway, I'll simulate it tomorrow.
2013-07-24 20541, 2013
warp
right now I'm going back to the big blue room.
2013-07-24 20543, 2013
kepstin-work
hmm. the cors check is supposed to be done via a HEAD request prior to doing the real request tho
2013-07-24 20548, 2013
kepstin-work
isn't it?
2013-07-24 20557, 2013
kepstin-work
so the upload won't run unless the cors check already passed
2013-07-24 20542, 2013
kepstin-work could be wrong :)
2013-07-24 20514, 2013
warp
kepstin-work: if the response to the HEAD request had CORS headers that doesn't mean the slowdown response also has CORS headers.
2013-07-24 20546, 2013
warp
any response without CORS headers is something the browser will stay silent about, it will not inform javascript of those response because javascript does not have permission to know.
2013-07-24 20511, 2013
kepstin-work
hmm, you're right, it is supposed to revalidate the access control headers on the response to the real request
2013-07-24 20522, 2013
kepstin-work
according to the cors spec, failing a cors check is supposed to act in the same way as if a network error occurred and the server couldn't be contacted. i think.
2013-07-24 20506, 2013
kepstin-work
(it would probably be worth testing the ajax uploader with an unreachable/offline server too, since that theoretically should use the same error path, I think...)
so instead of having a huge text_strings.tt that we have to manually edit, we could extract the strings directly from the javascript and convert the .po files to json
2013-07-24 20527, 2013
bitmap
which I imagine could be cached the same way text_strings.tt is, if we wanted
2013-07-24 20532, 2013
ianmcorvidae
ocharles: lolo can connect to rika, is what I'd meant, reading the conversation -- reverse tunnel lolo -> rika and then nikki can do a normal forward tunnel to rika
2013-07-24 20548, 2013
nikki
we just used /etc/hosts
2013-07-24 20504, 2013
ianmcorvidae
it looks like it's set, yeah
2013-07-24 20537, 2013
ianmcorvidae
but for everyone's future reference, the way it works is that non-rika stuff can connect to rika but not the other way around
2013-07-24 20505, 2013
ianmcorvidae
e.g. the way I get data dumps onto it is I log into scooby and scp them from scooby -- can't do it from rika, since it can't connect that direction
