#musicbrainz-devel

Does anyone know what song this is? http://youtu.be/7tdlNxw-19k

What is the recommended way to form an edit search URL, like: http://localhost:5000/search/edits?auto_edit_fi... ?

I assume I should use $c->uri_for_action, but how should I form the query parameters?

JesseW_not_logge: I'd look at the stuff for the "refine this search" link, in that one we build it up as a hash of parameters and then pass it along

will check.

can you suggest a file to look in?

Controller::User::Edits or Controller::Role::EditListing, both do that, the URL itself is then built in root/edit/list_header.tt

thanks.

not sure what you're doing, so I don't know if the add to stash/build in the template approach is correct, but that gives you an idea

I'm trying to fix http://tickets.musicbrainz.org/browse/MBS-3346

so I suppose I could create a new action, /edit/between/5/10 and use the approach you mentioned, but I'm not sure it's necessary...

I'd just link to the appropriate edit search, it doesn't need a new endpoint

yes, that seems better

Yay, I've got it working! Now to make the pull request...

and pull request made: https://bitbucket.org/metabrainz/musicbrainz-se...

sooo, a question for you perl guys: https://bitbucket.org/metabrainz/musicbrainz-se... seems to create a copy of the stashs pager, causing $pager->total_entries in line 185 to always be 0 (even if some release groups were loaded in line 178). is there some clever way to make pager only a reference thingie to the stashs pager or

a backslash is usually used to get a reference, so \$c->stash->{pager} might work, although I'm not really sure

thanks

although I've noticed that an easier solution seems to be to just use the length of $release_groups

the former :)

"\$c->stash->{pager}" and I wonder why people think perl is not a "nice language"

complaining about perl not being pretty enough helps nobody

yes it does. Deciding to do parts of the code not in perl (in "some future"). And last time we discussed this, I didn't see this being acknowledged as part of a problem.

it doesn't help anything right now, that is true, though

because we should base our choices on how pretty people think the code is, sounds like a great plan

This is exactly what I am talking about. You don't seem to get the difference between "pretty" and easy to read and understand

Sorry, but this is not at all about pretty

It's about doing things with as few characters/lines as possible. Which is powerful, but not very "readable"

no, it's just about taking every fucking opportunity to complain about perl

if people don't like perl, they're welcome to rewrite all of mb for us

this is not about rewriting all of mb. This is about taking chances to change language when parts are rewritten

which we're already doing.

fine then ;-)

I have some issues with Perl and wouldn't mind seeing MB in another language, but it wasn't a particularly constructive comment.

noted. Seeing that construct really ticked me off, but I didn't expect that this again would tick nikki off like that

I'm just sick of seeing people complain about perl every chance they get, just because they can

Yes.. I try to stop that.

Something completely different: if Olivier Kaloudoff is online or known here: kalou.net seems to be offline and with it the metaflac Picard plugin. I can host it on one of my servers, but possible this is just a temporary problem (reported for 2 days now)

haha. "OK, if Java not optimised for strings, please let me know what exactly Java is optimised for."

Didn't we want to stop language bashing for today?

of course. I thought it was funny that the author(s) couldn't help him/her/themselves.

Of course, that's a three year old page. I wonder if the performance stats are still true-ish.

I can only talk for python (again): the benchmark uses "+" for strings. Which is fine if you use it once or twice, but not for a benchmark (join() is faster and making an array and joining the elements is even more faster and so on...)

faster as in "more than 10 times faster", not "you save 1%"

was that true in 2.5? maybe the stats were /never/ very truthy.

well, what benchmark is..

lesson learned :-)

CallerNo6: http://www.skymind.com/~ocrow/python_string/

I tested that some time ago for server software I wrote. It was different for recent Python, but I could still make things considerably faster

I think what is making that Java test so slow is that it has to compile the regular expression each invocation of the loop

Also I dont know perl but when it does replace doesnt it just call a c library to do that, so its not really testing perl

We have perfect right to moan about perl because weve been told for so long that perl is up to the job, when it clearly is not

Its not even a programming langage really, from wikipedia 'as a general-purpose Unix scripting language to make report processing easier'

yawn

[citation needed]

having seen perl run gigantic applications at scale

I disbelieve that perl is not "up to the job"

I want to switch between three different messages depending on whether a variable is 0, 1 or more. Should I use nested ?: , given/when, or something else?

and updated my pull request for mbs-3346: https://bitbucket.org/metabrainz/musicbrainz-se...

and updated again with ianmcorvidae's suggestion of us ln(). Thanks!