it complains Caught exception in MusicBrainz::Server::Controller::RelationshipEditor->base "Missing field: entity.1.type at lib/MusicBrainz/Server/Controller/RelationshipEditor.pm line 75, <GEN63> line 3."
2014-05-25 14511, 2014
bitmap
you probably need entity.1.type to be "url"
2014-05-25 14517, 2014
JesseW
ok.
2014-05-25 14519, 2014
JesseW
adding that
2014-05-25 14539, 2014
bitmap
I guess it's not smart enough to see that you're using the .text param
2014-05-25 14556, 2014
bitmap
hm
2014-05-25 14541, 2014
JesseW
still get bad request
2014-05-25 14543, 2014
bitmap
that should be rels.0.url, not rels.0.url.1.text
2014-05-25 14550, 2014
JesseW
ok
2014-05-25 14558, 2014
bitmap
er
2014-05-25 14504, 2014
JesseW
rels.0.url.text?
2014-05-25 14510, 2014
bitmap
rels.0.entity.1.url, I think
2014-05-25 14540, 2014
JesseW
rels.0.entity.1.url or rels.0.entity.1.url.text?
2014-05-25 14548, 2014
bitmap
the former
2014-05-25 14552, 2014
JesseW
ok
2014-05-25 14556, 2014
JesseW
testing
2014-05-25 14507, 2014
JesseW
bad request
2014-05-25 14547, 2014
JesseW
{"error":"invalid URL: at lib/MusicBrainz/Server/Controller/WS/js/Edit.pm line 255, <GEN44> line 3.\n"}
2014-05-25 14549, 2014
nikki
has that actually shipped yet?
2014-05-25 14510, 2014
JesseW
if not, how *should* the bots add URLs?
2014-05-25 14525, 2014
ianmcorvidae
yeah, I mean, just to confirm you're using beta
2014-05-25 14542, 2014
JesseW
I was using release. I'll switch to beta
2014-05-25 14502, 2014
JesseW
and that works
2014-05-25 14523, 2014
bitmap
oh...sorry, I thought that was released already
2014-05-25 14542, 2014
ianmcorvidae
last actual release was the schema change hotfixes XD
possibly you've reproduced the cache issue and that release group doesn't actually exist
2014-05-25 14534, 2014
JesseW
hm
2014-05-25 14543, 2014
bitmap
yeah, there's no release group with that gid
2014-05-25 14554, 2014
JesseW
but I wasn't trying to edit a release group.
2014-05-25 14501, 2014
JesseW
I was trying to add a URL to an artist
2014-05-25 14503, 2014
ianmcorvidae
oh heh, that's true
2014-05-25 14514, 2014
JesseW
which does exist on beta
2014-05-25 14529, 2014
JesseW
so something is odd, there
2014-05-25 14536, 2014
bitmap
but link_type 94 is for release groups
2014-05-25 14556, 2014
JesseW
is it now...
2014-05-25 14513, 2014
bitmap
(not that it should terribly ISE instead of saying that)
2014-05-25 14547, 2014
JesseW
so, what is one of the link types for an artist-url relationship?
2014-05-25 14550, 2014
JesseW
that I can use
2014-05-25 14502, 2014
ianmcorvidae
yeah, it's failing because it's not considering the types
2014-05-25 14515, 2014
ianmcorvidae
(that ID number is the artist rowid of the test artist)
2014-05-25 14533, 2014
bitmap
and we should probably support gids for the link_type field since those are actually visible on the website
2014-05-25 14548, 2014
ianmcorvidae
yeah
2014-05-25 14506, 2014
JesseW
so, on http://beta.musicbrainz.org/edit/27876598/data when it says: "link_type":{"long_link_phrase":"has a review page at","link_phrase":"reviews","name":"review","reverse_link_phrase":"review page for","id":94} that doesn't mean the link_type for "reviews" is 94?
2014-05-25 14549, 2014
bitmap
yes
2014-05-25 14511, 2014
ianmcorvidae
it does mean that, but it's the release_group-url one
2014-05-25 14531, 2014
ianmcorvidae
presumably that edit is in error/allowed when it shouldn't be
2014-05-25 14554, 2014
ianmcorvidae
(well, there's only the one, there's no artist-url review AR)
2014-05-25 14554, 2014
JesseW
yes, that appears to be an error, then
2014-05-25 14523, 2014
JesseW
hm
2014-05-25 14532, 2014
ianmcorvidae
anyway 183 is the artist-url official homepage rel
2014-05-25 14532, 2014
JesseW
sorry for the confusion
2014-05-25 14535, 2014
ianmcorvidae
if you want one to use for testing
2014-05-25 14541, 2014
JesseW
ok. thanks
2014-05-25 14558, 2014
JesseW
and that works
2014-05-25 14517, 2014
JesseW
yay!
2014-05-25 14520, 2014
ianmcorvidae
bitmap: if you have something to prevent rels like that with mismatched link_types I will absolutely hotfix that, btw
2014-05-25 14537, 2014
ianmcorvidae
(the l_ tables getting out of sync with the link table can be really annoying)
2014-05-25 14553, 2014
ianmcorvidae
(you have to drop triggers in a transaction and then delete and bring them back, or something? it's wacky)
2014-05-25 14513, 2014
bitmap
yeah, I'm investigating a fix
2014-05-25 14521, 2014
JesseW
bitmap: for rel-editor.as_auto_editor -- exactly what format should the (boolean) be in?
2014-05-25 14541, 2014
bitmap
0 or 1 should work
2014-05-25 14501, 2014
JesseW
bitmap: ok. Not "True" and "False"?
2014-05-25 14517, 2014
bitmap
I believe only 0 and 1 work
2014-05-25 14524, 2014
JesseW
ok
2014-05-25 14531, 2014
JesseW
that would be good to mention on the wiki page
2014-05-25 14538, 2014
bitmap
it is at the top :)
2014-05-25 14547, 2014
demosdemon joined the channel
2014-05-25 14559, 2014
bitmap
though it should mention that as_auto_editor is boolean
2014-05-25 14505, 2014
bitmap
in case it's not obvious
2014-05-25 14521, 2014
JesseW
yep. and maybe include it in the example
2014-05-25 14523, 2014
bitmap
(and it's a wiki page so feel free to change it)
2014-05-25 14502, 2014
JesseW
bitmap: will do
2014-05-25 14540, 2014
JesseW
I'll also add a mention of the {"edits":[{"message":"no changes"}]} value one gets back if the edit already exists.
2014-05-25 14500, 2014
JesseW
bitmap: also, it doesn't look like the return value specifies whether or not the edit was automatically applied. It might be nice to know that.
2014-05-25 14533, 2014
JesseW
and added to the wiki page
2014-05-25 14526, 2014
bitmap
thanks
2014-05-25 14534, 2014
demonimin joined the channel
2014-05-25 14536, 2014
demonimin joined the channel
2014-05-25 14518, 2014
JesseW
bitmap: it appears to return HTTP code 400 even when it succeeds. This is odd...
2014-05-25 14544, 2014
bitmap
hm, I think I see where that happens
2014-05-25 14547, 2014
JesseW
and the key is "error", not "errors"
2014-05-25 14502, 2014
ruaok joined the channel
2014-05-25 14506, 2014
Leftmost
Well, he was in and out fast. :-P
2014-05-25 14529, 2014
ianmcorvidae
he doesn't actually like us very much, dontchaknow ;)
2014-05-25 14524, 2014
Leftmost
I can't say as I blame him. :)
2014-05-25 14533, 2014
ianmcorvidae
we're pretty annoying, it's true
2014-05-25 14528, 2014
demosdemon joined the channel
2014-05-25 14511, 2014
_5moufl joined the channel
2014-05-25 14542, 2014
zas joined the channel
2014-05-25 14508, 2014
UmkaDK joined the channel
2014-05-25 14526, 2014
MBJenkins
Michael Wiencek: Various /relationship-editor endpoint fixes
