#musicbrainz-devel

so, for adding urls -- would this be the proper format:

{"rel-editor.rels.0.action":"add", "rel-editor.rels.0.entity.0.gid":"7e84f845-ac16-41fe-9ff8-df12eb32af55", "rel-editor.rels.0.entity.0.type": "artist","rel-editor.rels.0.url.1.text":"http://blah33434.example.net","rel-editor.rels.0.link_type":94}

it complains Caught exception in MusicBrainz::Server::Controller::RelationshipEditor->base "Missing field: entity.1.type at lib/MusicBrainz/Server/Controller/RelationshipEditor.pm line 75, <GEN63> line 3."

you probably need entity.1.type to be "url"

ok.

adding that

I guess it's not smart enough to see that you're using the .text param

hm

still get bad request

that should be rels.0.url, not rels.0.url.1.text

ok

er

rels.0.url.text?

rels.0.entity.1.url, I think

rels.0.entity.1.url or rels.0.entity.1.url.text?

the former

ok

testing

bad request

{"error":"invalid URL: at lib/MusicBrainz/Server/Controller/WS/js/Edit.pm line 255, <GEN44> line 3.\n"}

has that actually shipped yet?

if not, how *should* the bots add URLs?

yeah, I mean, just to confirm you're using beta

I was using release. I'll switch to beta

and that works

oh...sorry, I thought that was released already

last actual release was the schema change hotfixes XD

but the edit doesn't show up

yeah, I need to log in on beta

and that gives me a gigantic error message, available here: http://pastebin.ca/2773070

possibly you've reproduced the cache issue and that release group doesn't actually exist

hm

yeah, there's no release group with that gid

but I wasn't trying to edit a release group.

I was trying to add a URL to an artist

oh heh, that's true

which does exist on beta

so something is odd, there

but link_type 94 is for release groups

is it now...

(not that it should terribly ISE instead of saying that)

so, what is one of the link types for an artist-url relationship?

that I can use

yeah, it's failing because it's not considering the types

(that ID number is the artist rowid of the test artist)

and we should probably support gids for the link_type field since those are actually visible on the website

yeah

so, on http://beta.musicbrainz.org/edit/27876598/data when it says: "link_type":{"long_link_phrase":"has a review page at","link_phrase":"reviews","name":"review","reverse_link_phrase":"review page for","id":94} that doesn't mean the link_type for "reviews" is 94?

yes

it does mean that, but it's the release_group-url one

(well, there's only the one, there's no artist-url review AR)

yes, that appears to be an error, then

hm

anyway 183 is the artist-url official homepage rel

sorry for the confusion

if you want one to use for testing

ok. thanks

and that works

yay!

bitmap: if you have something to prevent rels like that with mismatched link_types I will absolutely hotfix that, btw

(the l_ tables getting out of sync with the link table can be really annoying)

(you have to drop triggers in a transaction and then delete and bring them back, or something? it's wacky)

yeah, I'm investigating a fix

bitmap: for rel-editor.as_auto_editor -- exactly what format should the (boolean) be in?

0 or 1 should work

bitmap: ok. Not "True" and "False"?

I believe only 0 and 1 work

ok

that would be good to mention on the wiki page

it is at the top :)

though it should mention that as_auto_editor is boolean

in case it's not obvious

yep. and maybe include it in the example

(and it's a wiki page so feel free to change it)

bitmap: will do

I'll also add a mention of the {"edits":[{"message":"no changes"}]} value one gets back if the edit already exists.

bitmap: also, it doesn't look like the return value specifies whether or not the edit was automatically applied. It might be nice to know that.

and added to the wiki page

thanks

bitmap: it appears to return HTTP code 400 even when it succeeds. This is odd...

hm, I think I see where that happens

and the key is "error", not "errors"

Well, he was in and out fast. :-P

he doesn't actually like us very much, dontchaknow ;)

I can't say as I blame him. :)

we're pretty annoying, it's true

Michael Wiencek: Various /relationship-editor endpoint fixes

Project musicbrainz-server_schema-change-2014-q4 build #81: FAILURE in 4.5 sec: http://ci.musicbrainz.org/job/musicbrainz-serve...

hm.

ah, we're off to a great start, I see :P

haha

well, this is just ci being silly, I think, but :P

I think I'll just delete the project and make bitmap set it up anew

renaming clearly didn't work properly :P

bitmap: http://tickets.musicbrainz.org/browse/MBH-370 re: above discussion

Project musicbrainz-server_master build #46: SUCCESS in 10 min: http://ci.musicbrainz.org/job/musicbrainz-serve...

Ian McEwen: Kill off admin/config.sh, moving it instead into DBDefs like everything else.

Project musicbrainz-server_beta build #105: SUCCESS in 11 min: http://ci.musicbrainz.org/job/musicbrainz-serve...

Ian McEwen: Kill off admin/config.sh, moving it instead into DBDefs like everything else.

Michael Wiencek: MBS-7623: beta: relationship editor on edit-url pages lacks validation