I noticed you say in #mb that it should be trivial, so we can look forward you implementing that being the first thing in may's schema change, right? ;)
nikki can try and persuade people to do things :P
JesseW
by May? Hm, quite possibily.
What would the deadline for getting that in by be?
JesseW is glad for the encouragement.
nikki
the deadline for the schema change scripts is generally a month before
JesseW
ok, so by April Fool's Day.
nikki
(since we have to finalise what's included so we can tell customers what to expect)
Freso
JesseW: However, having it ready earlier is by no means a bad thing.
JesseW
:-)
nikki
the actual ui stuff, well, the earlier the better but I'm sure we've merged stuff the day before the schema change before :P
not that that's ever a good idea XD
JesseW
btw, do you think that the attribute editing patch is ready? As I mentioned on bitbucket, it seems fine to me.
nikki
as far as I know, yes
JesseW
yay!
I'd love to have more of the descriptions populated (and displayed, but that's separate tickets)
nikki
well, populating the descriptions will happen once we have a way to populate them that doesn't involve manually writing sql and getting someone to run it :P
JesseW
nikki: yes, that's why I'm happy to hear that the attribute editing patch is ready. :-)
as you had previously told me about that precondition
nikki nods
CatCat joined the channel
xram joined the channel
d4rkie joined the channel
_dave_ joined the channel
The_Freso joined the channel
HSOWA joined the channel
vissborg joined the channel
kahu_ joined the channel
nikki__ joined the channel
xram joined the channel
MightyJay_ joined the channel
nikki__ joined the channel
Jormangeud^ joined the channel
kloeri_ joined the channel
gizah_ joined the channel
catgroove joined the channel
leonardo_ joined the channel
mueslix joined the channel
mueslix joined the channel
Nyanko-sensei joined the channel
ocharles_ joined the channel
ariscop joined the channel
CatQuest joined the channel
JesseW joined the channel
CatQuest has left the channel
CatCat joined the channel
ocharles_ joined the channel
navap joined the channel
Gentlecat joined the channel
navap1 joined the channel
navap1 joined the channel
Powlow joined the channel
Powlow joined the channel
Powlow joined the channel
JesseW joined the channel
Powlow joined the channel
ariscop joined the channel
How do I control the display of lines like: [debug] Path is "/collection/edit" when running the tests?
ianmcorvidae
JesseW: turn off CATALYST_DEBUG
JesseW
ah, makes sense, thanks
There appears to be no tests for adding an Event to a Collection.
I should probably submit some. :-)
Does the WS support doing that?
ianmcorvidae
IIRC no, we deliberately didn't add that so we wouldn't screw it up
JesseW
didn't add support to the WS, or didn't add the tests? <big grin>
nikki
both? :P
JesseW
heh
ok, well I'll add some tests to t::MusicBrainz::Server::Controller::WS::1::Collection
er, sorry, not there
to t::MusicBrainz::Server::Data::Collection
that's what I meant
ianmcorvidae
obviously didn't add to the tests :P the WS part was the deliberate lack of addition though
and yeah, data::collection tests would be good
JesseW
nods.
I noticed the lack when I accidentally completely broke adding events, and the tests didn't notice.
hm -- the database also appear to not care that two collections have the same gid...
oh, no I misread it -- they differ in the last digit...
it might be kind to future readers make them differ a *bit* more obviously than that (esp as the difference is d vs b)...
yeeeargh joined the channel
ariscop joined the channel
Julior joined the channel
Mineo joined the channel
drsaunders joined the channel
UmkaDK joined the channel
kahu joined the channel
axilla
morning :)
does the JSON API have the same syntax and capabilities as the XML?
i'm not seeing the search syntax and what not in the docs
just simple URL samples
am i just adding fmt json?
Freso
The query syntax should be the same, yes.
CatCat joined the channel
axilla
working this morning on knocking out a complete ruby wrapper for the json API
while currently spinning Ray Charles Greatest hits.. such a good sunday record.
since i've struggeled with that exact problem one or two days ago: you need to search for the specific format. e.g. "12" Vinyl" instead of just "vinyl"
mind that you have to escape the " after the 12 for lucene to use is correctly
You might also want to make the :format take a list/array: :format => ("Vinyl 12\"", "Vinyl")
(There's no 'Vinyl 12" Vinyl' format.)
axilla
using this API makes me want to gouge out my eyes.. whats with the format of release: AND artist: AND ?
why not like every other API.. format=blah&release=blah&
spaces :(
Mineo
how would you do disjunction or field grouping if all you have is "&"?
JesseW joined the channel
axilla
there are many ways..
you can pass a query string
something like field1=value&field2=value&field3=value
at work our RESTful API receives JSON so you can pass as much data as you like and then spits out JSON.
Freso
axilla: You can try out search queries on https://musicbrainz.org/search - the WS is using "Indexed search with advanced query syntax", so be sure to pick that.
That will probably be easier than sending WS requests while trying to get the hang of the query language.
kloeri joined the channel
nikki__ joined the channel
samgtr joined the channel
ocharles_ joined the channel
samgtr joined the channel
JesseW
What's a recommended way to make UUIDs for test data?