Ian McEwen: MBS-4145: tag upvoting/downvoting (schema only)
2015-04-30 12031, 2015
kahu joined the channel
2015-04-30 12015, 2015
johtso_ joined the channel
2015-04-30 12043, 2015
bitmap wonders about removing https://github.com/metabrainz/musicbrainz-server/blob/4088e87/lib/MusicBrainz/Server/Connector.pm#L55
2015-04-30 12028, 2015
bitmap
I don't know a way to have that execute on every pgbouncer backend, and it's already configurable at the user/database/transaction level if needed
2015-04-30 12003, 2015
bitmap
but removing would break the 'schema' setting in the DBDefs databases configuration, if it's different from the username or what's configured elsewhere
2015-04-30 12051, 2015
mb-chat-logger
New post: blog: Server update, 2015-04-27 <http://blog.musicbrainz.org/2015/04/30/server-update-2015-04-27/>
2015-04-30 12054, 2015
zas
for some reason, blog post on FB has no link/preview, just title
2015-04-30 12040, 2015
luks
I assume you know that chrome is now complaining about the SSL certificate on mb.org
2015-04-30 12014, 2015
ianmcorvidae
bitmap: that can be set at a user level, which might be the best/right way to do that
2015-04-30 12018, 2015
bitmap
yeah, that's what I was thinking
2015-04-30 12040, 2015
ianmcorvidae
our search path stuff is sort of weird anyway since we don't include things like the CAA
2015-04-30 12047, 2015
ianmcorvidae
never been quite sure what to do with that
2015-04-30 12019, 2015
bitmap
are we concerned about making the schema option useless/a noop though? I wonder how many people rely on that
2015-04-30 12030, 2015
ianmcorvidae
I have no idea
2015-04-30 12052, 2015
bitmap
I'm not even sure what the use case for that is
2015-04-30 12054, 2015
ianmcorvidae
we sort of hardcode it in a lot of places, but mbslave might be better about respecting it than our code is
2015-04-30 12014, 2015
ianmcorvidae
well, for configuring it, I guess if you want to have something with schema musicbrainz already
2015-04-30 12024, 2015
ianmcorvidae
but we don't let you configure any of the other schemas (e.g. cover_art_archive, documentation, wikidocs) so
2015-04-30 12036, 2015
ianmcorvidae
and I'm pretty sure replication doesn't work if you change it
2015-04-30 12037, 2015
ianmcorvidae
so... yeah
2015-04-30 12006, 2015
bitmap
we also assume 'musicbrainz' schema in Extensions.sql
2015-04-30 12007, 2015
bitmap
there's some code in mbslave that fixes the schema names, so yeah, it's likely better than ours
2015-04-30 12039, 2015
luks
mbslave lets you remap the schemas to anything
2015-04-30 12004, 2015
luks
e.g. for acoustid I merge them all to the 'musicbrainz' schema
2015-04-30 12006, 2015
bitmap
ah
2015-04-30 12046, 2015
luks
that's why you have any execute pretty much any sql script with mbslave-remap-schema.py
2015-04-30 12049, 2015
ianmcorvidae
I guess the only question is if we have anyone who uses it with musicbrainz-server and somehow hasn't run into trouble/can't just configure the search path themselves the same way we are
2015-04-30 12057, 2015
luks
because most of the upgrade scripts have schemas hardcoded
2015-04-30 12011, 2015
luks
I'd say just drop the option
2015-04-30 12035, 2015
ianmcorvidae
yeah
2015-04-30 12043, 2015
ianmcorvidae
we don't really make it an actual option anyway, so why pretend :P
