and it says "By default, these 'inc=' arguments will only load relationship for the requested entity.”, which I don’t understand. I think that’s related to the recording-level-rels etc item
"inc= arguments which affect subqueries” doesn’t say specifically for which entities they’re valid. You can only work it out from the description afterwards (I think)
bitmap
yeah, we don't restrict the inc params based on whether link types actually exist between two entity types or anything, so all are valid
alastairp
(If you answer these, I can make the wiki changes)
bitmap
by 'will only load relationship for the requested entity' I think it means for the requested resource, so if it's a direct lookup it'll only load them for that entity, if it's a browse request it'll load them for all the returned entities of whatever type you requested, but not any entities linked to those
Gentlecat joined the channel
_Dave_ joined the channel
Gentlecat
ruaok: yes, same length
alastairp
why does release browse not support tag and rating includes, but get does?
bitmap
I have no idea, tbh
alastairp
:)
ijabz2 joined the channel
OK. I always wanted to rewrite that docs page. Maybe I’ll do that
thanks again for your help. Now I can go and implement stuff!
(sigh)
bitmap
oh and for the subqueries, the first 3 are for release (though isrcs should only work if inc=media is included), artist-credits is valid on /ws/2/{artist,label,recording,release,release-group} if they have any of inc={recordings,releases,release-groups} from the above section
and various-artists says the only place it's used in the description
actually, isrcs should also work on /ws/2/artist with inc=recordings
alastairp, if you help me get my head around the subject, I'm happy to do the drudgery of editing the wiki
alastairp
CallerNo6: thanks for the offer
I’m not sure what the best way to reshuffle is
I think maybe the clearer way is to duplicate information - e.g. have a subsection per entity, which lists all its options
(and maybe another set of subsections that list what the options mean)
because to me the most common usecase is “I want to get a recording entity, what other things can I include with it"
which is really difficult at the moment
the opposite, which may be useful, is “what are all of the things which have areas"
but I think that’s less useful
bitmap
duplicating the info would be clearer I think, yeah, so people don't have to cross-reference as much
there's too many "oh and btw this inc param is valid in this scenario" paragraphs that are easy to miss
CallerNo6
iiuc, I agree. A set of reference tables is most important. But also maybe a few examples based on common questions, like "I have an artist name, how do I get a list of albums?"
ujjwal joined the channel
bitmap
yeah, a few common examples at the end of each section would be nice
Anything else I need to consider before upgrading postres?
Are there some modules that mbserver uses?
Gentlecat joined the channel
musicbrainz_collate.
bitmap
after upgrading I think you'll need to recompile the postgresql-musicbrainz-collate and postgresql-musicbrainz-unaccent extensions in the mbserver checkout
Ok, I appear to have hosed my database, so starting from scratch.
InitDB throwing an error with extensions
Thu May 7 22:30:41 2015 : psql:/home/mbserver/musicbrainz-server/admin/sql/Extensions.sql:4: ERROR: could not open extension control file "/usr/share/postgresql/9.4/extension/cube.control": No such file or directory
That file doesn't exist, should it?
luks
if you are on debian/ubuntu, you need the package with contrib modules
postgresql-contrib
adhawkins
Ok, got that, thanks. How can I drop the database?
ruaok
rvedotrc:oh yes.
ruaok pulls up the news.
luks
sudo -s postgres dropdb musicbrainz
sudo -u postgres
sorry
rvedotrc
I'm not really involved tonight (at work) - just being available /just in case/ something goes wonky,
adhawkins
Thu May 7 22:37:21 2015 : psql:/home/mbserver/musicbrainz-server/admin/sql/Extensions.sql:5: ERROR: could not open extension control file "/usr/share/postgresql/9.4/extension/musicbrainz_unaccent.control": No such file or directory
ruaok
oh ffs.
all i need to do is read the bbc headline.
close tab.
close tab
get more booze.
derwin
(bbc headline?)
rvedotrc
Extrapolation from zero results so far.
ruaok
> Election 2015: Exit poll puts Tories close to majority
derwin: sadly there is no acceptable outcome of this election.
and mind you I don't even live there!
luks
adhawkins: have you installed the musicbrainz extensions?
adhawkins
I dud.
did.
Ah, but then I purged postgres.
One sec.
That's better.
Now to do the database import :)
LordSputnik goes to sleep for 4 hours before the interesting part of the election results at 3am
LordSputnik
btw, if anyone has a few minutes spare, please try out http://bookbrainz.mbsandbox.org/ - we're beta testing the next release ;)
LordSputnik has left the channel
adhawkins
Any suggestions on this error importing?
cover_art_archive.art_type 0 0% 0Error loading /tmp/MBImport-KTIwo4M5/mbdump/cover_art_archive.art_type: DBD::Pg::db pg_putcopydata failed: no COPY in progress at /home/mbserver/musicbrainz-server/admin/MBImport.pl line 289, <LOAD> line 183.