#musicbrainz-devel

Meh, I'll just leave it then.

ocharles: at some point could you look into why jenkins thinks rocko is offline? I don't really know enough about it to figure that out

(seems to be some sort of SSH failure, but)

Project musicbrainz-server_beta build #567: STILL FAILING in 3 min 11 sec: http://ci.musicbrainz.org/job/musicbrainz-serve...

* Ian McEwen: MBS-4981/MBS-6563: correctly use cover_art_presence and the existence of a front image for a release

* Ian McEwen: MBS-5587: switch to Artwork::Release/Artwork::ReleaseGroup objects

* Ian McEwen: MBS-5587: remove Artwork::Release.

* Ian McEwen: MBS-6608: remove extraneous RequireAuth and correct to use simply Edit

* Ian McEwen: MBS-3823: Limit buttons to only Parse Tracks and Close in track parser

warp: if you're around at some point, could use tips on how to start the html5 validator on hobbes

ocharles: again, if you could look at your trigger for requiring a confirmed email address, I think it's tripping up modbot in tests and I'm not sure the correct way to fix it

Project musicbrainz-server_beta build #568: STILL FAILING in 4 min 36 sec: http://ci.musicbrainz.org/job/musicbrainz-serve...

good, at least the validator's back

Project musicbrainz-server_beta build #569: STILL FAILING in 2 min 43 sec: http://ci.musicbrainz.org/job/musicbrainz-serve...

Ian McEwen: Fix up small display issues with relationship documentation.

ianmcorvidae: I just ran that myself in a screen.

yeah, I started it in a screen as you

:)

took two times running the run script for it to actually work, but

validator.nu is offline :(

ianmcorvidae: yes, it's all a bit fiddly

removing the _name tables stuff is tedious but satisfying. thus far: 42 files changed, 261 insertions, 739 deletions

and I haven't even gotten to direct search yet! :D

reosarevok- you're working on the location code, right? curious to know how renames/rebranding will be handled :)

Unclear yet - I mean, they'll be an entity, like labels are or whatever

So, maybe through relationships like with labels? That's more of a style question, so it's not just for me to decide :)

I expect I'll have it all done a while before its October release date, so it should be possible later for people to play with it in a test environment and try to decide how they should be used exactly

i (fairly) recently coded a huge project like this for spfc.org, so I might be able to help point out certain scenarios

and as a side effect, I've got pretty accurate info on about 1000 venues :)

Well, the design of the entity itself is fairly simple in that it's pretty similar to the other entities we have. It's its usage which can prove interesting. I expect at some point we'll also add specific events that take place in venues and involve artists

But not yet :)

(I don't know if it makes sense to have "Artist X played venue Y on date Z" relationships until there's an actual event thing or not, for example, that one will be for style to decide)

I guess Aliases will apply to the venues, then, complete w/ date ranges?

like, here's 1 of the more complicated examples (all the same location):

HiFi Buys Amphitheatre (2001 to 2008)

Aaron's Amphitheatre at Lakewood (2009-05 to -)

heh

Yep, aliases do apply

(also argh :) )

cool

and yes, argh. :)

particularly frustrating when trying to determine what to display for the venue of a show in, say, 2008. Was it still HiFi Buys, or was it Lakewood? Exact date of the name change isn't always known. XD

& sometimes ticket stubs are printed before the name changes, etc. so that's not always accurate either

Again it'll be Style's choice I guess when to use aliases and when to use a new venue (seems like just a change of corporate sponsor for example is a good hint to use aliases, while a change of name and ownership and everything else is a good hint to add another venue with the same address, but stuff in between is kinda unclear)

yep

it's the same -place-, but it's not the same *place* :D

atleast here in Rotterdam venues tend to close down for months before a new owner re-opens with a new name >_<

Ahoy!

well, that one hasn't closed. at least, that I know of.

ocharles: I'm told you were working on a fix for the mm. breakage? Could you please finish that? It's frustrating users quite a bit :/

Hello

reosarevok: Ok, I'll try and get that done today

Thanks! :)

* warp: MBS-6611, filesize.js has some strange defaults, provide a wrapper in MB.utility to configure it.

* warp: MBS-6611, add comment explaining arguments in filesize call.

warp: MBS-6549, support transformations in seeded release events.

STILL FAILING

Project musicbrainz-server_beta build #572: STILL FAILING in 2 min 48 sec: http://ci.musicbrainz.org/job/musicbrainz-serve...

warp: MBS-6256, Add autocomplete lookup on relationship example edit page.

Right, time to get beta passing

We shouldn't be merging to something that's not passing ci

(other than merging fixes)

the problem I know of is the one I've asked you about twice, ocharles

the trigger on edit requiring a confirmed email has been preventing ModBot from putting in edits

(something I added is apparently our first test that results in a ModBot edit)

I wasn't sure if I should change the trigger to special-case modbot, or set modbot with an email

ah

(well, rather, with an email confirm date)

ianmcorvidae: yes, but sending me messages at 3am is not a reliable way to get me to fix it :)

and I'm fixing it to give modbot an email address, because there's no reason it shouldn't have one

I was mostly hoping they'd be a reliable way to get an answer when you woke up in the morning :)

if we haven't got one in production we should make one or use support@

ianmcorvidae: if it's something i need to see, email is much more reliable

we don't have one in production either

i don't always check chat logs

support@ seems reasonable to me

ok, I will add that now

yeah; I guess I rely on having said your name (for me that appears in my awaylog)

but I'll note to email you in the future, thanks

ta

Oliver Charles: Make sure ModBot has a confirmed email address in tests

Project musicbrainz-server_beta build #574: STILL FAILING in 9 min 38 sec: http://ci.musicbrainz.org/job/musicbrainz-serve...

Oliver Charles: Fix Edit tests

# Failed test at t/lib/t/MusicBrainz/Server/Controller/UnconfirmedEmailAddresses.pm line 46.

# Comparing $data as a Set

# Missing: 'Controller::CDTOC::remove', 'Controller::Release::change_quality'

interesting :)

Project musicbrainz-server_beta build #575: FIXED in 9 min 41 sec: http://ci.musicbrainz.org/job/musicbrainz-serve...

Oliver Charles: Update UnconfirmedEmailAddresses test expectations

merge time!

Project musicbrainz-server_beta build #576: FAILURE in 7 min 38 sec: http://ci.musicbrainz.org/job/musicbrainz-serve...

* Oliver Charles: MBS-6066: Deny edit relationship edits when link type has changed

* Oliver Charles: MBS-6596: Fix definedness check when showing release events

* Oliver Charles: MBS-6494: Artist end area implies artist has ended

* Oliver Charles: MBS-6408: Add the s_release_event view

Well that lasted

Time to get pgtap installed locally and stop guessing at writing my pgtap scripts

</guilt>

Oliver Charles: MBS-6565: Redirect mm.musicbrainz.org to musicbrainz.org

I finally managed to make Ohloh create MetaBrainz there: https://www.ohloh.net/orgs/MetaBrainz

nice

Project musicbrainz-server_beta build #578: FIXED in 8 min 41 sec: http://ci.musicbrainz.org/job/musicbrainz-serve...

Oliver Charles: Fix artist.end_area tests to not use VA and have valid syntax

ocharles: interesting post, I'll read it asap. thanks

larsen: the one I just blogged?

For those who didn't see me post it: http://ocharles.org.uk/blog/posts/2013-07-26-a-...

Leftmost ^

ocharles: yes

larsen: spooky, I'm not used to people noticing my writing before I publically announce it ;)

I hope you like it!

ocharles: particularly interesting for me since I use Perl daily and I'm dabbling with Haskell

ocharles: just noticed the twit about it :)

larsen: your first name doesn't happen to be Matt, does it?

larsen: nope (you mean Matt Trout?)

larsen: oh cool :)